Build #36

Plan branch:

Build: #36 was successful Changes by André Offringa <offringa@gmail.com>

Stages & jobs

  1. Tag

  2. Default Stage

  3. Create Test Plan Branch

Code commits

GitHub Casacore

  • André Offringa <offringa@gmail.com>

    André Offringa <offringa@gmail.com> 1ec60c69b7e197309aca2f4a845d25dc444f9c65

    Modernize the Constants.h file and switch to c++17 (#1346)
    * Modernize the Constants.h file and switch to c++17

    The Constants.cc fails to compile on my compiler (gcc 13.2), because it complaints that the constants should be declared inside namespace C. Looking at the file
    it seems to contain a lot of constants that are declared nowadays in the standard C++ headers. I propose to make the duplicates deprecated.

    Also, they can be constexpr which will potentially allow more functions to become constexpr. This however requires C++17. Since modern compilers compile in C++17 by default nowadays, this might be a good moment to switch
    (for discussion). It eliminates a .cc file.

    • CMakeLists.txt (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • casa/BasicMath/Math.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • casa/BasicMath/Random.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • casa/BasicSL/Complex.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • casa/BasicSL/Constants.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • casa/BasicSL/Constants.h (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • casa/BasicSL/test/tConstants.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • casa/CMakeLists.txt (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • casa/Quanta/MVAngle.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • casa/Quanta/MVFrequency.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • casa/Quanta/MVTime.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • casa/Quanta/MVuvw.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • casa/Quanta/QC.h (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • casa/Quanta/UnitMap7.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • casa/Quanta/test/tUnit.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • casa/Utilities/ValType.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • coordinates/Coordinates/DirectionCoordinate.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • coordinates/Coordinates/FITSCoordinateUtil.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • coordinates/Coordinates/GaussianConvert.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • coordinates/Coordinates/ObsInfo.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • coordinates/Coordinates/test/dCoordinates.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • coordinates/Coordinates/test/tDirectionCoordinate.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • fits/FITS/fits.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • images/Images/ImageExprParse.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • images/Images/test/tImageExprGram.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • images/Regions/WCEllipsoid.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • lattices/LEL/LatticeExprNode.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • lattices/LEL/test/tLatticeExprNode.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • lattices/LRegions/LCEllipsoid.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • lattices/LRegions/test/tLCEllipsoid.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • lattices/LatticeMath/Fit2D.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • lattices/LatticeMath/LatticeHistSpecialize.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • lattices/LatticeMath/test/tFit2D.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • meas/MeasUDF/DirectionEngine.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • measures/Measures/EarthField.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • measures/Measures/MCEpoch.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • measures/Measures/MCFrequency.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • measures/Measures/MCPosition.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • measures/Measures/MCRadialVelocity.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • measures/Measures/MCuvw.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • measures/Measures/MeasMath.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • measures/Measures/MeasTable.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • measures/Measures/MeasuresProxy.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • measures/Measures/UVWMachine.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • measures/Measures/test/dM1950_2000.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • measures/TableMeasures/test/tTableQuantum.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • ms/MSOper/NewMSSimulator.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • ms/MSSel/MSSelector.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • ms/apps/writems.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • msfits/MSFits/FitsIDItoMS.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • msfits/MSFits/MSFitsOutput.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • msfits/MSFits/MSFitsOutputAstron.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Fitting/FitGaussian.tcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Functionals/CompiledFunction.tcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Functionals/FuncExpression.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Functionals/Gaussian1DParam.tcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Functionals/Gaussian2DParam.tcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Functionals/Gaussian3DParam.tcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Functionals/GaussianNDParam.tcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Functionals/KaiserBFunction.tcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Functionals/SincFunction.tcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Functionals/Sinusoid1D.tcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Functionals/Sinusoid1D2.tcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Functionals/test/tCompoundFunction.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Functionals/test/tGaussian1D.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Functionals/test/tGaussian2D.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Functionals/test/tGaussianND.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Functionals/test/tSinusoid1D.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Mathematics/AutoDiffMath.tcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Mathematics/FFTServer.hcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Mathematics/GaussianBeam.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Mathematics/Interpolate2D2.tcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Mathematics/MathFunc.tcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Mathematics/NumericTraits.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Mathematics/SparseDiffMath.tcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Mathematics/VanVleck.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Mathematics/VectorKernel.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Mathematics/test/tGaussianBeam.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/Mathematics/test/tVanVleck.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/StatsFramework/BiweightStatistics.tcc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/StatsFramework/test/tBiweightStatistics.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • scimath/StatsFramework/test/tClassicalStatistics.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • tables/TaQL/ExprFuncNode.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • tables/TaQL/ExprFuncNodeArray.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • tables/TaQL/test/tExprUnitNode.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)
    • tables/TaQL/test/tTableGramFunc.cc (version 1ec60c69b7e197309aca2f4a845d25dc444f9c65)