Build: #36 was successful Changes by André Offringa <offringa@gmail.com>

Stages & jobs

  1. Tag

  2. Default Stage

  3. Create Test Plan Branch

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
86 minutes
Labels
None
Agent
cbt-el7-6.cv.nrao.edu
Revisions
Casa6
7ad6c8f85bd733c5363b56b79fb490169ad453c8 7ad6c8f85bd733c5363b56b79fb490169ad453c8
OPEN-CASA-PKG
4b9064f16a8d185b162391c3ef324299625bd94b 4b9064f16a8d185b162391c3ef324299625bd94b
GitHub Casacore
1ec60c69b7e197309aca2f4a845d25dc444f9c65 1ec60c69b7e197309aca2f4a845d25dc444f9c65
Successful since
#30 ()

Code commits

GitHub Casacore
Author Commit Message Commit date
André Offringa <offringa@gmail.com> André Offringa <offringa@gmail.com> 1ec60c69b7e197309aca2f4a845d25dc444f9c65 1ec60c69b7e197309aca2f4a845d25dc444f9c65 Modernize the Constants.h file and switch to c++17 (#1346)
* Modernize the Constants.h file and switch to c++17

The Constants.cc fails to compile on my compiler (gcc 13.2), because it complaints that the constants should be declared inside namespace C. Looking at the file
it seems to contain a lot of constants that are declared nowadays in the standard C++ headers. I propose to make the duplicates deprecated.

Also, they can be constexpr which will potentially allow more functions to become constexpr. This however requires C++17. Since modern compilers compile in C++17 by default nowadays, this might be a good moment to switch
(for discussion). It eliminates a .cc file.