Build: #109 failed Changes by Srikrishna Sekhar
Code commits
Casa6
-
Srikrishna Sekhar 04fa0fac09a9ce013fd5afad96ad6f9fbf6bebc7
Pull request #981: CAS-14283
Merge in CASA/casa6 from CAS-14283 to master
* commit 'd63bad83160ec8a7e52d07166dff16233fc2f6a0': (57 commits)
Removed debug print statement
CAS-14283 : Fix for unit test warning
trigger build [CAS-14283]
trigger build [CAS-14283]
trigger build [CAS-14283]
CAS-14283: Update convergence check to match SIIterBot
CAS-14283 : Add trap for blank imagename
CAS-14283 : Write iclean history into images
trigger branch rebuild [CAS-14283]
CAS-14283 : Add iclean.xml
trigger build [CAS-14283]
CAS-14283 : Return global dict in restore()
CAS-14283 : Fix broken unit tests
CAS-14283 : Fix name of `def cmds` to `def _logs`
CAS-14283 : Fix formatting of convergence log
CAS-14283 : Add convergence logging
CAS-14287 : Fix bug with restore over fields
trigger new build [CAS-14283]
CAS-14283 : Removed debug print statements
CAS-14283 : Fix for convergence result
... -
Srikrishna Sekhar d63bad83160ec8a7e52d07166dff16233fc2f6a0 m
Removed debug print statement
One debug print statement was left behind accidentally. -
Srikrishna Sekhar fefe6134e07fd2d5b9b61575591972e0933dc2f5 m
Merge remote-tracking branch 'origin/master' into CAS-14283
-
Srikrishna Sekhar 6bf8d2f1a7ba2738a03a9793be344c49f6180910 m
CAS-14283 : Fix for unit test warning
If threshold == 0, one of the convergence checks was issuing a divide by
zero warning. Now the threshold is checked and the relative change is
only performed if threshold is non-zero. -
Darrell Schiebel <darrell@schiebel.us> d47f445f5301d601d7906dc999571ca9a7c5c9d9 m
trigger build [CAS-14283]
-
Darrell Schiebel <darrell@schiebel.us> 0915812bd7238a3951f3e9b4f002cf23457af3d5 m
trigger build [CAS-14283]
-
Darrell Schiebel <darrell@schiebel.us> 37c1e7bcbe5d329bea0c76f49bcb4f71b21c6a35 m
trigger build [CAS-14283]
-
Srikrishna Sekhar a5a84ca9470abbdb4d710330d1cb499e6dead6c1 m
CAS-14283: Update convergence check to match SIIterBot
Upated convergence check in imager_return_dict.py to match the threshold
condition in SIIterBot. The condition in SIIterBot has both a direct
peakres <= threshold as well as a relative (peakres -
threshold)/threshold < tol where tol is hardcoded to 0.1
This commit adapts the same criterion for the interactive clean backend.
This avoids running into edge cases where deconvolve thinks it has
converged, but gclean does not. -
Srikrishna Sekhar 348782fa353df67904e399ae4cec433ccab25705 m
CAS-14283 : Add trap for blank imagename
Added a trap in __init__ of _gclean.py to check for imagename=''. The
XML traps do not seem to work for checking the length of the string. -
Srikrishna Sekhar a70ab01666155d9b28e6012a5029bc64e03595dc m
CAS-14283 : Write iclean history into images
Added code (taken from tclean.py) to write the iclean command into the
history of the relevant images. -
Darrell Schiebel <darrell@schiebel.us> f7cb552d766142db1df5dd36500026a8f3f778db m
trigger branch rebuild [CAS-14283]
-
Srikrishna Sekhar 1a5539bb76f9efc604df739cdb47a6efd442a019 m
CAS-14283 : Add iclean.xml
Add iclean.xml to the docs to auto-generate the readthedocs page for
task_iclean. -
Darrell Schiebel <darrell@schiebel.us> 040abd487ecfa9ad5b4c1f3fc800c1b9b594deff m
trigger build [CAS-14283]
-
Srikrishna Sekhar e9db18feee27adeb14c60427d96d14f6c462a489 m
CAS-14283 : Return global dict in restore()
Restore now returns the global image return dictionary. This will keep
the return value consistent with tclean at progam exit. -
Srikrishna Sekhar a5aed2f3b3bc02da3b9f377799df9056ed0c26bc m
CAS-14283 : Fix broken unit tests
Some local variables were not being initialized correctly, causing
crashes under certain conditions. That is now fixed.- casatasks/src/private/imagerhelpers/_gclean.mustache (version a5aed2f3b3bc02da3b9f377799df9056ed0c26bc) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.py (version a5aed2f3b3bc02da3b9f377799df9056ed0c26bc) (diffs)
- casatasks/src/private/imagerhelpers/imager_return_dict.py (version a5aed2f3b3bc02da3b9f377799df9056ed0c26bc) (diffs)
-
Srikrishna Sekhar bf35d901138d909a478bb0d52539a7758426748b m
Merge remote-tracking branch 'origin/master' into CAS-14283
-
Srikrishna Sekhar 706cf1e02f40ea42e3f98fcef007cf9c67baa1e0 m
CAS-14283 : Fix name of `def cmds` to `def _logs`
The previous commit did not contain the name change - something went
wrong between the mustache template and the py file.
Manually rolled back the change and re-did it, and now the function name
change is picked up correctly by the mustache file. -
Srikrishna Sekhar 2b4b1e909f1f5f8a2afbbf8fa59ad35ffd7cccd7 m
CAS-14283 : Fix formatting of convergence log
Made convergence log more readable. Better aligned in monospace than
proportional font, but either way more readable than the older commits. -
Srikrishna Sekhar a1bba4878c94762f2cd69e24e26cbd0a142797fb m
Merge remote-tracking branch 'refs/remotes/origin/CAS-14283' into CAS-14283
-
Srikrishna Sekhar 6d55d3990ef3acfdb6583e7c9dbaf19a26c8b965 m
CAS-14283 : Add convergence logging
Added logging of per-field convergence information to the iclean log
window.
Renamed the logging function `_log` from `cmds` to reflect that it is no
longer only the commands (tclean, deconvolve) being logged.- casatasks/src/private/imagerhelpers/_gclean.mustache (version 6d55d3990ef3acfdb6583e7c9dbaf19a26c8b965) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.py (version 6d55d3990ef3acfdb6583e7c9dbaf19a26c8b965) (diffs)
- casatasks/src/private/imagerhelpers/imager_return_dict.py (version 6d55d3990ef3acfdb6583e7c9dbaf19a26c8b965) (diffs)
-
Srikrishna Sekhar b098a4cd34ea29d980c247719ca31cf1af280d82 m
CAS-14287 : Fix bug with restore over fields
When restoring, it would check self.hasit, i.e., if clean had converged
on that field or not. This is not relevant for restoration and we want
it to always restore over all fields. This commit fixes this bug. -
Darrell Schiebel <darrell@schiebel.us> 8997e672797388a8d4962456218c2429aafbc367 m
trigger new build [CAS-14283]
-
Srikrishna Sekhar 4549af622f499733dc2f02a80d53563327a4efd5 m
CAS-14283 : Removed debug print statements
Removed some debug print statements - and pushing to trigger a build. -
Srikrishna Sekhar 262c4308d3e408af50b451c5968a7b9c10a70f80 m
CAS-14283 : Fix for convergence result
Reverted to the "old" convergence result format (i.e., before the last
commit) but fixed the duplication issue across multiple fields. -
Srikrishna Sekhar ad2ccde24f9bb5d9dd99727f7604a4080e50e660 m
CAS-14283 : Remove pdb.set_trace()
The previous commit had a pdb.set_trace() still in the code. -
Srikrishna Sekhar 368a3e25e2b1eedb2f08e2c6a2d2b585885e78df m
CAS-14283 : Fix convergence result duplication
The convergence result was not returning the multi-field version, and
hence the convergence info for all fields were the same.
The convention for the ConvergenceResult object is within the "chan" key
of the final element of the tuple (i.e., convergence_result[5]) each
field is referred to by name rather than index.- casatasks/src/private/imagerhelpers/_gclean.mustache (version 368a3e25e2b1eedb2f08e2c6a2d2b585885e78df) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.py (version 368a3e25e2b1eedb2f08e2c6a2d2b585885e78df) (diffs)
- casatasks/src/private/imagerhelpers/imager_return_dict.py (version 368a3e25e2b1eedb2f08e2c6a2d2b585885e78df) (diffs)
-
Srikrishna Sekhar e1f5310cfced6c04a7479f31995026b7b0c82af5 m
CAS-14283 : Remove debug print statements
Removed several debugging print statements. No other changes.- casatasks/src/private/imagerhelpers/_gclean.mustache (version e1f5310cfced6c04a7479f31995026b7b0c82af5) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.py (version e1f5310cfced6c04a7479f31995026b7b0c82af5) (diffs)
- casatasks/src/private/imagerhelpers/imager_return_dict.py (version e1f5310cfced6c04a7479f31995026b7b0c82af5) (diffs)
-
Srikrishna Sekhar b27faf68402778cb706f162ef39ca5e7eb244435 m
CAS-14283 : Fix multifield iteration control
This commit fixes the last (hopefully...) of the show-stopping bugs for
multi-field iteration control. Masks can be present in any of the fields
individually, and the backend appears to do the right thing.
Some functions that were not being used were cleaned up and deleted, and
some print statements have been taken out. There are still many
debugging print statements, which will be stripped out in the next
commit.- casatasks/src/private/imagerhelpers/_gclean.mustache (version b27faf68402778cb706f162ef39ca5e7eb244435) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.py (version b27faf68402778cb706f162ef39ca5e7eb244435) (diffs)
- casatasks/src/private/imagerhelpers/imager_return_dict.py (version b27faf68402778cb706f162ef39ca5e7eb244435) (diffs)
-
Srikrishna Sekhar b7613fee42df38b52c94d7145ff2206db3d0e9ad m
Intermediate commit - things are broken.
-
Srikrishna Sekhar 97b1885c9dd7a53d4477cb6e9804ca4835b099de m
CAS-14283: Fix unit tests
Fixed the gclean unit tests - this will allow the automated Bamboo
builds to go through.
They were failing because of changes (and bugs) in the revised iteration
control for multi-fields. The return values had changed, which was
making most of the tests fail. In addition, there was a bug where the
input mask was not being dealt with correctly across all fields, causing
2 tests to fail.
Both these issues have been fixed.- casatasks/src/private/imagerhelpers/_gclean.mustache (version 97b1885c9dd7a53d4477cb6e9804ca4835b099de) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.py (version 97b1885c9dd7a53d4477cb6e9804ca4835b099de) (diffs)
- casatasks/src/private/imagerhelpers/imager_return_dict.py (version 97b1885c9dd7a53d4477cb6e9804ca4835b099de) (diffs)
- casatasks/tests/scripts/test_imagerhelpers_gclean.py (version 97b1885c9dd7a53d4477cb6e9804ca4835b099de) (diffs)
-
Srikrishna Sekhar dbc45a6b5bbab6691c828df8b6cf1c0d86c2f104 m
CAS-14283 : Minor bugfixes
Fixed issues with GUI parameters not being passed into deconvolve
correctly on modification.
Initial work to fix bug where if the first field is not masked,
deconvolution entirely stops.- casatasks/src/private/imagerhelpers/_gclean.mustache (version dbc45a6b5bbab6691c828df8b6cf1c0d86c2f104) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.py (version dbc45a6b5bbab6691c828df8b6cf1c0d86c2f104) (diffs)
- casatasks/src/private/imagerhelpers/imager_return_dict.py (version dbc45a6b5bbab6691c828df8b6cf1c0d86c2f104) (diffs)
-
Srikrishna Sekhar 41d88ec77a81645bfa933e530b38438bae4a6b3c m
CAS-14283: Fix cycleniter being ignored
With the multi-field refactor, the input cycleniter was not being
respected by the deconvolve task. This has been fixed, and verified in
the single field case.- casatasks/src/private/imagerhelpers/_gclean.mustache (version 41d88ec77a81645bfa933e530b38438bae4a6b3c) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.py (version 41d88ec77a81645bfa933e530b38438bae4a6b3c) (diffs)
- casatasks/src/private/imagerhelpers/imager_return_dict.py (version 41d88ec77a81645bfa933e530b38438bae4a6b3c) (diffs)
-
Srikrishna Sekhar 0b1d1fa2e686732a97a59f79fa62a63e7ef69ada m
CAS-14283: Improve iteration control
Made changes to iteration control to better support multi-field use
cases. Tested on both multi- and single- field and it seems to work
after initial (minimal...) testing.
There is still a phantom bug where it thinks it's converged and does
nothing under certain circumstances, that needs to be debugged. This is
not yet fully working.- casatasks/src/private/imagerhelpers/_gclean.mustache (version 0b1d1fa2e686732a97a59f79fa62a63e7ef69ada) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.py (version 0b1d1fa2e686732a97a59f79fa62a63e7ef69ada) (diffs)
- casatasks/src/private/imagerhelpers/imager_return_dict.py (version 0b1d1fa2e686732a97a59f79fa62a63e7ef69ada) (diffs)
-
Srikrishna Sekhar f95757a90bf8c77e8211fd5a77f030afe729ce53 m
CAS-14283 : Some minor clean up
Removed print statements and debugging statements that are no longer
necessary.- casatasks/src/private/imagerhelpers/_gclean.mustache (version f95757a90bf8c77e8211fd5a77f030afe729ce53) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.py (version f95757a90bf8c77e8211fd5a77f030afe729ce53) (diffs)
- casatasks/src/private/imagerhelpers/imager_return_dict.py (version f95757a90bf8c77e8211fd5a77f030afe729ce53) (diffs)
-
Srikrishna Sekhar 09b40c42e6113997c36722da54c0c027afba55f0 m
CAS-14283: Fix issue with peakres comparison
`peakres` was being incorrectly compared to a None in the event of a
field with no masking. This is fixed in this commit. -
Srikrishna Sekhar 0bbe75f225ed2bdd424c417197a1ec28cf1a0f3d m
CAS-14283: multi-field pipes are working
The iteration control has not been validated yet, but in the backend the
pipes for multi-field support appear to be working.- casatasks/src/private/imagerhelpers/_gclean.mustache (version 0bbe75f225ed2bdd424c417197a1ec28cf1a0f3d) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.py (version 0bbe75f225ed2bdd424c417197a1ec28cf1a0f3d) (diffs)
- casatasks/src/private/imagerhelpers/imager_return_dict.py (version 0bbe75f225ed2bdd424c417197a1ec28cf1a0f3d) (diffs)
-
Srikrishna Sekhar 5dc70528a30962d94ef41ac76227298bf7ddea1c m
CAS-14283 : BROKEN -- Working on per-field iteration control
Broken commit. Intermediate state of per-field iteration control. Put in
per-field convergence checks that filter out into the global convergence
checks.
Still need to get the convergence_result tuple in the right format.- casatasks/src/private/imagerhelpers/_gclean.mustache (version 5dc70528a30962d94ef41ac76227298bf7ddea1c) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.py (version 5dc70528a30962d94ef41ac76227298bf7ddea1c) (diffs)
- casatasks/src/private/imagerhelpers/imager_return_dict.py (version 5dc70528a30962d94ef41ac76227298bf7ddea1c) (diffs)
-
Srikrishna Sekhar 123d5027a7951d3d765295f4a8814e367cb1ba3f m
CAS-14283: Fix image_parameters params
The image_parameters function now returns the image base name, and drops
the imageidx parameter. -
Srikrishna Sekhar 8e675dd3eabbc636fdfa10562373c25c2198b4f1 m
CAS-14283: Fix yet another broken commit...
Accidentally committed the files within the build/ directory in the last
commit. This one deletes them, and puts the right ones in place. It also
edits the .gitignore to ignore the build/ directory- .gitignore (version 8e675dd3eabbc636fdfa10562373c25c2198b4f1) (diffs)
- casatasks/build/lib.linux-x86_64-3.10/casatasks/private/imagerhelpers/_gclean.mustache (version 8e675dd3eabbc636fdfa10562373c25c2198b4f1) (diffs)
- casatasks/build/lib/casatasks/private/imagerhelpers/_gclean.py (version 8e675dd3eabbc636fdfa10562373c25c2198b4f1) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.mustache (version 8e675dd3eabbc636fdfa10562373c25c2198b4f1) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.py (version 8e675dd3eabbc636fdfa10562373c25c2198b4f1) (diffs)
-
Srikrishna Sekhar 1d2127b7dc0179cf2170c6df16f39bec808d982a m
CAS-14283: Fix previous mangled commit + bugfixes
The previous commit was mangled, some missing function definitions.
Fixed those, as well as a handful of other minor bugs. This still has
not been verified to work with the front-end. -
Srikrishna Sekhar 2bad6330f05fe461bc8af8735149cd7fc8f8d66b m
CAS-14283: Expand multi-field support
Expanded multi-field support, deconvolve iterates over each field,
tclean seems to do the joint predict correctly.
Added a convenience function that returns the image names for each
field - image_products() -
Srikrishna Sekhar ca916c622bc5e746a217034a4dd03c2a08a8de37 m
CAS-14283 : Add multifield support (broken)
Initial commit of the multi-field support functionality. All the pieces are in
place, but it has not been tested end-to-end yet, so it's not clear if there
are any show stopper bugs here.- casatasks/src/private/imagerhelpers/_gclean.mustache (version ca916c622bc5e746a217034a4dd03c2a08a8de37) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.py (version ca916c622bc5e746a217034a4dd03c2a08a8de37) (diffs)
- casatasks/src/private/imagerhelpers/imager_return_dict.py (version ca916c622bc5e746a217034a4dd03c2a08a8de37) (diffs)
- casatasks/src/private/imagerhelpers/input_parameters.py (version ca916c622bc5e746a217034a4dd03c2a08a8de37) (diffs)
- casatasks/src/private/task_tclean.py (version ca916c622bc5e746a217034a4dd03c2a08a8de37) (diffs)
-
Srikrishna Sekhar d6a5af998930dbc595346198a1c137a817ed77af m
CAS-14283 : Fix stopcode bug
The stopcodes were changed from a single number to a tuple of (major,
minor). There were a handful of bugs in this implementation, this commit
fixes those bugs.
The namedtuple casting was incorrectly done - fixed
The convergence check within gclean was not correctly implemented -
fixed- casatasks/src/private/imagerhelpers/_gclean.mustache (version d6a5af998930dbc595346198a1c137a817ed77af) (diffs)
- casatasks/src/private/imagerhelpers/_gclean.py (version d6a5af998930dbc595346198a1c137a817ed77af) (diffs)
- casatasks/src/private/imagerhelpers/imager_return_dict.py (version d6a5af998930dbc595346198a1c137a817ed77af) (diffs)
-
Srikrishna Sekhar bf0199432c23c699e76e6d5cf7b5805c7c3eac1a m
CAS-14283 : Add stopcode tuples to has_converged()
has_converged now returns the stopcodes as a tuple of [major, minor]. This has
been implemented as a namedtuple, rather than a list or dict. A namedtuple
allows multiple routes of access that are equivalent, such as stopcodes.major
or stopcode[0]. -
Srikrishna Sekhar 8915f6b314b83694c19fac7f5f2b99a4d80edbe6 m
Merge remote-tracking branch 'origin/master' into CAS-14283
-
Srikrishna Sekhar 2a418b29dcd4508e4a359cf527eb1cce6ca0d055 m
CAS-14283 : improve savemodel behaviour
savemodel='modelcolumn' would previously run every major cycle (if requested).
However this is not desired, since the user could potentially add/remove/edit
the mask every major cycle, effectively re-writing the predicted model.
The predict has now been moved to be co-located with the restore step, after
all cleaning has completed. This should improve compute performance in cases
where the major cycle begins to get expensive. -
Ville Suoranta fca9bb0485e329acfe845171c000499bb69877c4 m
Merge branch 'master' into CAS-14283
-
Srikrishna Sekhar 75ef89ed39ff82f8b37556658b3bd498d8b6d6b6 m
CAS-14283: make param validation a static method
The parameter validation function is now a @staticmethod, that does not invoke
`self` within the class. This is in view of allowing remote execution of
interactive clean. -
Srikrishna Sekhar 89a71e25780615d9f433151cf08d2ca38cccedcf m
CAS-14283: Add _gclean.mustache
Added the mustache template for _gclean. This commit contains the mustache
template as well as the generated python file. The generation happens via
Darrell's expandtemplates script within casagui, and was run offline prior to
this commit.
It might be necessary to incorporate some version of this file into the build
system to generate the .py files on the fly, but for the moment this seems to
work alright. -
Darrell Schiebel <darrell@schiebel.us> e84e0bc9a65773a2e5e53b55bfaf3994ab0c5964 m
trigger rebuild [CAS-14283]
-
Darrell Schiebel <darrell@schiebel.us> db1a1911fc851cf47d5ae9e3ba5df1708546b110 m
trigger rebuild [CAS-14283]
-
Srikrishna Sekhar d190cb0804cfef791fa20da0622c8e7b9099cd18 m
CAS-14283: Fix bug with initial residual and deconvolve
When the initial residual was made, `deconvolve` was called with `self._niter`,
and performed actual iterations before the GUI popped up. This resulted in the
initial model image being populated, as well as other side-effects such as
cyclethreshold etc. being computed.
The net result was that the first user-defined trigger for the major cycle
would more often than not run zero or one iterations and quit, since the peak
is already close to the cyclethreshold.
This has now been fixed. -
Srikrishna Sekhar c299082eaa9faff50f617de0413fec53e1d0ae11 m
Merge remote-tracking branch 'origin/master' into CAS-14283
-
Srikrishna Sekhar 789e09f567aa0f79b9baaa6bfd2e3b989ef9d8b4 m
CAS-14283: Include stopcode for cycleniter criterion
Cycleniter is a "minor cycle exit criterion", which have their own set of
stopcodes that overlap in number with the major cycle criteria. For users of
interactive clean, this means that both cycleniter and niter (global) criteria
have stopcode 1.
In order to prevent confusion, I've assigned stopcode 11 to cycleniter. Since
this is the only minor cycle stopping criterion we are evaluating at the
moment, I have not implemented stopcode 12+ for the other conditions. -
Darrell Schiebel <darrell@schiebel.us> d71ff9e3345efc3a14c161dfe3dcf1c8d8255619 m
trigger new build [CAS-14283]
-
Darrell Schiebel <darrell@schiebel.us> 65792c8e1257f2f3ebe22ab23007df774d8526e9 m
Merge branch 'master' into CAS-14283
-
Srikrishna Sekhar 400e3a0a52f9793e4b436fb270ea8aeef5397f66 m
CAS-14283: Fix bug with casalog import
casalogs in _gclean.py was being imported from casatools rather than
casatasks, and causing the automated test to fail -
Srikrishna Sekhar 2363e28536138ab835a257e37cde752dfbcbe9f8 m
CAS-14283 : Allow calcres,calcpsf=False in first call
If calcres=False and calcpsf=False in the first call, the first major
cycle need not be run and we can go straight into deconvolution. Added
the conditional statements to support this use case in _gclean.py -
Srikrishna Sekhar de89f2e295528e93525ff8615f0078a99ea211ac m
CAS-14283 : Add automask params to gclean.__update
gclean._update accepts automasking parameters. This follows a change in
casagui to add automasking parameters to the front end. -
Darrell Schiebel <darrell@schiebel.us> 25f6982f12936a85b0d6094d5de18de9378b876d m
the mask parameter of imstat is an LEL expression
-
Darrell Schiebel <darrell@schiebel.us> 13655eefe8f7dbc0e2635ffde2ce104e4702f070 m
fix typos [CAS-14283]
-
Srikrishna Sekhar ed64fec8e6d96f6af1c3fd64636d8e293a90685a m
CAS-14283 : Add missing tclean/deconvolve params
Add the missing parameters into tclean + deconvolve. There are some
exceptions, detailed below.
As of this commit, the status is as follows.
"allowed" but non-functional (i.e., will not throw an error if passed
into run_iclean)
- calcpsf
- calcres
- restoration
not allowed (i.e., will throw an error)
- outlierfile
These will be fixed in future commits. -
Darrell Schiebel <darrell@schiebel.us> 2f1bdf9f2d34553c14e16da727e75e83bbd478f5 m
fix needed for OLD build system due to setuptools update [CAS-14283]
-
Srikrishna Sekhar 356192c5978a351192d6da7abadddff784b54c42 m
CAS-14283 : Add nsigma and threshold to gclean.update
The interactive clean GUI now exposes the threshold and nsigma
parameters as user-configurable. gclean.update has been updated to
reflect this change, including some basic sanity checks on the
user-input values. -
Srikrishna Sekhar a107df5b65a95105b436d34b022de9c2fe4c16fc m
CAS-14283 : Add __del__ to _gclean.py
Added __del__ method to _gclean.py, which does the restoration step (if
not already run) when the generator terminates.
This allows for more graceful termination of gclean, and leaves a
"finished" image on disk, rather than only the residual and model
images.