Build: #335 failed
Job: Test Tasks Many Linux 2.28 Python3.12 did not start
Code commits
casa6
-
Hendrik Muller b1364209b14c59988f2bbeb0a20cdaca9d7f26a7
Pull request #1071: CAS-14778
Merge in CASA/casa6 from CAS-14778 to master
* commit '0d731f5701553c3bcd07344a0be600f6ec4afee4':
CAS-14778 : Fix rectangular image case
rename to cameltype and assert that dimensions are either both even or both odd
Add test
Copy the solution for odd pixels that was found for Matrix Cleaner over to also apply to MultiTermMatrixCleaner.cc Validated on Cygnus A, scales=[0,1], nterms=1, cellsize = 1.6 arcsec (such that the bright termination lobes correspond to just a few pixels transversely, in this way we can test the effect of the code change without simply looking at the effects of extended emission)
Solved the problem for an odd number of pixels for Asp-CLEAN and MS-CLEAN. That is simply done by moving the slice for the beam subtraction up by one pixel. The problem does not exist for Hogbom. TBD: Verify that these fixes also fix the spectral versions and multiterm versions of the deconvolvers. -
Hendrik Muller 0d731f5701553c3bcd07344a0be600f6ec4afee4 m
Merge master into CAS-14778 and solve conflicts
-
Srikrishna Sekhar d03371710fc33be7f53d288c28b57661ecab1afd m
CAS-14778 : Fix rectangular image case
Specifically, allow one axis to be odd and the other even. Previously
this was trapped as an exception, but this is explicitly a use-case that
tclean supports.- casatools/src/code/synthesis/MeasurementEquations/AspMatrixCleaner.cc (version d03371710fc33be7f53d288c28b57661ecab1afd) (diffs)
- casatools/src/code/synthesis/MeasurementEquations/AspMatrixCleaner.h (version d03371710fc33be7f53d288c28b57661ecab1afd) (diffs)
- casatools/src/code/synthesis/MeasurementEquations/MatrixCleaner.cc (version d03371710fc33be7f53d288c28b57661ecab1afd) (diffs)
- casatools/src/code/synthesis/MeasurementEquations/MatrixCleaner.h (version d03371710fc33be7f53d288c28b57661ecab1afd) (diffs)
- casatools/src/code/synthesis/MeasurementEquations/MultiTermMatrixCleaner.cc (version d03371710fc33be7f53d288c28b57661ecab1afd) (diffs)
- casatools/src/code/synthesis/MeasurementEquations/MultiTermMatrixCleaner.h (version d03371710fc33be7f53d288c28b57661ecab1afd) (diffs)
-
Hendrik Muller <hmuller@smurf.aoc.nrao.edu> a23393d10e4d61b542ce4f503b84139fcf2b79c1 m
rename to cameltype and assert that dimensions are either both even or both odd
- casatools/src/code/synthesis/MeasurementEquations/AspMatrixCleaner.cc (version a23393d10e4d61b542ce4f503b84139fcf2b79c1) (diffs)
- casatools/src/code/synthesis/MeasurementEquations/AspMatrixCleaner.h (version a23393d10e4d61b542ce4f503b84139fcf2b79c1) (diffs)
- casatools/src/code/synthesis/MeasurementEquations/MatrixCleaner.cc (version a23393d10e4d61b542ce4f503b84139fcf2b79c1) (diffs)
- casatools/src/code/synthesis/MeasurementEquations/MatrixCleaner.h (version a23393d10e4d61b542ce4f503b84139fcf2b79c1) (diffs)
- casatools/src/code/synthesis/MeasurementEquations/MultiTermMatrixCleaner.cc (version a23393d10e4d61b542ce4f503b84139fcf2b79c1) (diffs)
- casatools/src/code/synthesis/MeasurementEquations/MultiTermMatrixCleaner.h (version a23393d10e4d61b542ce4f503b84139fcf2b79c1) (diffs)
-
Hendrik Muller <hmuller@smurf.aoc.nrao.edu> 1e86847f0d14c829305b9799311670e7888e2d85 m
Merge branch 'master' into CAS-14778
-
Hendrik Muller <hmuller@smurf.aoc.nrao.edu> 5bf775ed1b2dbd34144612bdef51ffb0a450e3fa m
Add test
-
Hendrik Muller <hmuller@smurf.aoc.nrao.edu> 70e53e2ea400c1595e0086e5677cbc1ea9c2b8d6 m
Copy the solution for odd pixels that was found for Matrix Cleaner over to also apply to MultiTermMatrixCleaner.cc Validated on Cygnus A, scales=[0,1], nterms=1, cellsize = 1.6 arcsec (such that the bright termination lobes correspond to just a few pixels transversely, in this way we can test the effect of the code change without simply looking at the effects of extended emission)
-
Hendrik Muller <hmuller@smurf.aoc.nrao.edu> 9cd9a1feb47b028733de48ebc515e17005e9a805 m
Solved the problem for an odd number of pixels for Asp-CLEAN and MS-CLEAN. That is simply done by moving the slice for the beam subtraction up by one pixel. The problem does not exist for Hogbom. TBD: Verify that these fixes also fix the spectral versions and multiterm versions of the deconvolvers.
- casatools/src/code/synthesis/MeasurementEquations/AspMatrixCleaner.cc (version 9cd9a1feb47b028733de48ebc515e17005e9a805) (diffs)
- casatools/src/code/synthesis/MeasurementEquations/AspMatrixCleaner.h (version 9cd9a1feb47b028733de48ebc515e17005e9a805) (diffs)
- casatools/src/code/synthesis/MeasurementEquations/MatrixCleaner.cc (version 9cd9a1feb47b028733de48ebc515e17005e9a805) (diffs)
- casatools/src/code/synthesis/MeasurementEquations/MatrixCleaner.h (version 9cd9a1feb47b028733de48ebc515e17005e9a805) (diffs)