Build: #418 failed Scheduled with changes by George Moellenbrock and Takeshi Nakazato
Code commits
Casa6
-
George Moellenbrock e91e35843d4f9dc0f7b51c238a90414011ec848b
Pull request #1032: CAS-14348
Merge in CASA/casa6 from CAS-14348 to master
* commit 'ca6131575d1f2743a010aa75f582a58f9eab1fcf':
Re-asserting that fringefit doesn't allow orphan timesteps
For CAS-14348:
Fixing the orphan timestep fringefit bug again
Turn off debugging output now I've tested the package built with it
Fixing fringefit on a single channel (again) and adding a test for it -
Takeshi Nakazato c1bc90f7e94deaaf076d3349703f179d7448e72f
Pull request #1027: CAS-14736
Merge in CASA/casa6 from CAS-14736 to master
* commit '2110d633fbae6d51c4507b949d448395a34c4ded':
changed format of the comment
Minor update on the comment for consistency
Properly evaluate time and exposure
Update test_cal_12712_01
CAS-14736 include fully flagged rows into the processing to produce flagged caltable row -
Takeshi Nakazato 2110d633fbae6d51c4507b949d448395a34c4ded m
changed format of the comment
-
George Moellenbrock ca6131575d1f2743a010aa75f582a58f9eab1fcf m
Merge remote-tracking branch 'origin/CAS-14726' into CAS-14348 conflicts in FringeJones.cc, DelayRateFFT.cc fixed manually.
-
Takeshi Nakazato 9b02d47ec419a7fb0cc7ddd127571e83bbd78afc m
Minor update on the comment for consistency
Fixed inconsistent comment associated with the updated test. -
Des Small 93f24986e972db3e9803b9f76d350598311da10a m
Re-asserting that fringefit doesn't allow orphan timesteps
In a future release we should allow single time fringefit if not solving for delay, just as we allow single channel fringefit
when not solving for rate, but now is not the time. -
George Moellenbrock 921dfad4a8a14b6d9d98ac21e12f88989cc17db3 m
Merge branch 'master' into CAS-14348
-
George Moellenbrock 1b982bd657af81609f15651cdf0038301cd6a6f6 m
For CAS-14348:
1. In DelayRateFFT.cc's DelayRateFFTConcat class:
(a) Reordered working array (Vpad_) axes to put time and freq before corr and ant (Fortran order) so they are contiguous for 2d FFT;
(b) Introduced direct use of fftw (instead of LatticeFFT) thereby drastically improving performance of the FFT stage; by (mainly) avoiding unnecessary copies;
(c) Improved array slicing to streamline (unavoidable) data copies into the working array;
(d) Introduced Double precision weight sum accumulation (copied to Single precision at the end), and streamlined weight accumulation code to make it clearer;
(e) In snr calulation use amplitude found in searchPeak instead of relocating it via calculation from delay/rate solutions;
(f) Various other code clean-up and minor re-org.
2. In FringeJones.cc: Logging improvements for readability, and introduced fringefit stage solving time measurements and logging.
3. In Calibrater.cc: Occasionally (every ~10%) report solution count progress, and don't log useless solution quality stats for FringeJones (they are not yet filled correctly)- casatools/src/code/synthesis/MeasurementComponents/Calibrater.cc (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/DelayRateFFT.cc (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.cc (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.h (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
-
Takeshi Nakazato 74bbc92e85d60fdae3a02e2cd3f6f79752375426 m
Properly evaluate time and exposure
-
Takeshi Nakazato ee4cba4ece22f6b79596b1b795d497d28e47a37f m
Merge branch 'master' into CAS-14736
-
Des Small 749ab91d5875e60ee94fc139bb2b0e9acea50e04 m
Merge branch 'master' into CAS-14726
-
Des Small 040d518f901c10138314a2d4d1d9ce5c0417776e m
Fixing the orphan timestep fringefit bug again
-
Takeshi Nakazato 872ed8889036b200d7b9ee2507d70546a6352a20 m
Merge branch 'master' into CAS-14736
-
Takeshi Nakazato d12c9a692449db0da3644bad5e99dd4c296471d0 m
Update test_cal_12712_01
Expected number of rows changed from 61 to 64. This is due to the addition of fully flagged rows (3 rows). The test was updated to compare the number of total caltable rows as well as the number of fully flagged rows. -
Takeshi Nakazato 35399f1f96bbea04bef346fac272897db36ccdf4 m
CAS-14736 include fully flagged rows into the processing to produce flagged caltable row
-
Des Small fd0b2ba74d70b397ded8f269cbf5141549d6cbcd m
Turn off debugging output now I've tested the package built with it
-
Des Small 39f8d314f0617de8ad30a3b1f060993fcba169b2 m
Fixing fringefit on a single channel (again) and adding a test for it
- casatasks/tests/tasks/test_task_fringefit.py (version 39f8d314f0617de8ad30a3b1f060993fcba169b2) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/DelayRateFFT.cc (version 39f8d314f0617de8ad30a3b1f060993fcba169b2) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/DelayRateFFT.h (version 39f8d314f0617de8ad30a3b1f060993fcba169b2) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.cc (version 39f8d314f0617de8ad30a3b1f060993fcba169b2) (diffs)