Build: #5 was successful Manual run by CASA adm account
Code commits
Casa6
-
Srikrishna Sekhar 628e5a4a90422ce1df3d70fad4621abfa9024fa8
CAS-12220 : Add tests for psfmode=flat
Added a test class for the new PSF mode parameter since it is a
substantial change. The tests should cover most failure modes. -
Srikrishna Sekhar 9bf98eb4d70ac32fa3b6cf88916bd39605a78260
CAS-12220 : Add AWP2 support for flatPSF
AWP2 was previously gated-off because the flat PS CF kernel was being
over-written in-place by the A-term kernel, causing the flatPSF mode to
generate bit-identical PSF to the regular PSF mode.
This separates out the flat-PSF kernel from mosaic into it's own method,
and that has been hooked into AWP2.
There are still no unit tests to test this new mode, but local tests
seem to confirm that it's working (or at least not crashing...)- casatasks/xml/tclean.xml (version 9bf98eb4d70ac32fa3b6cf88916bd39605a78260) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version 9bf98eb4d70ac32fa3b6cf88916bd39605a78260) (diffs)
- casatools/src/code/synthesis/TransformMachines2/AWPLPG.cc (version 9bf98eb4d70ac32fa3b6cf88916bd39605a78260) (diffs)
- casatools/src/code/synthesis/TransformMachines2/MosaicFT.cc (version 9bf98eb4d70ac32fa3b6cf88916bd39605a78260) (diffs)
- casatools/src/code/synthesis/TransformMachines2/MosaicFT.h (version 9bf98eb4d70ac32fa3b6cf88916bd39605a78260) (diffs)
-
Srikrishna Sekhar 7d74987cc52b428f320d653a061a16ccf83cff8a
CAS-12220 : new psfmode argument in tclean.xml + cleanup
Add a new "psfmode" argument within tclean that triggers the gridders to
use the flatPSF path, and complete the pipes all the way down into
SynthesisImager.
The old tclean.py hack has been removed in favour of the C++
code-changes.- casatasks/src/private/imagerhelpers/input_parameters.py (version 7d74987cc52b428f320d653a061a16ccf83cff8a) (diffs)
- casatasks/src/private/task_tclean.py (version 7d74987cc52b428f320d653a061a16ccf83cff8a) (diffs)
- casatasks/xml/tclean.xml (version 7d74987cc52b428f320d653a061a16ccf83cff8a) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version 7d74987cc52b428f320d653a061a16ccf83cff8a) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SynthesisUtilMethods.cc (version 7d74987cc52b428f320d653a061a16ccf83cff8a) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SynthesisUtilMethods.h (version 7d74987cc52b428f320d653a061a16ccf83cff8a) (diffs)
-
Srikrishna Sekhar ea2293389feea42ae39e57a6b953cbd13edc5510
CAS-12220 : Fixes for AWP flatPSF path
AWP was crashing with the previous flatPSF implementation,
this cleans up some old code and fixes the flatPSF path.
AWP2 is still unsupported with these fixes, that will be looked at later
on. It raises an error if flatpsf is used in conjuction with AWP2.- casatools/src/code/synthesis/TransformMachines2/AWProjectFT.cc (version ea2293389feea42ae39e57a6b953cbd13edc5510) (diffs)
- casatools/src/code/synthesis/TransformMachines2/AWProjectFT.h (version ea2293389feea42ae39e57a6b953cbd13edc5510) (diffs)
- casatools/src/code/synthesis/TransformMachines2/CFBuffer.cc (version ea2293389feea42ae39e57a6b953cbd13edc5510) (diffs)
-
Srikrishna Sekhar 11c165cab4f9a51b8db7da60993399856b92d198
CAS-12220 : Flat PSF for mosaic gridder
Add flat PSF gridding path for mosaic gridder. This keeps the visibility
and weight paths untouched. -
Srikrishna Sekhar 8ae9b3cd4092a11cccb77aa46c2553583a9c22d1
CAS-12220 : Revert fixes made on this branch
The gate was unnecessary because we don't have to use the flatPSF gate
for weight gridding. -
Srikrishna Sekhar 0e6a7da8abac86fa7a364e0cb367c0644eed17d2
CAS-12220 : Cleanup some debug output
- casatools/src/code/synthesis/ImagerObjects/SIImageStore.cc (version 0e6a7da8abac86fa7a364e0cb367c0644eed17d2) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStoreMultiTerm.cc (version 0e6a7da8abac86fa7a364e0cb367c0644eed17d2) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStoreMultiTerm.h (version 0e6a7da8abac86fa7a364e0cb367c0644eed17d2) (diffs)
- casatools/src/code/synthesis/TransformMachines2/MultiTermFTNew.cc (version 0e6a7da8abac86fa7a364e0cb367c0644eed17d2) (diffs)
-
Srikrishna Sekhar 94d676283f93402e8cb4891751bf6ff20ccfdf23
CAS-12220 : put back tclean skipped tests
The tests were erroneously unskipped in a previous commit -
Srikrishna Sekhar a477eb3cb6bebb2881bd92504a6805eae94b2396
CAS-12220 : Add flatPSF to AWProject gridders
Add plumbing to AWProjectFT and AWProjectWBFT to produce a PS-only CF to
grid only the PSF.
This is an attempt to clean up the python-layer hack that was used to
demonstrate the viability of this approach.
Add a new flatPSF_p toggle that sets PS-only gridding for the PSF for
AWP gridders (AWProject + AWP2). The control for this will flow from
tclean.xml but at the moment nothing sets it.
With this change, the PB is produced only when gridding the weights.- casatools/src/code/synthesis/TransformMachines2/AWProjectFT.cc (version a477eb3cb6bebb2881bd92504a6805eae94b2396) (diffs)
- casatools/src/code/synthesis/TransformMachines2/AWProjectFT.h (version a477eb3cb6bebb2881bd92504a6805eae94b2396) (diffs)
- casatools/src/code/synthesis/TransformMachines2/AWProjectWBFT.cc (version a477eb3cb6bebb2881bd92504a6805eae94b2396) (diffs)
-
Srikrishna Sekhar 669201125a64d15e4397febd9253b45a98f3383c
Merge remote-tracking branch 'origin/master' into CAS-12220
-
Dirk Petry <dpetry@eso.org> 059b8ab234522648c1fb903cb3dd576ba9a4b65b m
Pull request #1052: CAS-14694
Merge in CASA/casa6 from CAS-14694 to master
* commit '6f1345ac52f7252da24ccdc916163333039734d1':
For CAS-14694: In SolvableVisCal::setSimulate, for simulation of DJones only, short-circuit VI major and minor iteration over the MS so that instrumental polarization is neither time- nor (for mosaic sims) field-dependent. This breaks 'testSky_intLeak' in test_task_simobserve.py. NB: this is not yet a complete polarimetry simulation because parang is not yet treated.
CAS-14694: update simobserve task built-in help for leakage parameter
CAS-14694: make simobserve produce full-pol simulation when input model image is full-pol, independent of leakage
CAS-14694: activated test case testNZ_intMan_Leak and made sure leakage is only applied for obsmode='int'
Enable teardown for test_task_simobserve
CAS-14694: Made ANoise::nPar() in AMueller.h return 4 instead of 2.
CAS-14694: changes which seem to solve the remaining problems
CAS-14694: reverted use of sm.setfeed in simobserve task
CAS-14694 modified the task script to make appropriate sm tool calls when leakage>0 -
George Moellenbrock 6f1345ac52f7252da24ccdc916163333039734d1 m
For CAS-14694: In SolvableVisCal::setSimulate, for simulation of DJones only, short-circuit VI major and minor iteration over the MS so that instrumental polarization is neither time- nor (for mosaic sims) field-dependent. This breaks 'testSky_intLeak' in test_task_simobserve.py. NB: this is not yet a complete polarimetry simulation because parang is not yet treated.
-
Rui Xue 8f5e9581750c4df973277e17e3e5d999f318e7f7 m
Pull request #1030: CAS-14758: Optimize image processing by caching tool handles in fill_summary_minor to avoid redundant open/close operations
Merge in CASA/casa6 from CAS-14758 to master
* commit 'a46b0fa46be4985558dfe705e9f2eccf577b4aed':
CAS-14758: Handle missing residual images when constructing minor cycle summary
CAS-14758: Optimize image processing by caching tool handles in fill_summary_minor to avoid redundant open/close operations -
Rui Xue 44d9e7387ac3f53b7841b93a583e1354e361c06f m
Pull request #1040: CAS-14622
Merge in CASA/casa6 from CAS-14622 to master
* commit '6599d358e517e2dc3f94260a0d8770dd0cc64964':
CAS-14622: Fix out-of-bounds MPI segmentation faults in BriggsCubeWeightor
CAS-14622: Fix ncores-dependent tclean segmentation fault in `BriggsCubeWeightor` -
Dirk Petry <dpetry@eso.org> e9db1cf9435f211d68a67190f8e650670a5de0eb m
CAS-14694: update simobserve task built-in help for leakage parameter
-
Dirk Petry <dpetry@eso.org> 567c15cd27e8383205d3d8cee02a0be9b68ef5c4 m
Merge branch 'master' into CAS-14694
-
Akeem Wells 6599d358e517e2dc3f94260a0d8770dd0cc64964 m
Merge branch 'master' into CAS-14622
-
Bob Garwood 3f49f7503b516f27ec0cf65423a7a9e51c238085 m
Pull request #1049: CAS-14792
Merge in CASA/casa6 from CAS-14792 to master
* commit 'c4206a386e84fa23a749f5b95753860d36396bd7':
added more text to describe the measures data install step
readme.md uses www.astron.nl now for measures data -
Akeem Wells c4206a386e84fa23a749f5b95753860d36396bd7 m
Merge branch 'master' into CAS-14792
-
Kumar Golap 4d6918c6411688aeb8ab0b8b75ff610cb4885d89 m
Pull request #1048: when resetting image center the coordinate system was not being reset
Merge in CASA/casa6 from CAS-14747 to master
* commit '3c5bde23464661fe96ff365766465083f95adafd':
when resetting image center the coordinate system was not being reset -
Bob Garwood 3493dc9839d8a596467d534b28d465c141bc35b2 m
added more text to describe the measures data install step
-
Bob Garwood 632ee87ba92665433856b99c66e70e590c1fff99 m
readme.md uses www.astron.nl now for measures data
-
Kumar Golap 0673f3ad43b910fe023c96aea061c23f81f0fb38 m
Pull request #1047: It was not the precision of converting fromRecord or to Record but numpy print precision.
Merge in CASA/casa6 from CAS-13338 to master
* commit 'dfb7e5241859986be77d9b1c19a09c8e2e5c3747':
It was not the precision of converting fromRecord or to Record but numpy print precision. That I believe fixes the precision of phasecenter for parallel continuum -
Srikrishna Sekhar 50e2cf84c451f0970e69a3aaf15ddd26166eb3de m
Pull request #1046: CAS-13818
Merge in CASA/casa6 from CAS-13818 to master
* commit 'b0973d16124b120e2baf377a91488649c0034986':
CAS-13818 : Skip failing deconvolve tests
CAS-13818 : Fix mask cache conflict on tclean restart
CAS-13818: Add test to check for full stokes mask
Added a skip to test_mtmfsimgval_startmodel_axesmismatch in test_task_deconvolve for MacOS due to Fatal Python error. The failure and solution are being investigated on CAS-14117
CAS-13818 : Disable test_imgval_startmodel_axesmismatch on MacOS
CAS-13818 : Fix for failing test
CAS-13818 : Fix for image.tt0 pb mask -
Ville Suoranta 1d8db3ef8539fcf1f25aac6429130548c3a6304c m
Pull request #1045: CAS-14769
Merge in CASA/casa6 from CAS-14769 to master
* commit '85227bc5735154327b1a1394763b90f6bd60ac0a':
Update casacore reference
Revert "Point casacore to dev branch"
Remove redefition of PtrBlock in TransformMachines
Point casacore to dev branch -
Akeem Wells 96543550841e6adfc298ea4bf932d3a6befa0157 m
Pull request #1044: CAS-14768
Merge in CASA/casa6 from CAS-14768 to master
* commit '1011c5933ca639144a5ae3c253086f038da63442':
Update xmlrunner_to_junit to work with unittest-xml-reporting module -
Srikrishna Sekhar b0973d16124b120e2baf377a91488649c0034986 m
Merge remote-tracking branch 'origin/master' into CAS-13818
-
Srikrishna Sekhar a46b0fa46be4985558dfe705e9f2eccf577b4aed m
Merge remote-tracking branch 'origin/master' into CAS-14758
-
Kumar Golap dfb7e5241859986be77d9b1c19a09c8e2e5c3747 m
It was not the precision of converting fromRecord or to Record but numpy print precision. That I believe fixes the precision of phasecenter for parallel continuum
-
Ville Suoranta 85227bc5735154327b1a1394763b90f6bd60ac0a m
Update casacore reference
-
Ville Suoranta 5401a2510043db196722fda194d292eae1fbe0e4 m
Revert "Point casacore to dev branch"
This reverts commit cf53b61404c57a80cfcef14f4df9392985b57443. -
Akeem Wells 1011c5933ca639144a5ae3c253086f038da63442 m
Merge branch 'master' into CAS-14768
-
Takahiro Tsutsumi c84be1413a0d775fc6fe17d180f968a1475a1fa6 m
Pull request #1043: CAS-14606
Merge in CASA/casa6 from CAS-14606 to master
* commit 'e2af0ec57f50d3edffed7dd5384465472326b4a5':
Add a check that an entire (sub-)table is empty (nrows=0)
Fix a bug in is_column_empty function and add tb.getvarcol-based data existence check for the subtables
Add test for data types, str, int, float
Access the first row only
Use tb.getvarcol to check if optional data columns in Main table have any data instead of tb.getcell -
Dirk Petry <dpetry@eso.org> 84f01fe0d32bbe506c9c0a9eb98a6b79da1636e8 m
CAS-14694: make simobserve produce full-pol simulation when input model image is full-pol, independent of leakage
-
Kumar Golap 3c5bde23464661fe96ff365766465083f95adafd m
when resetting image center the coordinate system was not being reset
-
Ville Suoranta 76a61842ff2f6c1e457900680d14157c96c2e59e m
Remove redefition of PtrBlock in TransformMachines
-
Ville Suoranta cf53b61404c57a80cfcef14f4df9392985b57443 m
Point casacore to dev branch
-
Akeem Wells fe4695a054c35ccb9b648d91e0871c322bc267ad m
Merge branch 'master' into CAS-14622
-
Srikrishna Sekhar d8a3a4bdf7e60a99f628b34e559845c98dff371e m
Pull request #1039: CAS-13318
Merge in CASA/casa6 from CAS-13318 to master
* commit 'b6453d73d1a4098c3763b42a75b88880b3bce7ad':
CAS-13318 : Fix PB masking in robust RMS calc -
Inna Muzychenko 229d3c9b5d0436b0f48fe265b8b4bde48a585614 m
Pull request #1033: CAS-14704
Merge in CASA/casa6 from CAS-14704 to master
* commit 'd5adeb6db73246ebbb2e3e535e56a38139482f98': (34 commits)
add test_task_getjyperkalma to component map
Changes according to the NAOJ code review Refs #2870
Changes according to the NAOJ code review Refs #2869 #2870
Changes according to the NAOJ code review Refs #2868
Changes according to the NAOJ code review Refs #2866
Changes according to the NAOJ code review Refs #2865
Changes according to the NAOJ code review Refs #2864
Changes according to the NAOJ code review
Delete commented out lines
Fix bugs, add tests
Changes according to code review Refs #2858
Changes according to code review Refs #2858
Changes according to code review Refs #2846
Changes according to the code review #Refs 2851
Changes according to code review Refs #2843
Changes according to code review Refs #2860
Changes according to code review Refs #2859
Changes according to code review Refs #2857
Changes according to the code review #Refs 2854
Changes according to code review Refs #2853
... -
Akeem Wells 624b1aca4d9570ee193ab3b18ddac0db9fc2bf37 m
Update xmlrunner_to_junit to work with unittest-xml-reporting module
-
Srikrishna Sekhar b6453d73d1a4098c3763b42a75b88880b3bce7ad m
Merge remote-tracking branch 'origin/master' into CAS-13318
-
Kumar Golap e0538c1bf3ca24820f433032edf570fa2966216f m
Pull request #1037: Fix simanalyze as it was calling tclean with modelimage with non-compatible units
Merge in CASA/casa6 from CAS-14765 to master
* commit 'f11ba01acc47815dea58711a70aa50bd9a42cc2a':
Fix simanalyze as it was calling tclean with modelimage with non-compatible units -
Rui Xue ce691fac04de68e393cb9495357f72e9271ff892 m
CAS-14758: Handle missing residual images when constructing minor cycle summary
-
Takahiro Tsutsumi e2af0ec57f50d3edffed7dd5384465472326b4a5 m
Add a check that an entire (sub-)table is empty (nrows=0)
-
George Moellenbrock e91e35843d4f9dc0f7b51c238a90414011ec848b m
Pull request #1032: CAS-14348
Merge in CASA/casa6 from CAS-14348 to master
* commit 'ca6131575d1f2743a010aa75f582a58f9eab1fcf':
Re-asserting that fringefit doesn't allow orphan timesteps
For CAS-14348:
Fixing the orphan timestep fringefit bug again
Turn off debugging output now I've tested the package built with it
Fixing fringefit on a single channel (again) and adding a test for it -
Takeshi Nakazato c1bc90f7e94deaaf076d3349703f179d7448e72f m
Pull request #1027: CAS-14736
Merge in CASA/casa6 from CAS-14736 to master
* commit '2110d633fbae6d51c4507b949d448395a34c4ded':
changed format of the comment
Minor update on the comment for consistency
Properly evaluate time and exposure
Update test_cal_12712_01
CAS-14736 include fully flagged rows into the processing to produce flagged caltable row -
Kumar Golap f11ba01acc47815dea58711a70aa50bd9a42cc2a m
Fix simanalyze as it was calling tclean with modelimage with non-compatible units
-
Ville Suoranta 5fe795fab606b1f927251fe9c08f53c3e239653b m
Pull request #1034: CAS-14739
Merge in CASA/casa6 from CAS-14739 to master
* commit '1a7ce12a22645bd3b0ddee373ac9e7e32af1a85c':
Update UI versions for macOS26
Update plotms branch wheel version
Update plotms branch version in build.conf
Add note about updating .zshrc
Add instructions on how to close the source code.
Update build.conf to CAS-14739 dev packages
Add a note about Metal
Fix links for Bitbucket
Swith plus to hyphen
Update TOC
Rename casa_build_guide.md
Update CASA_Build_Guide.md
Remove manylinux 2014
Add reformatted build guide -
Ville Suoranta 1a7ce12a22645bd3b0ddee373ac9e7e32af1a85c m
Update build.conf
-
Takahiro Tsutsumi 61b4f7fa0783c3d03b597000f81f66ef9b23d37c m
Pull request #1031: CAS-14684
Merge in CASA/casa6 from CAS-14684 to master
* commit '318460f1760e1558914d90b8ed8ab6a854eda9d0':
Add a new test and modify another test to check radii entries Revert the task level catch of the exception as this hides some of the exeptions
Add a try-except block to exit task more gracefully when an exception occurs at gethorizonsephem callm
add more warning messages and another fix to target body name extraction
Fix regular expression for the source name extraction -
Mark Kettenis <kettenis@jive.eu> d20b3fe22aff2bfbd6566abc7a22778f47327c4e m
Pull request #1029: CAS-14683: Test concat of SYSCAL with different SPWs
Merge in CASA/casa6 from CAS-14683 to master
* commit '95234c2fe651cfb94ba854edc3ab80f4dff59779':
CAS-14683: Test concat of SYSCAL with different SPWs -
Kumar Golap e81b4b58c707034fcb781e05846630424b654217 m
Pull request #1028: CAS-14732
Merge in CASA/casa6 from CAS-14732 to master
* commit '4367509f637e844d0ace77ea151e165bd67efc38':
moved the check but had to fix stuff as empty string was acceptable at that stage.
move the check for units in starting model to SyntheisisImager
force saving of model image
Throw an exception if model is not in units of Jy/pixel
Fixed an image copy with mask being applied which did not copy the units -
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> d5adeb6db73246ebbb2e3e535e56a38139482f98 m
Merge remote-tracking branch 'origin/master' into CAS-14704
-
Ville Suoranta 2c1ca27b4a049a613b501fad7e7e87b2df1700cc m
Update UI versions for macOS26
-
Akeem Wells f4b105efadda226bece3a00d78a85b02862e630e m
Pull request #1026: CAS-13817
Merge in CASA/casa6 from CAS-13817 to master
* commit 'c5a2faf379c84c73eff3f0dd2f18ab97d7548234':
Revert compare file due to black causing indent errors
Documentation Updates
Update documentation for sparse_check
Additional documentation and reformating updates
Reformat with black. Add docstrings using GPT-4.1 -
Akeem Wells 7f25a9ec0b4e8ec437acc395717ce5427a7d4d71 m
add test_task_getjyperkalma to component map
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> b7fa54dc5d6267a2d1d64b831a9c9fc77ca658ed m
Changes according to the NAOJ code review Refs #2870
-
Takeshi Nakazato 2110d633fbae6d51c4507b949d448395a34c4ded m
changed format of the comment
-
George Moellenbrock ca6131575d1f2743a010aa75f582a58f9eab1fcf m
Merge remote-tracking branch 'origin/CAS-14726' into CAS-14348 conflicts in FringeJones.cc, DelayRateFFT.cc fixed manually.
-
C. Enrique Garcia Dabo 9a0d270e9a82ecae78da190f51f298c2025eaf95 m
Pull request #1025: CAS-14624
Merge in CASA/casa6 from CAS-14624 to master
* commit '5e3358b08a77770afbe60a9ae74b14ac0194851d':
Add test_task_ft to component map
CAS-14624: Add also uvrange and antenna as selection criteria
CAS-14624: Fix documentation
CAS-14624: Add more data selection options in "ft" -
Takeshi Nakazato 9b02d47ec419a7fb0cc7ddd127571e83bbd78afc m
Minor update on the comment for consistency
Fixed inconsistent comment associated with the updated test. -
Rui Xue f03ba5194e6eaca95fb699a2fa3cccd2c7658cbf m
CAS-14758: Optimize image processing by caching tool handles in fill_summary_minor to avoid redundant open/close operations
-
Takahiro Tsutsumi b16c5ce495369cf93b416cd12e7c6954ddf83611 m
Fix a bug in is_column_empty function and add tb.getvarcol-based data existence check for the subtables
-
Rui Xue 8fbe09615738a7a02c5c218a2ba4598911874183 m
CAS-14622: Fix out-of-bounds MPI segmentation faults in BriggsCubeWeightor
The SynthesisImager uses BriggsCubeWeightor to compute weights for the image cube. During distributed MPI execution (`ncores > 1`), the output cube's spectral axis is partitioned across multiple nodes into smaller local subcubes.
When evaluating MS data channels, `GridFT::channelMap` maps the visibilities' frequencies into the local subcube's channel indices. If an MS contains dataset frequencies (e.g., from large Doppler swings or wide ephemeris velocity changes) that land *above* the local MPI subcube's maximum channel, `channelMap` returns an index exceeding the local array bounds.
Previously, BriggsCubeWeightor only checked the lower bound (`chanMap(chn) > -1`) before using the calculated index to access `wgtDensity` and the `f2_p`/`d2_p` arrays. Accessing these arrays with indices belonging to higher MPI partitions resulted in unconstrained out-of-bounds memory accesses, causing silent heap corruption or explicit Segmentation Faults, heavily dependent on the MPI slicing and dataset footprint.
This commit resolves the issue by introducing strict upper-bound channel footprint constraints (`chanMap(chn) < shape()[3]`) in both `weightUniform` and `getWeightUniform`. Data channels that mathematically fall outside the upper bounds of the local MPI partition are now securely ignored. -
Des Small 93f24986e972db3e9803b9f76d350598311da10a m
Re-asserting that fringefit doesn't allow orphan timesteps
In a future release we should allow single time fringefit if not solving for delay, just as we allow single channel fringefit
when not solving for rate, but now is not the time. -
Rui Xue 3000ee0fe103736833f139a6c7dbdf3eca4abb82 m
CAS-14622: Fix ncores-dependent tclean segmentation fault in `BriggsCubeWeightor`
The SynthesisImager uses `BriggsCubeWeightor` to compute weights for the image cube. During this calculation, `BriggsCubeWeightor::cube2Matrix` extracts raw storage pointers `pcube` and `pflags` from `casacore::Array::getStorage(deleteIt)`.
Previously, the code incremented these exact pointers (`*pflags = *pcube++`) during array traversal. At the end of the function, the incremented pointers were passed directly to `freeStorage()` and `putStorage()`.
When array memory isn't contiguous (which occurs when data is sliced across MPI ranks), `getStorage()` allocates a temporary buffer and sets `deleteIt = true`. Passing the shifted pointer into `freeStorage()` invokes `delete[]` on an invalid memory address, causing heap corruption and a Segmentation fault randomly depending on the data slicing.
This commit resolves the issue by securely caching the original pointers returned from `getStorage` into distinct variables. The traversal loops now use separate copies of these pointers, enabling the original allocation addresses to be correctly evaluated and freed by `freeStorage()` and `putStorage()`. -
George Moellenbrock 921dfad4a8a14b6d9d98ac21e12f88989cc17db3 m
Merge branch 'master' into CAS-14348
-
George Moellenbrock 1b982bd657af81609f15651cdf0038301cd6a6f6 m
For CAS-14348:
1. In DelayRateFFT.cc's DelayRateFFTConcat class:
(a) Reordered working array (Vpad_) axes to put time and freq before corr and ant (Fortran order) so they are contiguous for 2d FFT;
(b) Introduced direct use of fftw (instead of LatticeFFT) thereby drastically improving performance of the FFT stage; by (mainly) avoiding unnecessary copies;
(c) Improved array slicing to streamline (unavoidable) data copies into the working array;
(d) Introduced Double precision weight sum accumulation (copied to Single precision at the end), and streamlined weight accumulation code to make it clearer;
(e) In snr calulation use amplitude found in searchPeak instead of relocating it via calculation from delay/rate solutions;
(f) Various other code clean-up and minor re-org.
2. In FringeJones.cc: Logging improvements for readability, and introduced fringefit stage solving time measurements and logging.
3. In Calibrater.cc: Occasionally (every ~10%) report solution count progress, and don't log useless solution quality stats for FringeJones (they are not yet filled correctly)- casatools/src/code/synthesis/MeasurementComponents/Calibrater.cc (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/DelayRateFFT.cc (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.cc (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.h (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
-
Pam Harris <pharris@nrao.edu> 1f1bd1c368ffa5b5d2dd7417e6a94a08a1d5cead m
Update plotms branch wheel version
-
Pam Harris <pharris@nrao.edu> cc509e692ad0e27573dee716d871234d2b8faf73 m
Update plotms branch version in build.conf
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> d45e0d268df57019b05cba8dbee5d17a722bd4e9 m
Changes according to the NAOJ code review Refs #2869 #2870
-
Takeshi Nakazato 74bbc92e85d60fdae3a02e2cd3f6f79752375426 m
Properly evaluate time and exposure
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> 4d0a1a93f28b58cd0483a05800de5b03efedddcc m
Changes according to the NAOJ code review Refs #2868
-
Takeshi Nakazato ee4cba4ece22f6b79596b1b795d497d28e47a37f m
Merge branch 'master' into CAS-14736
-
Akeem Wells c5a2faf379c84c73eff3f0dd2f18ab97d7548234 m
Revert compare file due to black causing indent errors
-
Akeem Wells 4ddde8c6514cbad3ef512b2e1ff09ffca246ed50 m
Documentation Updates
- casatestutils/casatestutils/datahelpers/__init__.py (version 4ddde8c6514cbad3ef512b2e1ff09ffca246ed50) (diffs)
- casatestutils/casatestutils/datahelpers/getTelescope.py (version 4ddde8c6514cbad3ef512b2e1ff09ffca246ed50) (diffs)
- casatestutils/casatestutils/datahelpers/selectTaql.py (version 4ddde8c6514cbad3ef512b2e1ff09ffca246ed50) (diffs)
- casatestutils/casatestutils/getantposalma_helpers/__init__.py (version 4ddde8c6514cbad3ef512b2e1ff09ffca246ed50) (diffs)
- casatestutils/casatestutils/getcalmodvla_helpers/__init__.py (version 4ddde8c6514cbad3ef512b2e1ff09ffca246ed50) (diffs)
- casatestutils/casatestutils/sparse_check.py (version 4ddde8c6514cbad3ef512b2e1ff09ffca246ed50) (diffs)
- casatestutils/casatestutils/testhelper.py (version 4ddde8c6514cbad3ef512b2e1ff09ffca246ed50) (diffs)
- casatestutils/casatestutils/weblog.py (version 4ddde8c6514cbad3ef512b2e1ff09ffca246ed50) (diffs)
- casatestutils/casatestutils/xmlhelper.py (version 4ddde8c6514cbad3ef512b2e1ff09ffca246ed50) (diffs)
- casatestutils/runtest.py (version 4ddde8c6514cbad3ef512b2e1ff09ffca246ed50) (diffs)
-
Akeem Wells 37f0fc0051700c5d63e2b5eb50f3898a9836c565 m
Merge branch 'master' into CAS-13817
-
Des Small 749ab91d5875e60ee94fc139bb2b0e9acea50e04 m
Merge branch 'master' into CAS-14726
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> 2f41b7e75d3633b4f4eae04e0370f422b0adce95 m
Changes according to the NAOJ code review Refs #2866
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> bce0d4c02bb723a7fba9b3831c47fa239180d536 m
Changes according to the NAOJ code review Refs #2865
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> ad69d02088e308ad35190176cd076e658a41a954 m
Changes according to the NAOJ code review Refs #2864
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> c841edca23ece8b9e22603ef699305ec1488b402 m
Changes according to the NAOJ code review
-
Takahiro Tsutsumi <tak.tsutsumi@gmail.com> 318460f1760e1558914d90b8ed8ab6a854eda9d0 m
Add a new test and modify another test to check radii entries Revert the task level catch of the exception as this hides some of the exeptions
-
Takahiro Tsutsumi <tak.tsutsumi@gmail.com> 2f1afa98c3bf9873dfba644a3da81e105bfa1eb6 m
Add a try-except block to exit task more gracefully when an exception occurs at gethorizonsephem callm
-
Ville Suoranta b4b8d068fc70556979b40724be2420d85bf7175a m
Add note about updating .zshrc
-
Ville Suoranta 63fa2771364373d098c671393dca1371e32fd0a0 m
Add instructions on how to close the source code.
-
Takahiro Tsutsumi <tak.tsutsumi@gmail.com> 1ffedf3f1d24bd1b2382a3c927912e1e263fca71 m
add more warning messages and another fix to target body name extraction
-
Des Small 040d518f901c10138314a2d4d1d9ce5c0417776e m
Fixing the orphan timestep fringefit bug again
-
Kumar Golap 2cb32bcb39e5744aa06c93ace2cc9cc089a1de6d m
Pull request #1024: CAS-14672
Merge in CASA/casa6 from CAS-14672 to master
* commit '7939dcd2725a8f21a815277e7ded37f038d9e00b':
mode mvc was not synchronising the number of major cycles in the PySynthesisImager object that does the mfs deconvolution -
Akeem Wells 6646c9ff1254ab7d1282e14df56990a642278a70 m
Pull request #1023: CAS-14542
Merge in CASA/casa6 from CAS-14542 to master
* commit '3525ae31ab2256d91b1b75132368ce6dc74b3d10':
Move Bamboo function to atlassian_helper. Minor fix to pytest command line checking. Syntax updates
Add skipped plotweather tests to main test suite
Comment out skipped tests in plotbandpass. Update component map
Extend Checking of Skips to classes. Add Documentation
Add new pytest command line option to override skip -
Takahiro Tsutsumi <tak.tsutsumi@gmail.com> df03a1647a24f6e24f27be990ded2e79d783593a m
Fix regular expression for the source name extraction
-
Victor de Souza Magalhaes 61020062cee290f5466cffed5ec5032e0c7a3434 m
Pull request #1022: CAS-14642
Merge in CASA/casa6 from CAS-14642 to master
* commit 'd33b16358c14e79b73a2ef239c1ac5b8c64ec017': (81 commits)
Removed long description and exampels from xml/pccor.xml
Added a time range without a explicit date, removed tests that used fallback_to_fringefit.
Removed parameter fallback_to_fringefit.
Fixed a typo in pccor.xml and also added an example using a timerange with no explicit date.
PCCOR timerange now supports a initial time without a date (the first date of the ms is used in this case).
Prepended the name of all private pccor functions with _pccor_.
Changed test_solutionValues tolerance to 1e-5.
Changed tolerance on test_solutionValues and also added more relevant metrics to evaluate failure.
Changed test_solutionValues test to use np.allclose rather than testing that np arrays are equal.
Update test_task_pccor to replace try statements with assertRaises. Split tests into multiple test cases. Add test_task_pccor to component map
Added test on split MSes.
Changed missing_pc_data string parameter to a boolean called fallback_to_fringefit.
Tagged scans and field_ids as NaNs for pulse cal times in which no visibilities exist in the MS, which lets me filter them out when saving data to the on disk pulse_cal table, the solutions are still available in the return_dict.
Added setup and teardown methods to test_task_pccor.py
Implemented test_solutionValues in test_task_pccor.py
Implemented test_provideFringeFitTable in test_task_pccor.py
Fixed raising of RuntimeError when given fringefit caltable and requested timerange are incompatible.
Added test_parseScanAndTimerange to test_task_pccor.py
Improved timerange parsing and changed a generic exception to a ValueError.
Implemented parseSpw test.
... -
Kumar Golap 4367509f637e844d0ace77ea151e165bd67efc38 m
moved the check but had to fix stuff as empty string was acceptable at that stage.
-
Akeem Wells 3525ae31ab2256d91b1b75132368ce6dc74b3d10 m
Merge branch 'master' into CAS-14542
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> 6ebf6a0f0daf3c2ad70fed7872ce350b21821d97 m
Delete commented out lines
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> b11f8f86c82a303c36f1f9aff8b065dfc41053f1 m
Fix bugs, add tests
-
Takahiro Tsutsumi 68a9bac2144ccae3259c56de1bdd6b2edc25a158 m
Add test for data types, str, int, float
-
Victor de Souza Magalhaes d33b16358c14e79b73a2ef239c1ac5b8c64ec017 m
Removed long description and exampels from xml/pccor.xml
-
Takahiro Tsutsumi 7aca7a422dccf268486ac1ab5a5268b26b8ccaf3 m
Access the first row only