Build: #8 was successful Manual run by Andrew McNichols
Code commits
bamboo-config
-
Andrew McNichols f02729dee298ef438d1e5a297f26b30578cad9de
Update CASASPECS-COV
Change from pytest call to attempt use of runtest.py wrapper- bamboo-specs/include/CASASPECS/dev/COV.yaml (version f02729dee298ef438d1e5a297f26b30578cad9de)
Casa6
-
George Moellenbrock b57a321e7f4825a609a46a35dfc565c62826ca05
Pull request #902: CAS-14195
Merge in CASA/casa6 from CAS-14195 to master
* commit 'd74c9a0ba4ec491506f98bf594b2710a3258278a':
For CAS-14195, tidy up doc info in fringefit.xml
For CAS-14195, improve inline documentation for corrcomb parameter.
changed np.alltrue to np.all for new test case
For CAS-14195, added combine='spw',concatspws=True tests to Fringefit_corrcomb2 test
For CAS-14195, add new Fringefit_corrcomb2 test class to test new corrcomb modes (requires new dataset in the DR)
For CAS-14195, ensure corrcomb='stokes' and 'parallel' duplicate the combined-poln solution is duplicated to both polarizations within the output caltable (as was done for corrcomb='all' previously).
For CAS-14195, in fringefit task and underlying mechanics, add support for correlation combinations: 'stokes' (which does formal Stokes I combination of parallel hands, strictly respecting flags; formerly 'all') and 'parallel' (which does optimally weighted parallel-hand correlation combination for all available unflagged data) -
Dirk Petry <dpetry@eso.org> 09b794f051b816ac8fbe4f7896502efb8d31f758
Pull request #904: Update casacore to commit 1f3a55af2fde7b0dd1f36af31a65e0d4d67ee283
Merge in CASA/casa6 from CAS-14442 to master
* commit '88ab03e37df0bdd857328871f21a9135c3fd3f10':
Update casacore to commit 1f3a55af2fde7b0dd1f36af31a65e0d4d67ee283 -
Ville Suoranta 88ab03e37df0bdd857328871f21a9135c3fd3f10
Merge branch 'master' into CAS-14442
-
Neal Schweighart [X] ad91baf98072cb41a5e5dfd92d30dcd9079bbf92
Pull request #901: CAS-14249
Merge in CASA/casa6 from CAS-14249 to master
* commit 'c849f9cdf483096d07fbcdf2d805d0fdae773bd9':
ratesmooth now marked as experimental in the xml
re-toggled on rate smoothing for the test case
Added ratesmooth param to toggle using rates while smoothing rates are now also smoothed by smoothtime
added param passed to ct globals
remove new param from ctglobals
fixed test failure. Still using the data from the CAS-14249 ticket as the test data, Looking to add more test cases using a doctored data set
Changed cycle prediction to use the differences from the current phase value. Changed cycle prediction to iterate over polId instead of ipar. Cleaned up unused variables.
Removed complex conditions since they will never occur in this case. Removed mention of par and parok since only fpar is used. Cleaned up some spacing. Unwrap phase pol uses polid 0 and 1 now before they were set to polId which would lead both to have an id of 1
previous removals were commented out. Now the lines are deleted
removed real/imag conversion to amp/phase and removed channel looping
Changed the FringeJones smoothCT to an override of smooth
cleaned up cout statments in fringefitsmooth and added test case for new behavior
Apply to both pols (ipar==0 and 4)
Cleaned up comments and added phase wrapping for median mode
Added new fringe fit smoothing mode. (Currently just testing with smooth mode 'mean') -
Srikrishna Sekhar ddccf24a7b02382b59f049424eb67a77f0794840
Pull request #898: CAS-13901
Merge in CASA/casa6 from CAS-13901 to master
* commit '11d23f30ace690f7459f16e7fcfb288a8e5998ca':
CAS-13901: Remove asp warnings from XML
CAS-13901 : Skip asp tests on Mac darwin
CAS-13901 : Remove asp niter check in test_deconvolve
Enabled previously skipped tests 5, 53, 68, 71 87, and 90 because they are passing again. Added skip to tests 72 and 91 as both of them crash on macOS and seem to cause interferences on other tests as mentioned in comments in the script. Note that test_onefield_asp still fails with a numerical difference when run on macOS ARM hardware. Increased the timeout to run tests deconvolve and sdintimaging, needed by Bamboo on old RHEL7 cvpost nodes.
CAS-13901 : Change gain to 0.1 in asp test
CAS-13901 : Fix asp tests in deconvolve tests
CAS-13901: Fix bool definition
CAS-13901 : Fix asp behavior in deconvolve
CAS-13901 : Enable asp plumbing in deconvolve -
Neal Schweighart [X] c849f9cdf483096d07fbcdf2d805d0fdae773bd9
Merge branch 'master' into CAS-14249
-
Kumar Golap d78858ae1fcfe302d01c8b4e59f783a216d7b864
Pull request #900: CAS-14324
Merge in CASA/casa6 from CAS-14324 to master
* commit '5dc8e4458daf5060a0061e03dc814880d5bef6e0':
added coverage for mosweight=True and weighting is uniform
fix a bug where uniform was not considered as briggs weighting
Fix a problem with gridwt when restart
Full IQUV briggs weighting mtmfs psf shape bug...fixed
some changes as suggested by reviewer
CAS-14324 : improvements to unit test
CAS-14324 : Add unit tests for full stokes weighting
Fixed mfs+parallel+briggs issue that gives different psf size with parallel size -
Neal Schweighart [X] 837a51ada5eb506388d421ea0f919d8475a5682c m
ratesmooth now marked as experimental in the xml
-
Srikrishna Sekhar 11d23f30ace690f7459f16e7fcfb288a8e5998ca
Merge remote-tracking branch 'origin/master' into CAS-13901
Resolved minor merge conflict in tclean.xml -
Ville Suoranta e5f43ddcbb1d55dde7137fafc8bef055f99bca25
Pull request #899: CAS-14507
Merge in CASA/casa6 from CAS-14507 to master
* commit '3ffb7e15811f3b8e0a8fed746325730b0b8bd111':
Check for the FC variable for the Fortran compiler path and name
fix hardcoded path to libgcc [CAS-14507] -
Kumar Golap 5dc8e4458daf5060a0061e03dc814880d5bef6e0
Merge branch 'master' into CAS-14324
-
Bjorn Emonts 604187d2d8acadc61bc481012cdf447e9d675037
Pull request #897: Updated task tclean XML following CAS-14501
Merge in CASA/casa6 from CAS-14501 to master
* commit 'c5c3c77699fbe29bba5f53db4ff131acbc9822e0':
Updated task tclean XML following CAS-14501 -
Srikrishna Sekhar 6f4c2498c76c1f351c528cd0013a0e349f08e540
Merge remote-tracking branch 'origin/master' into CAS-13901
-
Srikrishna Sekhar e39af231f362cae3b96da88cc6496340cca55fa8 m
CAS-13901: Remove asp warnings from XML
Removed warnings about ASP not working in deconvolve.xml, and references
to it being an experimental algorithm in tclean.xml -
Ville Suoranta 3ffb7e15811f3b8e0a8fed746325730b0b8bd111
Check for the FC variable for the Fortran compiler path and name
-
Darrell Schiebel <darrell@schiebel.us> 1d5564df5c513318f792e8960078779a374aa1ca
fix hardcoded path to libgcc [CAS-14507]
-
Bjorn Emonts c5c3c77699fbe29bba5f53db4ff131acbc9822e0 m
Updated task tclean XML following CAS-14501
-
George Moellenbrock d74c9a0ba4ec491506f98bf594b2710a3258278a m
For CAS-14195, tidy up doc info in fringefit.xml
-
George Moellenbrock a35f6492e11fe606e849867b44389aa349a32651 m
Merge branch 'master' into CAS-14195
-
George Moellenbrock 928b26248b8cca4ef05a4ea78bc5bc5ac428795b m
For CAS-14195, improve inline documentation for corrcomb parameter.
-
Ville Suoranta 46f02d64b53bbb2cd45a71c654e6447bc4b300c5 m
Update casacore to commit 1f3a55af2fde7b0dd1f36af31a65e0d4d67ee283
-
Srikrishna Sekhar 611cdec05641c68939d271ecd59f66c76053747d m
CAS-13901 : Skip asp tests on Mac darwin
Given the difficulty in nailing down the niter criterion on Mac M1, it
was decided to continue skipping the tests on Mac and add a disclaimer
to the documentation about running asp on Mac.
The long term solution is to find a more stable minimizer than LBFGS
that yields the same numbers on different platforms. -
Srikrishna Sekhar a391bb82f4fab88cb83d6f09719b13099045d5a9 m
Merge remote-tracking branch 'origin/master' into CAS-13901
-
Neal Schweighart [X] 96846811c0174dab35252b8743e98d07d3850c84 m
Merge branch 'master' into CAS-14249
-
Kumar Golap 8617497cb10d392fcbc0b0aaf79814ab23565987 m
added coverage for mosweight=True and weighting is uniform
-
Kumar Golap ba9112af6d6749c97db8ecca3fb53c116df6f23e m
fix a bug where uniform was not considered as briggs weighting
-
Kumar Golap fb63a1b9e7a604c8bced7d407d7843b594b58a49 m
Merge branch 'master' into CAS-14324
-
Neal Schweighart [X] ddd21fece1aebede18ef03d0539ecafdc26dc430 m
changed np.alltrue to np.all for new test case
-
George Moellenbrock a30a335ea36e4dbb45cf7b81a41cbb18485eea9e m
For CAS-14195, added combine='spw',concatspws=True tests to Fringefit_corrcomb2 test
-
Neal Schweighart [X] 9fae49699be196ba83954637b680fbba5906923d m
Merge branch 'master' into CAS-14249
-
George Moellenbrock f99ed1da424959076e137863de3d73215036b6ff m
Merge branch 'master' into CAS-14195
-
George Moellenbrock b603419102ea7a8208f4868116698821cc94e04b m
For CAS-14195, add new Fringefit_corrcomb2 test class to test new corrcomb modes (requires new dataset in the DR)
-
Neal Schweighart [X] 45721bc9f4121ed48d03bb269ab6fb3e666d7c10 m
re-toggled on rate smoothing for the test case
-
Neal Schweighart [X] 3e47a5e1430b9c0a39f7ec8f9f96df2aa8646369 m
Added ratesmooth param to toggle using rates while smoothing rates are now also smoothed by smoothtime
- casatasks/tests/tasks/test_task_smoothcal.py (version 3e47a5e1430b9c0a39f7ec8f9f96df2aa8646369) (diffs)
- casatools/src/code/synthesis/CalTables/CTGlobals.cc (version 3e47a5e1430b9c0a39f7ec8f9f96df2aa8646369) (diffs)
- casatools/src/code/synthesis/CalTables/CTGlobals.h (version 3e47a5e1430b9c0a39f7ec8f9f96df2aa8646369) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/Calibrater.cc (version 3e47a5e1430b9c0a39f7ec8f9f96df2aa8646369) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/Calibrater.h (version 3e47a5e1430b9c0a39f7ec8f9f96df2aa8646369) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.cc (version 3e47a5e1430b9c0a39f7ec8f9f96df2aa8646369) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.h (version 3e47a5e1430b9c0a39f7ec8f9f96df2aa8646369) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/SolvableVisCal.cc (version 3e47a5e1430b9c0a39f7ec8f9f96df2aa8646369) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/SolvableVisCal.h (version 3e47a5e1430b9c0a39f7ec8f9f96df2aa8646369) (diffs)
- casatools/src/tools/calibrater/calibrater_cmpt.cc (version 3e47a5e1430b9c0a39f7ec8f9f96df2aa8646369) (diffs)
-
Kumar Golap 713957f6ae5f81f182d1abd99552aa0710599f2f m
Fix a problem with gridwt when restart
-
Kumar Golap b169b55758878b742a6079e0a0b258fa74d50166 m
Full IQUV briggs weighting mtmfs psf shape bug...fixed
-
Kumar Golap 74ee5b5cc465d6be0988ac5468d457c1a08e4180 m
Merge branch 'master' into CAS-14324
-
Neal Schweighart [X] 25f608d1aad3688798cfd16911d9f7d454b51af4 m
added param passed to ct globals
-
Neal Schweighart [X] cf97bf6d8c2a7f975eeeaea4082b6d94d5cb3bb1 m
remove new param from ctglobals
- casatasks/src/private/task_smoothcal.py (version cf97bf6d8c2a7f975eeeaea4082b6d94d5cb3bb1) (diffs)
- casatasks/xml/smoothcal.xml (version cf97bf6d8c2a7f975eeeaea4082b6d94d5cb3bb1) (diffs)
- casatools/src/code/synthesis/CalTables/CTGlobals.h (version cf97bf6d8c2a7f975eeeaea4082b6d94d5cb3bb1) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/Calibrater.cc (version cf97bf6d8c2a7f975eeeaea4082b6d94d5cb3bb1) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/Calibrater.h (version cf97bf6d8c2a7f975eeeaea4082b6d94d5cb3bb1) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.cc (version cf97bf6d8c2a7f975eeeaea4082b6d94d5cb3bb1) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.h (version cf97bf6d8c2a7f975eeeaea4082b6d94d5cb3bb1) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/SolvableVisCal.cc (version cf97bf6d8c2a7f975eeeaea4082b6d94d5cb3bb1) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/SolvableVisCal.h (version cf97bf6d8c2a7f975eeeaea4082b6d94d5cb3bb1) (diffs)
- casatools/src/tools/calibrater/calibrater_cmpt.cc (version cf97bf6d8c2a7f975eeeaea4082b6d94d5cb3bb1) (diffs)
- casatools/xml/calibrater.xml (version cf97bf6d8c2a7f975eeeaea4082b6d94d5cb3bb1) (diffs)
-
Neal Schweighart [X] 098362edb69605b0c3cb39d0a3f74ab8ab464b64 m
Merge branch 'master' into CAS-14249
-
Kumar Golap ee376cba0a160cec52c02ee50e4b8c57e5089752 m
Merge branch 'master' into CAS-14324
-
George Moellenbrock 6e073a185511ff61bf61ce238f4ef35dafdabb73 m
Merge branch 'master' into CAS-14195
-
George Moellenbrock 815e87675a1c8243893dbbda9ed67b12a004116a m
For CAS-14195, ensure corrcomb='stokes' and 'parallel' duplicate the combined-poln solution is duplicated to both polarizations within the output caltable (as was done for corrcomb='all' previously).
-
George Moellenbrock 80001c8d805b79589787dc6fe4c8c91422b3925f m
For CAS-14195, in fringefit task and underlying mechanics, add support for correlation combinations: 'stokes' (which does formal Stokes I combination of parallel hands, strictly respecting flags; formerly 'all') and 'parallel' (which does optimally weighted parallel-hand correlation combination for all available unflagged data)
- casatasks/xml/fringefit.xml (version 80001c8d805b79589787dc6fe4c8c91422b3925f) (diffs)
- casatools/src/code/mstransform/TVI/PolAverageTVI.cc (version 80001c8d805b79589787dc6fe4c8c91422b3925f) (diffs)
- casatools/src/code/mstransform/TVI/PolAverageTVI.h (version 80001c8d805b79589787dc6fe4c8c91422b3925f) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/CalSolVi2Organizer.cc (version 80001c8d805b79589787dc6fe4c8c91422b3925f) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/CalSolVi2Organizer.h (version 80001c8d805b79589787dc6fe4c8c91422b3925f) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/Calibrater.cc (version 80001c8d805b79589787dc6fe4c8c91422b3925f) (diffs)
-
Neal Schweighart [X] d37636a77b0612cb802aeb02e4422cb673dc81fa m
Merge branch 'master' into CAS-14249
-
Neal Schweighart [X] d63621920cf05687b3dc5568272e354723e58573 m
fixed test failure. Still using the data from the CAS-14249 ticket as the test data, Looking to add more test cases using a doctored data set
-
Neal Schweighart [X] 95c5fabce2a11d41dd11441afc9aa664cdcf2b4c m
Changed cycle prediction to use the differences from the current phase value. Changed cycle prediction to iterate over polId instead of ipar. Cleaned up unused variables.
-
Neal Schweighart [X] 869861241b9fa59d257297eaddd89a795c92923e m
Merge branch 'master' into CAS-14249
-
Neal Schweighart [X] d34d3c567f37913e6b1854c1c86758d55b57cd1e m
Removed complex conditions since they will never occur in this case. Removed mention of par and parok since only fpar is used. Cleaned up some spacing. Unwrap phase pol uses polid 0 and 1 now before they were set to polId which would lead both to have an id of 1
-
Neal Schweighart [X] ef07f2277a792b60114c7e914ed219ef548a740b m
previous removals were commented out. Now the lines are deleted
-
Neal Schweighart [X] 5ca30ce9439254679a3803ab362edc849a943955 m
removed real/imag conversion to amp/phase and removed channel looping
-
Neal Schweighart [X] 27a9eed521f338ded032875af6ef62a539fbef44 m
Changed the FringeJones smoothCT to an override of smooth
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.cc (version 27a9eed521f338ded032875af6ef62a539fbef44) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.h (version 27a9eed521f338ded032875af6ef62a539fbef44) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/SolvableVisCal.cc (version 27a9eed521f338ded032875af6ef62a539fbef44) (diffs)
-
Kumar Golap 1dddc8b379f63441a507709de9ca363ccfc7e06d m
some changes as suggested by reviewer
-
Srikrishna Sekhar 69c9100b84631a63ba817368a8811f930102d699 m
CAS-14324 : improvements to unit test
Previous unit tests didn't explicitly test for beam shape and size, this
has been amended. Also included one cube test to probe BriggsWeightor. -
Srikrishna Sekhar 0f77b29637441e91200ce259821887785c36df25 m
CAS-14324 : Add unit tests for full stokes weighting
Added a unit test that checks the fix for this - the values in the unit
test are taken from the corresponding Stokes I test, and the check is
that the IQUV beams match. -
Kumar Golap fca63cd923bf912707b91c03e0111573ea157fbb m
Fixed mfs+parallel+briggs issue that gives different psf size with parallel size
- casatasks/src/private/imagerhelpers/imager_parallel_continuum.py (version fca63cd923bf912707b91c03e0111573ea157fbb) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SynthesisNormalizer.cc (version fca63cd923bf912707b91c03e0111573ea157fbb) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SynthesisNormalizer.h (version fca63cd923bf912707b91c03e0111573ea157fbb) (diffs)
- casatools/src/code/synthesis/TransformMachines2/BriggsCubeWeightor.cc (version fca63cd923bf912707b91c03e0111573ea157fbb) (diffs)
- casatools/src/code/synthesis/TransformMachines2/BriggsCubeWeightor.h (version fca63cd923bf912707b91c03e0111573ea157fbb) (diffs)
- casatools/src/tools/synthesisnormalizer/synthesisnormalizer_cmpt.cc (version fca63cd923bf912707b91c03e0111573ea157fbb) (diffs)
- casatools/xml/synthesisnormalizer.xml (version fca63cd923bf912707b91c03e0111573ea157fbb) (diffs)
-
Neal Schweighart [X] 011b0a714eeb28fa34a763bb1f349e7f65acfb0d m
cleaned up cout statments in fringefitsmooth and added test case for new behavior
-
Neal Schweighart [X] 5136ec656c724910ec260fb02536b318c0e04e59 m
Apply to both pols (ipar==0 and 4)
-
Neal Schweighart [X] 5b764e24f7165029abef43a80f916d518afc9f9d m
Cleaned up comments and added phase wrapping for median mode
-
Neal Schweighart [X] 4bbeb0382facece1b419b609f17e64342f26abc0 m
Added new fringe fit smoothing mode. (Currently just testing with smooth mode 'mean')
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.cc (version 4bbeb0382facece1b419b609f17e64342f26abc0) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.h (version 4bbeb0382facece1b419b609f17e64342f26abc0) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/SolvableVisCal.cc (version 4bbeb0382facece1b419b609f17e64342f26abc0) (diffs)
-
Srikrishna Sekhar 5bc4a3a7b58b6bd8d06f556cd4ef93e7a32665e7 m
CAS-13901 : Remove asp niter check in test_deconvolve
The niter passing criterion has been removed from the asp test within
test_task_deconvolve. This brings it in line with the same test within
test_task_tclean as well.
The issue is that the LBFGS minimizer within the asp code is known to
follow different paths on different system platforms, which can
potentially explain the discrepancy in the niter accumulated on Linux vs
Mac.
Removing this test allows it to be run on a Mac (rather than skipped),
and given that the final image values are within tolerance on all
systems it indicates that the images are scientifically equivalent
despite the niter being different. -
smcastro <smcastro@users.noreply.github.com> bc1d06d17a821857c727f8e235ccbbd6110842de m
Enabled previously skipped tests 5, 53, 68, 71 87, and 90 because they are passing again. Added skip to tests 72 and 91 as both of them crash on macOS and seem to cause interferences on other tests as mentioned in comments in the script. Note that test_onefield_asp still fails with a numerical difference when run on macOS ARM hardware. Increased the timeout to run tests deconvolve and sdintimaging, needed by Bamboo on old RHEL7 cvpost nodes.
-
Srikrishna Sekhar 545f519b3313db5ac2f97f0052ec6134890088cc m
Merge remote-tracking branch 'origin/master' into CAS-13901
-
Srikrishna Sekhar f871f24268c442f19f5e59109635e603574030dc m
CAS-13901 : Change gain to 0.1 in asp test
Reduced gain even further to 0.1 (from 0.2) in the test_onefield_asp
test to fix the issue with the test failing on Intel Macs. The test
passing criteria have been appropriately updated.
Preliminary tests from Sandra indicate that this has worked. -
Srikrishna Sekhar ae625d22220b3c2a25598dbdb8bc3d58a23ef548 m
CAS-13901 : Fix asp tests in deconvolve tests
Edited the passing thresholds for the asp tests in test_task_deconvolve.
Used a smalled gain value (gain=0.2) similar to test_task_tclean, and
the passing criterion are based on the values for a single major cycle
in test_task_tclean.
Also enabled asp testing on Darwin - with a lower gain it is expected to
be more stable across different systems. -
Srikrishna Sekhar d14660ac320b46fd926d35a61760b96de5cd08ff m
Merge remote-tracking branch 'origin/master' into CAS-13901
-
Srikrishna Sekhar 104806777c670bc7eede1d42e7b11423a0f8efca m
CAS-13901: Fix bool definition
Fixed definition of isSingle in SynthesisDeconvolver.cc. The previous
commit erroneously commented out the initial definition. -
Srikrishna Sekhar 8177cfc4e4e449db2d755965fe7324edec0f8603 m
CAS-13901 : Fix asp behavior in deconvolve
This change forces asp to always generate per-plane scales, regardless
of the input specmode. When running asp on a cube from within
deconvolve, specmode defaults to "mfs" which would cause asp to generate
scales for the first plane, and re-use it for all subsequent planes of
the cube.
This is not right, and also diverges from the behavior in tclean. This
change fixes that.
There is also a minor fix in an output log message of AspMatrixCleaner. -
Srikrishna Sekhar 523dab0dc513193170af0212eac910ba73c97151 m
CAS-13901 : Enable asp plumbing in deconvolve
The asp deconvolver was disabled in task_deconvolve. This set of changes
just uncomments the relevant lines to re-enable it.