Build: #2 was successful
Job: Test Tools Many Linux 2.28 was successful
Code commits
Casa6
-
Srikrishna Sekhar c9c04878d6cb365e5a81753cc7545f73dff9f28c
CAS-13818 : Skip failing deconvolve tests
These two tests are skipped in master, but were not skipped here even
after a merge from master.- casatasks/tests/tasks/test_task_deconvolve.py (version c9c04878d6cb365e5a81753cc7545f73dff9f28c) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStore.cc (version c9c04878d6cb365e5a81753cc7545f73dff9f28c) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStoreMultiTerm.cc (version c9c04878d6cb365e5a81753cc7545f73dff9f28c) (diffs)
-
Srikrishna Sekhar 187638b82f7e5a07b7a7ab7f49fb31a744e569f7
CAS-13818 : Fix mask cache conflict on tclean restart
As documented, the fix for the original issue triggered a mask cache
conflict on restart. In the end the fix turned out to be fairly simple -
check if the mask exists and is valid, and do not touch it if it is.
So in the first instance, when the mask does not exist, it will do the
right thing. And it will not try to do anything on the restart either.
It ended up being a simple inversion of the original logic, with
appropriate traps in place so it works for both the original bug and the
derived bug. -
Srikrishna Sekhar 9ede592e5ee4a8c2be6803be5b93d6981a5ba365
CAS-13818: Add test to check for full stokes mask
Added a check within test_stokes_mtmfs_IQUV within test_task_tclean to test the
mask when using mtmfs + full Stokes. -
Srikrishna Sekhar cf244a71e85a37ba2bbe25c7486a5f3b4798219e
CAS-13818 : Disable test_imgval_startmodel_axesmismatch on MacOS
Added a skip to test_imgval_startmodel_axesmismatch in test_task_deconvolve for
MacOS. This test fails for unknown reasons, unrelated to the code on this
branch.
The failure and solution are being investigated on CAS-14117 and will be
re-enabled on that ticket. -
Srikrishna Sekhar f7b64a974fa7cf3bbb91a924c601714527857cb5
CAS-13818 : Fix for failing test
The previous commit fixed the issue from the parent ticket (no mask for
multi-stokes MT-MFS images) in the wrong location, causing a single tclean test
to fail. This commit moves the fix to the right spot, i.e., into
SDAlgorithMSMFS::restore which works.
All the tclean + deconvolve tests now pass locally. -
Srikrishna Sekhar 87f310f62b7d7573e9d677d5b6ab279ef9811417
CAS-13818 : Fix for image.tt0 pb mask
Fixed the issue, the full Stokes MT-MFS restored images now have the PB mask
included correctly. This has been tested with the script provided to reproduce
the original issue.