Build: #28 was successful Changes by George Moellenbrock
Code commits
Casa6
-
George Moellenbrock 86e433f3b0eafb5fa251d98ad45c15694eae424f
For CAS-14763, in ZenithDelayJones::setApply(Record&), removed some unnecessary stuff.
-
George Moellenbrock 2326a6ec0adcef7d97c752e788ea1faf5e844343
Merge branch 'master' into CAS-14763
-
George Moellenbrock 12fa37f46cbda88ba49928e092c276ecfbea4c76
For CAS-14763, added skeletal ZenithDelayJones class (ZenithDelayCal.{h,cc}) to eventually support application of zenith-angle dependent macroscopic delay calibration for VLBI, and make VisCalGlobals's SolvableVisCal factories aware of it. This requires further development for it to work.
- casatools/src/code/synthesis/MeasurementComponents/VisCalGlobals.cc (version 12fa37f46cbda88ba49928e092c276ecfbea4c76) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/ZenithDelayCal.cc (version 12fa37f46cbda88ba49928e092c276ecfbea4c76) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/ZenithDelayCal.h (version 12fa37f46cbda88ba49928e092c276ecfbea4c76) (diffs)
-
Dirk Petry <dpetry@eso.org> 059b8ab234522648c1fb903cb3dd576ba9a4b65b m
Pull request #1052: CAS-14694
Merge in CASA/casa6 from CAS-14694 to master
* commit '6f1345ac52f7252da24ccdc916163333039734d1':
For CAS-14694: In SolvableVisCal::setSimulate, for simulation of DJones only, short-circuit VI major and minor iteration over the MS so that instrumental polarization is neither time- nor (for mosaic sims) field-dependent. This breaks 'testSky_intLeak' in test_task_simobserve.py. NB: this is not yet a complete polarimetry simulation because parang is not yet treated.
CAS-14694: update simobserve task built-in help for leakage parameter
CAS-14694: make simobserve produce full-pol simulation when input model image is full-pol, independent of leakage
CAS-14694: activated test case testNZ_intMan_Leak and made sure leakage is only applied for obsmode='int'
Enable teardown for test_task_simobserve
CAS-14694: Made ANoise::nPar() in AMueller.h return 4 instead of 2.
CAS-14694: changes which seem to solve the remaining problems
CAS-14694: reverted use of sm.setfeed in simobserve task
CAS-14694 modified the task script to make appropriate sm tool calls when leakage>0 -
George Moellenbrock 6f1345ac52f7252da24ccdc916163333039734d1 m
For CAS-14694: In SolvableVisCal::setSimulate, for simulation of DJones only, short-circuit VI major and minor iteration over the MS so that instrumental polarization is neither time- nor (for mosaic sims) field-dependent. This breaks 'testSky_intLeak' in test_task_simobserve.py. NB: this is not yet a complete polarimetry simulation because parang is not yet treated.
-
Rui Xue 8f5e9581750c4df973277e17e3e5d999f318e7f7 m
Pull request #1030: CAS-14758: Optimize image processing by caching tool handles in fill_summary_minor to avoid redundant open/close operations
Merge in CASA/casa6 from CAS-14758 to master
* commit 'a46b0fa46be4985558dfe705e9f2eccf577b4aed':
CAS-14758: Handle missing residual images when constructing minor cycle summary
CAS-14758: Optimize image processing by caching tool handles in fill_summary_minor to avoid redundant open/close operations -
Rui Xue 44d9e7387ac3f53b7841b93a583e1354e361c06f m
Pull request #1040: CAS-14622
Merge in CASA/casa6 from CAS-14622 to master
* commit '6599d358e517e2dc3f94260a0d8770dd0cc64964':
CAS-14622: Fix out-of-bounds MPI segmentation faults in BriggsCubeWeightor
CAS-14622: Fix ncores-dependent tclean segmentation fault in `BriggsCubeWeightor` -
Dirk Petry <dpetry@eso.org> e9db1cf9435f211d68a67190f8e650670a5de0eb m
CAS-14694: update simobserve task built-in help for leakage parameter
-
Dirk Petry <dpetry@eso.org> 567c15cd27e8383205d3d8cee02a0be9b68ef5c4 m
Merge branch 'master' into CAS-14694
-
Akeem Wells 6599d358e517e2dc3f94260a0d8770dd0cc64964 m
Merge branch 'master' into CAS-14622
-
Bob Garwood 3f49f7503b516f27ec0cf65423a7a9e51c238085 m
Pull request #1049: CAS-14792
Merge in CASA/casa6 from CAS-14792 to master
* commit 'c4206a386e84fa23a749f5b95753860d36396bd7':
added more text to describe the measures data install step
readme.md uses www.astron.nl now for measures data -
Akeem Wells c4206a386e84fa23a749f5b95753860d36396bd7 m
Merge branch 'master' into CAS-14792
-
Kumar Golap 4d6918c6411688aeb8ab0b8b75ff610cb4885d89 m
Pull request #1048: when resetting image center the coordinate system was not being reset
Merge in CASA/casa6 from CAS-14747 to master
* commit '3c5bde23464661fe96ff365766465083f95adafd':
when resetting image center the coordinate system was not being reset -
Bob Garwood 3493dc9839d8a596467d534b28d465c141bc35b2 m
added more text to describe the measures data install step
-
Bob Garwood 632ee87ba92665433856b99c66e70e590c1fff99 m
readme.md uses www.astron.nl now for measures data
-
Kumar Golap 0673f3ad43b910fe023c96aea061c23f81f0fb38 m
Pull request #1047: It was not the precision of converting fromRecord or to Record but numpy print precision.
Merge in CASA/casa6 from CAS-13338 to master
* commit 'dfb7e5241859986be77d9b1c19a09c8e2e5c3747':
It was not the precision of converting fromRecord or to Record but numpy print precision. That I believe fixes the precision of phasecenter for parallel continuum -
Srikrishna Sekhar 50e2cf84c451f0970e69a3aaf15ddd26166eb3de m
Pull request #1046: CAS-13818
Merge in CASA/casa6 from CAS-13818 to master
* commit 'b0973d16124b120e2baf377a91488649c0034986':
CAS-13818 : Skip failing deconvolve tests
CAS-13818 : Fix mask cache conflict on tclean restart
CAS-13818: Add test to check for full stokes mask
Added a skip to test_mtmfsimgval_startmodel_axesmismatch in test_task_deconvolve for MacOS due to Fatal Python error. The failure and solution are being investigated on CAS-14117
CAS-13818 : Disable test_imgval_startmodel_axesmismatch on MacOS
CAS-13818 : Fix for failing test
CAS-13818 : Fix for image.tt0 pb mask -
Ville Suoranta 1d8db3ef8539fcf1f25aac6429130548c3a6304c m
Pull request #1045: CAS-14769
Merge in CASA/casa6 from CAS-14769 to master
* commit '85227bc5735154327b1a1394763b90f6bd60ac0a':
Update casacore reference
Revert "Point casacore to dev branch"
Remove redefition of PtrBlock in TransformMachines
Point casacore to dev branch -
Akeem Wells 96543550841e6adfc298ea4bf932d3a6befa0157 m
Pull request #1044: CAS-14768
Merge in CASA/casa6 from CAS-14768 to master
* commit '1011c5933ca639144a5ae3c253086f038da63442':
Update xmlrunner_to_junit to work with unittest-xml-reporting module -
Srikrishna Sekhar b0973d16124b120e2baf377a91488649c0034986 m
Merge remote-tracking branch 'origin/master' into CAS-13818
-
Srikrishna Sekhar a46b0fa46be4985558dfe705e9f2eccf577b4aed m
Merge remote-tracking branch 'origin/master' into CAS-14758
-
Kumar Golap dfb7e5241859986be77d9b1c19a09c8e2e5c3747 m
It was not the precision of converting fromRecord or to Record but numpy print precision. That I believe fixes the precision of phasecenter for parallel continuum
-
Ville Suoranta 85227bc5735154327b1a1394763b90f6bd60ac0a m
Update casacore reference
-
Ville Suoranta 5401a2510043db196722fda194d292eae1fbe0e4 m
Revert "Point casacore to dev branch"
This reverts commit cf53b61404c57a80cfcef14f4df9392985b57443. -
Akeem Wells 1011c5933ca639144a5ae3c253086f038da63442 m
Merge branch 'master' into CAS-14768
-
Takahiro Tsutsumi c84be1413a0d775fc6fe17d180f968a1475a1fa6 m
Pull request #1043: CAS-14606
Merge in CASA/casa6 from CAS-14606 to master
* commit 'e2af0ec57f50d3edffed7dd5384465472326b4a5':
Add a check that an entire (sub-)table is empty (nrows=0)
Fix a bug in is_column_empty function and add tb.getvarcol-based data existence check for the subtables
Add test for data types, str, int, float
Access the first row only
Use tb.getvarcol to check if optional data columns in Main table have any data instead of tb.getcell -
Dirk Petry <dpetry@eso.org> 84f01fe0d32bbe506c9c0a9eb98a6b79da1636e8 m
CAS-14694: make simobserve produce full-pol simulation when input model image is full-pol, independent of leakage
-
Kumar Golap 3c5bde23464661fe96ff365766465083f95adafd m
when resetting image center the coordinate system was not being reset
-
Ville Suoranta 76a61842ff2f6c1e457900680d14157c96c2e59e m
Remove redefition of PtrBlock in TransformMachines
-
Ville Suoranta cf53b61404c57a80cfcef14f4df9392985b57443 m
Point casacore to dev branch
-
Akeem Wells fe4695a054c35ccb9b648d91e0871c322bc267ad m
Merge branch 'master' into CAS-14622
-
Srikrishna Sekhar d8a3a4bdf7e60a99f628b34e559845c98dff371e m
Pull request #1039: CAS-13318
Merge in CASA/casa6 from CAS-13318 to master
* commit 'b6453d73d1a4098c3763b42a75b88880b3bce7ad':
CAS-13318 : Fix PB masking in robust RMS calc -
Inna Muzychenko 229d3c9b5d0436b0f48fe265b8b4bde48a585614 m
Pull request #1033: CAS-14704
Merge in CASA/casa6 from CAS-14704 to master
* commit 'd5adeb6db73246ebbb2e3e535e56a38139482f98': (34 commits)
add test_task_getjyperkalma to component map
Changes according to the NAOJ code review Refs #2870
Changes according to the NAOJ code review Refs #2869 #2870
Changes according to the NAOJ code review Refs #2868
Changes according to the NAOJ code review Refs #2866
Changes according to the NAOJ code review Refs #2865
Changes according to the NAOJ code review Refs #2864
Changes according to the NAOJ code review
Delete commented out lines
Fix bugs, add tests
Changes according to code review Refs #2858
Changes according to code review Refs #2858
Changes according to code review Refs #2846
Changes according to the code review #Refs 2851
Changes according to code review Refs #2843
Changes according to code review Refs #2860
Changes according to code review Refs #2859
Changes according to code review Refs #2857
Changes according to the code review #Refs 2854
Changes according to code review Refs #2853
... -
Akeem Wells 624b1aca4d9570ee193ab3b18ddac0db9fc2bf37 m
Update xmlrunner_to_junit to work with unittest-xml-reporting module
-
Srikrishna Sekhar b6453d73d1a4098c3763b42a75b88880b3bce7ad m
Merge remote-tracking branch 'origin/master' into CAS-13318
-
Kumar Golap e0538c1bf3ca24820f433032edf570fa2966216f m
Pull request #1037: Fix simanalyze as it was calling tclean with modelimage with non-compatible units
Merge in CASA/casa6 from CAS-14765 to master
* commit 'f11ba01acc47815dea58711a70aa50bd9a42cc2a':
Fix simanalyze as it was calling tclean with modelimage with non-compatible units -
Rui Xue ce691fac04de68e393cb9495357f72e9271ff892 m
CAS-14758: Handle missing residual images when constructing minor cycle summary
-
Takahiro Tsutsumi e2af0ec57f50d3edffed7dd5384465472326b4a5 m
Add a check that an entire (sub-)table is empty (nrows=0)
-
George Moellenbrock e91e35843d4f9dc0f7b51c238a90414011ec848b m
Pull request #1032: CAS-14348
Merge in CASA/casa6 from CAS-14348 to master
* commit 'ca6131575d1f2743a010aa75f582a58f9eab1fcf':
Re-asserting that fringefit doesn't allow orphan timesteps
For CAS-14348:
Fixing the orphan timestep fringefit bug again
Turn off debugging output now I've tested the package built with it
Fixing fringefit on a single channel (again) and adding a test for it -
Takeshi Nakazato c1bc90f7e94deaaf076d3349703f179d7448e72f m
Pull request #1027: CAS-14736
Merge in CASA/casa6 from CAS-14736 to master
* commit '2110d633fbae6d51c4507b949d448395a34c4ded':
changed format of the comment
Minor update on the comment for consistency
Properly evaluate time and exposure
Update test_cal_12712_01
CAS-14736 include fully flagged rows into the processing to produce flagged caltable row -
Kumar Golap f11ba01acc47815dea58711a70aa50bd9a42cc2a m
Fix simanalyze as it was calling tclean with modelimage with non-compatible units
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> d5adeb6db73246ebbb2e3e535e56a38139482f98 m
Merge remote-tracking branch 'origin/master' into CAS-14704
-
Akeem Wells 7f25a9ec0b4e8ec437acc395717ce5427a7d4d71 m
add test_task_getjyperkalma to component map
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> b7fa54dc5d6267a2d1d64b831a9c9fc77ca658ed m
Changes according to the NAOJ code review Refs #2870
-
Takeshi Nakazato 2110d633fbae6d51c4507b949d448395a34c4ded m
changed format of the comment
-
George Moellenbrock ca6131575d1f2743a010aa75f582a58f9eab1fcf m
Merge remote-tracking branch 'origin/CAS-14726' into CAS-14348 conflicts in FringeJones.cc, DelayRateFFT.cc fixed manually.
-
Takeshi Nakazato 9b02d47ec419a7fb0cc7ddd127571e83bbd78afc m
Minor update on the comment for consistency
Fixed inconsistent comment associated with the updated test. -
Rui Xue f03ba5194e6eaca95fb699a2fa3cccd2c7658cbf m
CAS-14758: Optimize image processing by caching tool handles in fill_summary_minor to avoid redundant open/close operations
-
Takahiro Tsutsumi b16c5ce495369cf93b416cd12e7c6954ddf83611 m
Fix a bug in is_column_empty function and add tb.getvarcol-based data existence check for the subtables
-
Rui Xue 8fbe09615738a7a02c5c218a2ba4598911874183 m
CAS-14622: Fix out-of-bounds MPI segmentation faults in BriggsCubeWeightor
The SynthesisImager uses BriggsCubeWeightor to compute weights for the image cube. During distributed MPI execution (`ncores > 1`), the output cube's spectral axis is partitioned across multiple nodes into smaller local subcubes.
When evaluating MS data channels, `GridFT::channelMap` maps the visibilities' frequencies into the local subcube's channel indices. If an MS contains dataset frequencies (e.g., from large Doppler swings or wide ephemeris velocity changes) that land *above* the local MPI subcube's maximum channel, `channelMap` returns an index exceeding the local array bounds.
Previously, BriggsCubeWeightor only checked the lower bound (`chanMap(chn) > -1`) before using the calculated index to access `wgtDensity` and the `f2_p`/`d2_p` arrays. Accessing these arrays with indices belonging to higher MPI partitions resulted in unconstrained out-of-bounds memory accesses, causing silent heap corruption or explicit Segmentation Faults, heavily dependent on the MPI slicing and dataset footprint.
This commit resolves the issue by introducing strict upper-bound channel footprint constraints (`chanMap(chn) < shape()[3]`) in both `weightUniform` and `getWeightUniform`. Data channels that mathematically fall outside the upper bounds of the local MPI partition are now securely ignored. -
Des Small 93f24986e972db3e9803b9f76d350598311da10a m
Re-asserting that fringefit doesn't allow orphan timesteps
In a future release we should allow single time fringefit if not solving for delay, just as we allow single channel fringefit
when not solving for rate, but now is not the time. -
Rui Xue 3000ee0fe103736833f139a6c7dbdf3eca4abb82 m
CAS-14622: Fix ncores-dependent tclean segmentation fault in `BriggsCubeWeightor`
The SynthesisImager uses `BriggsCubeWeightor` to compute weights for the image cube. During this calculation, `BriggsCubeWeightor::cube2Matrix` extracts raw storage pointers `pcube` and `pflags` from `casacore::Array::getStorage(deleteIt)`.
Previously, the code incremented these exact pointers (`*pflags = *pcube++`) during array traversal. At the end of the function, the incremented pointers were passed directly to `freeStorage()` and `putStorage()`.
When array memory isn't contiguous (which occurs when data is sliced across MPI ranks), `getStorage()` allocates a temporary buffer and sets `deleteIt = true`. Passing the shifted pointer into `freeStorage()` invokes `delete[]` on an invalid memory address, causing heap corruption and a Segmentation fault randomly depending on the data slicing.
This commit resolves the issue by securely caching the original pointers returned from `getStorage` into distinct variables. The traversal loops now use separate copies of these pointers, enabling the original allocation addresses to be correctly evaluated and freed by `freeStorage()` and `putStorage()`. -
George Moellenbrock 921dfad4a8a14b6d9d98ac21e12f88989cc17db3 m
Merge branch 'master' into CAS-14348
-
George Moellenbrock 1b982bd657af81609f15651cdf0038301cd6a6f6 m
For CAS-14348:
1. In DelayRateFFT.cc's DelayRateFFTConcat class:
(a) Reordered working array (Vpad_) axes to put time and freq before corr and ant (Fortran order) so they are contiguous for 2d FFT;
(b) Introduced direct use of fftw (instead of LatticeFFT) thereby drastically improving performance of the FFT stage; by (mainly) avoiding unnecessary copies;
(c) Improved array slicing to streamline (unavoidable) data copies into the working array;
(d) Introduced Double precision weight sum accumulation (copied to Single precision at the end), and streamlined weight accumulation code to make it clearer;
(e) In snr calulation use amplitude found in searchPeak instead of relocating it via calculation from delay/rate solutions;
(f) Various other code clean-up and minor re-org.
2. In FringeJones.cc: Logging improvements for readability, and introduced fringefit stage solving time measurements and logging.
3. In Calibrater.cc: Occasionally (every ~10%) report solution count progress, and don't log useless solution quality stats for FringeJones (they are not yet filled correctly)- casatools/src/code/synthesis/MeasurementComponents/Calibrater.cc (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/DelayRateFFT.cc (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.cc (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.h (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> d45e0d268df57019b05cba8dbee5d17a722bd4e9 m
Changes according to the NAOJ code review Refs #2869 #2870
-
Takeshi Nakazato 74bbc92e85d60fdae3a02e2cd3f6f79752375426 m
Properly evaluate time and exposure
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> 4d0a1a93f28b58cd0483a05800de5b03efedddcc m
Changes according to the NAOJ code review Refs #2868
-
Takeshi Nakazato ee4cba4ece22f6b79596b1b795d497d28e47a37f m
Merge branch 'master' into CAS-14736
-
Des Small 749ab91d5875e60ee94fc139bb2b0e9acea50e04 m
Merge branch 'master' into CAS-14726
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> 2f41b7e75d3633b4f4eae04e0370f422b0adce95 m
Changes according to the NAOJ code review Refs #2866
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> bce0d4c02bb723a7fba9b3831c47fa239180d536 m
Changes according to the NAOJ code review Refs #2865
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> ad69d02088e308ad35190176cd076e658a41a954 m
Changes according to the NAOJ code review Refs #2864
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> c841edca23ece8b9e22603ef699305ec1488b402 m
Changes according to the NAOJ code review
-
Des Small 040d518f901c10138314a2d4d1d9ce5c0417776e m
Fixing the orphan timestep fringefit bug again
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> 6ebf6a0f0daf3c2ad70fed7872ce350b21821d97 m
Delete commented out lines
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> b11f8f86c82a303c36f1f9aff8b065dfc41053f1 m
Fix bugs, add tests
-
Takahiro Tsutsumi 68a9bac2144ccae3259c56de1bdd6b2edc25a158 m
Add test for data types, str, int, float
-
Takahiro Tsutsumi 7aca7a422dccf268486ac1ab5a5268b26b8ccaf3 m
Access the first row only
-
Takahiro Tsutsumi 1d9a1e86d5d6464c599037b83359947d72d1efdd m
Use tb.getvarcol to check if optional data columns in Main table have any data instead of tb.getcell
-
Takeshi Nakazato 872ed8889036b200d7b9ee2507d70546a6352a20 m
Merge branch 'master' into CAS-14736
-
Dirk Petry <dpetry@eso.org> 4726346e973f5a3c785530a712e2479ff0ce3e3f m
Merge branch 'CAS-14694' of https://open-bitbucket.nrao.edu/scm/casa/casa6 into CAS-14694
-
Dirk Petry <dpetry@eso.org> c0d3e7a5d5bde00a576b1eda1affede4b660df06 m
CAS-14694: activated test case testNZ_intMan_Leak and made sure leakage is only applied for obsmode='int'
-
Dirk Petry <dpetry@eso.org> c896f72b5b4c031a88ef6ae292bd578e7fe5e4bd m
CAS-14694: Merge branch 'master' into CAS-14694
-
Srikrishna Sekhar b8317c3a1e1b0f7ceb2a4c0cc7a7eeaa61a9d146 m
CAS-13318 : Fix PB masking in robust RMS calc
The initial bug seems to be because the outlierfield lies outside the
specified PB mask, and ends up being all masked pixels. This causes the
RMS estimation to fail, as well as deconvolution.
The fix is to switch the default mask to be unmasked in an outlierfield,
and after the PB mask is applied if the image is completely masked,
temporarily unmask it for RMS estimation.
This fixes the initial issue reported in the ticket, but investigating
if there are any unintended effects. -
Akeem Wells 5531296aa4fcd61a0f096539e16d116479b6af64 m
Enable teardown for test_task_simobserve
-
Srikrishna Sekhar ca5cf74ea4826b7c981a5931f405467735b895bc m
CAS-13818 : Skip failing deconvolve tests
These two tests are skipped in master, but were not skipped here even
after a merge from master.- casatasks/tests/tasks/test_task_deconvolve.py (version ca5cf74ea4826b7c981a5931f405467735b895bc) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStore.cc (version ca5cf74ea4826b7c981a5931f405467735b895bc) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStoreMultiTerm.cc (version ca5cf74ea4826b7c981a5931f405467735b895bc) (diffs)
-
Srikrishna Sekhar b8764caa1a4106dddb60f554b01670367722607b m
Merge remote-tracking branch 'origin/master' into CAS-13818
-
Dirk Petry <dpetry@eso.org> 6656f07b8b82cc43b7f3bad62eaaf936fa1d4f2b m
CAS-14694: Made ANoise::nPar() in AMueller.h return 4 instead of 2.
-
Takeshi Nakazato d12c9a692449db0da3644bad5e99dd4c296471d0 m
Update test_cal_12712_01
Expected number of rows changed from 61 to 64. This is due to the addition of fully flagged rows (3 rows). The test was updated to compare the number of total caltable rows as well as the number of fully flagged rows. -
Takeshi Nakazato 35399f1f96bbea04bef346fac272897db36ccdf4 m
CAS-14736 include fully flagged rows into the processing to produce flagged caltable row
-
Srikrishna Sekhar 1dcf3787bf43a9bf7622907c35d8971ad01d7087 m
CAS-13818 : Fix mask cache conflict on tclean restart
As documented, the fix for the original issue triggered a mask cache
conflict on restart. In the end the fix turned out to be fairly simple -
check if the mask exists and is valid, and do not touch it if it is.
So in the first instance, when the mask does not exist, it will do the
right thing. And it will not try to do anything on the restart either.
It ended up being a simple inversion of the original logic, with
appropriate traps in place so it works for both the original bug and the
derived bug. -
Srikrishna Sekhar f12d89e8155d92b786530e0078ed983406ba2287 m
Merge remote-tracking branch 'origin/master' into CAS-13818
-
Dirk Petry <dpetry@eso.org> b2d9854421f55b26faaec5b843a0d835ebc6feb7 m
CAS-14694: changes which seem to solve the remaining problems
- casatasks/src/private/task_simobserve.py (version b2d9854421f55b26faaec5b843a0d835ebc6feb7) (diffs)
- casatasks/tests/tasks/test_task_simobserve.py (version b2d9854421f55b26faaec5b843a0d835ebc6feb7) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/AMueller.h (version b2d9854421f55b26faaec5b843a0d835ebc6feb7) (diffs)
- casatools/src/code/synthesis/MeasurementEquations/VisEquation.cc (version b2d9854421f55b26faaec5b843a0d835ebc6feb7) (diffs)
-
Des Small fd0b2ba74d70b397ded8f269cbf5141549d6cbcd m
Turn off debugging output now I've tested the package built with it
-
Des Small 39f8d314f0617de8ad30a3b1f060993fcba169b2 m
Fixing fringefit on a single channel (again) and adding a test for it
- casatasks/tests/tasks/test_task_fringefit.py (version 39f8d314f0617de8ad30a3b1f060993fcba169b2) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/DelayRateFFT.cc (version 39f8d314f0617de8ad30a3b1f060993fcba169b2) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/DelayRateFFT.h (version 39f8d314f0617de8ad30a3b1f060993fcba169b2) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.cc (version 39f8d314f0617de8ad30a3b1f060993fcba169b2) (diffs)
-
Dirk Petry <dpetry@eso.org> 99c16562c6617e2ce5918f6121fa25e7a1c18081 m
CAS-14694: Merge branch 'master' into CAS-14694
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> d376bdf41439602af52778a8c7ea99215dfe6ad2 m
Merge remote-tracking branch 'origin/master' into CAS-14704
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> ed677042bbd2dcc201c93be4c7c88bad23ab7bb5 m
Changes according to code review Refs #2858
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> c05496390bf5eb4058d82038c20cb4dc1aece92a m
Changes according to code review Refs #2858
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> af32f491dacd4288fa305b22ffa4a8730728af5e m
Changes according to code review Refs #2846
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> 9fa575e366377282012b526a8a7579479a842d19 m
Merge branch 'CAS-14704' of https://open-bitbucket.nrao.edu/scm/casa/casa6 into CAS-14704
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> 64110fc25916d0e8d5bb8a2ed5bad628035d92fe m
Changes according to the code review #Refs 2852
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> b9a071e0e0798511705ec60483b660375a6473fc m
Merge branch 'CAS-14704' of https://open-bitbucket.nrao.edu/scm/casa/casa6 into CAS-14704
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> 761fac2b244722432f51f35317740ae97db8cf18 m
Changes according to the code review #Refs 2851
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> 2e2a2fc37e02ed73c2739be42f23bb476d6b49fe m
Changes according to code review Refs #2843
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> e85717a3b5c399165b1bf66ab93030e09fa85626 m
Changes according to code review Refs #2860
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> 79141b11a496d5152c87be476dc87894befad89c m
Changes according to code review Refs #2859
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> 3022211d5aa464cb82f7d8ae6deb477ca76ea344 m
Changes according to code review Refs #2857
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> fd9399c6ba605919f1a6862feea70642e6bdeac1 m
Changes according to the code review #Refs 2854
-
Muzychenko Inna <inna.muzychenko@ana01.alma.nao.ac.jp> e474753d26633a6854254d2513b55e448e142e3e m
Changes according to code review Refs #2853