CAS-14759: skip redundant normalizeprimarybeam() for cube+standard
For the standard gridder with specmode=cube, each worker in
CubeMajorCycleAlgorithm::task() already normalizes the primary beam
per-subcube during PSF making and writes the result back to the full
image. The subsequent master-side normalizeprimarybeam() loop over all
(pol x chan) planes was therefore redundant and, for a 7500-channel
8000x8000 cube, accounted for ~31 minutes of wall time after
"Time for making PSF and PB".
Changes:
- Extract the cube+standard guard into isCubeStandard bool for clarity.
- Skip the normalizeprimarybeam() loop when isCubeStandard is True.
- makePBCore() is unchanged and still skipped for cube+standard as before.
- Add a timing log entry "***Time for normalizeprimarybeam: <s> (skipped=<bool>)"
at INFO3 so the optimisation is observable in tclean logs.
This path is safe to skip only for standard+cube because mosaicft and
awproject gridders derive PB from sqrt(weight)/pbmax and require the
fully-assembled weight image, which is only available on the master
after all subcubes have been written back.
CAS-14759: Fix potential lock contention in SIImageStore::makeImageBeamSet
This commit addresses a performance bottleneck where `tclean` would stall
for extended periods (often hours) during the initialization and
re-fitting phases of large spectral cubes with many MPI ranks.
Within `makeImageBeamSet()`, a `LatticeLocker` read-lock on the PSF image
was instantiated and subsequently destroyed on every single combined
channel and polarization iteration. For a 60,000 channel cube, this resulted
in 60,000 individual, sequential Lustre metadata transactions (lock requests
and releases) per process.
The `LatticeLocker` is now hoisted outside the nested loops, allowing the
process to obtain a single read-lock that persists for the duration of the
fitting iterations. This condenses millions of filesystem lock updates
across an MPI cluster down to exactly one, significantly reducing I/O
synchronization overhead during `mpicasa` execution.
