Build: #29 was successful Changes by Srikrishna Sekhar
Code commits
Casa6
-
Srikrishna Sekhar 50e2cf84c451f0970e69a3aaf15ddd26166eb3de
Pull request #1046: CAS-13818
Merge in CASA/casa6 from CAS-13818 to master
* commit 'b0973d16124b120e2baf377a91488649c0034986':
CAS-13818 : Skip failing deconvolve tests
CAS-13818 : Fix mask cache conflict on tclean restart
CAS-13818: Add test to check for full stokes mask
Added a skip to test_mtmfsimgval_startmodel_axesmismatch in test_task_deconvolve for MacOS due to Fatal Python error. The failure and solution are being investigated on CAS-14117
CAS-13818 : Disable test_imgval_startmodel_axesmismatch on MacOS
CAS-13818 : Fix for failing test
CAS-13818 : Fix for image.tt0 pb mask -
Srikrishna Sekhar b0973d16124b120e2baf377a91488649c0034986 m
Merge remote-tracking branch 'origin/master' into CAS-13818
-
Srikrishna Sekhar ca5cf74ea4826b7c981a5931f405467735b895bc m
CAS-13818 : Skip failing deconvolve tests
These two tests are skipped in master, but were not skipped here even
after a merge from master.- casatasks/tests/tasks/test_task_deconvolve.py (version ca5cf74ea4826b7c981a5931f405467735b895bc) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStore.cc (version ca5cf74ea4826b7c981a5931f405467735b895bc) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStoreMultiTerm.cc (version ca5cf74ea4826b7c981a5931f405467735b895bc) (diffs)
-
Srikrishna Sekhar b8764caa1a4106dddb60f554b01670367722607b m
Merge remote-tracking branch 'origin/master' into CAS-13818
-
Srikrishna Sekhar 1dcf3787bf43a9bf7622907c35d8971ad01d7087 m
CAS-13818 : Fix mask cache conflict on tclean restart
As documented, the fix for the original issue triggered a mask cache
conflict on restart. In the end the fix turned out to be fairly simple -
check if the mask exists and is valid, and do not touch it if it is.
So in the first instance, when the mask does not exist, it will do the
right thing. And it will not try to do anything on the restart either.
It ended up being a simple inversion of the original logic, with
appropriate traps in place so it works for both the original bug and the
derived bug. -
Srikrishna Sekhar f12d89e8155d92b786530e0078ed983406ba2287 m
Merge remote-tracking branch 'origin/master' into CAS-13818
-
Srikrishna Sekhar e9c363510f36d63230e74a9075a06e65eb4ee6b2 m
CAS-13818: Add test to check for full stokes mask
Added a check within test_stokes_mtmfs_IQUV within test_task_tclean to test the
mask when using mtmfs + full Stokes. -
Akeem Wells 9fd98280248fddc92b692d14aab4b5fb9a5c6dd3 m
Added a skip to test_mtmfsimgval_startmodel_axesmismatch in test_task_deconvolve for MacOS due to Fatal Python error. The failure and solution are being investigated on CAS-14117
-
Srikrishna Sekhar 40c02d7f0905f0b1a5fe4160e14a37fef39b3154 m
CAS-13818 : Disable test_imgval_startmodel_axesmismatch on MacOS
Added a skip to test_imgval_startmodel_axesmismatch in test_task_deconvolve for
MacOS. This test fails for unknown reasons, unrelated to the code on this
branch.
The failure and solution are being investigated on CAS-14117 and will be
re-enabled on that ticket. -
Srikrishna Sekhar 1095b56a0e0b446e4733b3a0afa1a5a7d8b1b123 m
CAS-13818 : Fix for failing test
The previous commit fixed the issue from the parent ticket (no mask for
multi-stokes MT-MFS images) in the wrong location, causing a single tclean test
to fail. This commit moves the fix to the right spot, i.e., into
SDAlgorithMSMFS::restore which works.
All the tclean + deconvolve tests now pass locally. -
Srikrishna Sekhar 24294615507801e5a512818b85aa9956a9a1518e m
CAS-13818 : Fix for image.tt0 pb mask
Fixed the issue, the full Stokes MT-MFS restored images now have the PB mask
included correctly. This has been tested with the script provided to reproduce
the original issue.