OPEN-CASA

• 

  Darrell Schiebel 09 Feb 2019 5e2f93616ff3fd39b259855a558cdb88572febb9

  Merge pull request #871 in CASA/casa from CAS-11734 to master
  * commit 'd5d125e306416d53d1a0ca504acddf514ca854eb':
    Fix compiler warning
    Adds unit tests that checks the phantom SPWs are treated correctly by getChannels()
    Fix typo and simplify logic
    Support calling getChannels() for "phantom" SPWs
    Revert "Workaround issue with CAS-11734: getChannels() throws if phantom SPWs are present"
• 

  C. Enrique Garcia Dabo 06 Feb 2019 d5d125e306416d53d1a0ca504acddf514ca854eb m

  Fix compiler warning
  Fixes partially CAS-11734

  • code/flagging/Flagging/RFASelector2.cc (version d5d125e306416d53d1a0ca504acddf514ca854eb) (diffs)
• 

  C. Enrique Garcia Dabo 06 Feb 2019 409dbe33445ac206e50a3b65cd3ade15fe55574b m

  Adds unit tests that checks the phantom SPWs are treated correctly by getChannels()
  The unit test creates a synthethic MS with an extra SPW which is
  not references by the Data Description subtable.
  It checks that the channels seen by the upper TVI are correct.
  Fixes partially CAS-11734

  • code/msvis/MSVis/test/VisibilityIterator_Gtest.cc (version 409dbe33445ac206e50a3b65cd3ade15fe55574b) (diffs)
  • code/msvis/MSVis/test/VisibilityIterator_Gtest.h (version 409dbe33445ac206e50a3b65cd3ade15fe55574b) (diffs)
• 

  C. Enrique Garcia Dabo 05 Feb 2019 db1d9bbd291381e304bd3b79aaf3cccd4a6bc99a m

  Fix typo and simplify logic
  The loop on spw has been removed, since the only goal
  was to check that the spectralWindowID is less that the
  length of the spectral window subtable .
  Fixes partially CAS-11734

  • code/msvis/MSVis/VisibilityIteratorImpl2.cc (version db1d9bbd291381e304bd3b79aaf3cccd4a6bc99a) (diffs)
• 

  C. Enrique Garcia Dabo 05 Feb 2019 ed4eeb48eeb233ca83d4cf788d9a29606061335a m

  Support calling getChannels() for "phantom" SPWs
  Calling getChannels() for SPWs that do not appear in the
  DataDescription table (also called phantoms) caused an
  exception due to the missing polarization entry in the
  DataDescription table. This is supported now by returning
  -1 in getPolarizationID() and supporting that value in the
  makeChannelSelectorC() function.
  
  Fixes partially CAS-11734

  • code/msvis/MSVis/VisibilityIteratorImpl2.cc (version ed4eeb48eeb233ca83d4cf788d9a29606061335a) (diffs)
• 

  C. Enrique Garcia Dabo 05 Feb 2019 baf7eb889c0d61621bc5eb0a791a34ec6e56f72b m

  Revert "Workaround issue with CAS-11734: getChannels() throws if phantom SPWs are present"
  This reverts commit 636ca2387930fd38047e41ba0b1741cec9e2f5a9.

  • gcwrap/python/scripts/regressions/alma_asdm+reimported-asdm_sf.py (version baf7eb889c0d61621bc5eb0a791a34ec6e56f72b) (diffs)