Build: #48 was successful Child of CASA-CTT-99

Build result summary

Details

Completed
Queue duration
1 second
Duration
2 minutes
Labels
None
Agent
cbt-el7-6.cv.nrao.edu
Revisions
OPEN-CASA
5e2f93616ff3fd39b259855a558cdb88572febb9 5e2f93616ff3fd39b259855a558cdb88572febb9
OPEN-CASA-PKG
4e2f475d63bcad9c7e50c95a0dfa8ec19820b120 4e2f475d63bcad9c7e50c95a0dfa8ec19820b120
Successful since
#36 ()

Code commits

OPEN-CASA
Author Commit Message Commit date
Darrell Schiebel Darrell Schiebel 5e2f93616ff3fd39b259855a558cdb88572febb9 5e2f93616ff3fd39b259855a558cdb88572febb9 Merge pull request #871 in CASA/casa from CAS-11734 to master
* commit 'd5d125e306416d53d1a0ca504acddf514ca854eb':
  Fix compiler warning
  Adds unit tests that checks the phantom SPWs are treated correctly by getChannels()
  Fix typo and simplify logic
  Support calling getChannels() for "phantom" SPWs
  Revert "Workaround issue with CAS-11734: getChannels() throws if phantom SPWs are present"
C. Enrique Garcia Dabo C. Enrique Garcia Dabo d5d125e306416d53d1a0ca504acddf514ca854eb m d5d125e306416d53d1a0ca504acddf514ca854eb Fix compiler warning
Fixes partially CAS-11734
C. Enrique Garcia Dabo C. Enrique Garcia Dabo 409dbe33445ac206e50a3b65cd3ade15fe55574b m 409dbe33445ac206e50a3b65cd3ade15fe55574b Adds unit tests that checks the phantom SPWs are treated correctly by getChannels()
The unit test creates a synthethic MS with an extra SPW which is
not references by the Data Description subtable.
It checks that the channels seen by the upper TVI are correct.
Fixes partially CAS-11734
C. Enrique Garcia Dabo C. Enrique Garcia Dabo db1d9bbd291381e304bd3b79aaf3cccd4a6bc99a m db1d9bbd291381e304bd3b79aaf3cccd4a6bc99a Fix typo and simplify logic
The loop on spw has been removed, since the only goal
was to check that the spectralWindowID is less that the
length of the spectral window subtable .
Fixes partially CAS-11734
C. Enrique Garcia Dabo C. Enrique Garcia Dabo ed4eeb48eeb233ca83d4cf788d9a29606061335a m ed4eeb48eeb233ca83d4cf788d9a29606061335a Support calling getChannels() for "phantom" SPWs
Calling getChannels() for SPWs that do not appear in the
DataDescription table (also called phantoms) caused an
exception due to the missing polarization entry in the
DataDescription table. This is supported now by returning
-1 in getPolarizationID() and supporting that value in the
makeChannelSelectorC() function.

Fixes partially CAS-11734

Jira issues

IssueDescriptionStatus
Unknown Issue TypeCAS-11734Could not obtain issue details from Jira