Build: #122 was successful Changes by Hendrik Muller and André Offringa <offringa@astron.nl>

Stages & jobs

  1. Tag

  2. Default Stage

  3. Create Test Plan Branch

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
11 minutes
Labels
None
Agent
cbt-el7-10.cv.nrao.edu
Revisions
Casa6
b1364209b14c59988f2bbeb0a20cdaca9d7f26a7
OPEN-CASA-PKG
e5285e68467f01199807a1f1a978aec8a4781be7
GitHub Casacore
f0394fed408a64618d08f4be45d8e8d5c6a64a18
Successful since
#119 ()

Code commits

Casa6
Author Commit Message Commit date
Hendrik Muller Hendrik Muller b1364209b14c59988f2bbeb0a20cdaca9d7f26a7 Pull request #1071: CAS-14778
Merge in CASA/casa6 from CAS-14778 to master

* commit '0d731f5701553c3bcd07344a0be600f6ec4afee4':
  CAS-14778 : Fix rectangular image case
  rename to cameltype and assert that dimensions are either both even or both odd
  Add test
  Copy the solution for odd pixels that was found for Matrix Cleaner over to also apply to MultiTermMatrixCleaner.cc Validated on Cygnus A, scales=[0,1], nterms=1, cellsize = 1.6 arcsec (such that the bright termination lobes correspond to just a few pixels transversely, in this way we can test the effect of the code change without simply looking at the effects of extended emission)
  Solved the problem for an odd number of pixels for Asp-CLEAN and MS-CLEAN. That is simply done by moving the slice for the beam subtraction up by one pixel. The problem does not exist for Hogbom. TBD: Verify that these fixes also fix the spectral versions and multiterm versions of the deconvolvers.
Hendrik Muller Hendrik Muller 0d731f5701553c3bcd07344a0be600f6ec4afee4 m Merge master into CAS-14778 and solve conflicts
Srikrishna Sekhar Srikrishna Sekhar d03371710fc33be7f53d288c28b57661ecab1afd m CAS-14778 : Fix rectangular image case
Specifically, allow one axis to be odd and the other even. Previously
this was trapped as an exception, but this is explicitly a use-case that
tclean supports.
Hendrik Muller <hmuller@smurf.aoc.nrao.edu> Hendrik Muller <hmuller@smurf.aoc.nrao.edu> a23393d10e4d61b542ce4f503b84139fcf2b79c1 m rename to cameltype and assert that dimensions are either both even or both odd
Hendrik Muller <hmuller@smurf.aoc.nrao.edu> Hendrik Muller <hmuller@smurf.aoc.nrao.edu> 1e86847f0d14c829305b9799311670e7888e2d85 m Merge branch 'master' into CAS-14778

Jira issues

IssueDescriptionStatus
Unknown Issue TypeCAS-14778Could not obtain issue details from Jira