Takahiro Tsutsumi 07 Apr 2025 b256d2493c3d2857432a6a4927b6a2211ea66deb

Pull request #927: CAS-14315
Merge in CASA/casa6 from CAS-14315 to master

* commit 'd6e548662348bf17eef03a749128c077471540c2':
  Clean up commented lines
  Add unit tests for CAS-14315
  Remove fullsummary=F specific indixing for mpicasa run
  Fixed Stokes indexing for fullsummary=F by not use channel and Stokes combined indexing. Added Stokes ids to the C++ matrix to construct the returned dictionary.

Neal Schweighart 02 Apr 2025 16dc26b7d312f83f8d3a432f39be037dc1a1848c

Pull request #928: CAS-14406
Merge in CASA/casa6 from CAS-14406 to master

* commit '780574cb276d2a2a28103985d5c8f4566c3d7ae0': (46 commits)
  requires unique outvis and updated overwrite test
  fixed overwrite option bug
  fixed typo
  Added the check for relevant spw to the syscal subtable as well
  removed some extra prints
  fix for frequency ranges
  cleaned up some comments
  The task should now also overwrite values without replacing the whole table or adding duplicates
  changed test to match the new behavior. Removed some prints from the task to prevent crowding the output
  Some indexing and naming fixes
  fixed dict index error
  Checks for existing antenna measurment for a given time and ignores antab data if not overwriting. Current overwrite still overwrites the whole file
  Changed the gain curve interval to use the obs table information instead of ms metadata, same results as before but cleaner looking in task.
  Changed the Type 1 and 2 to match the idi filler and use POWER(EL) and POWER(ZA) instead. Re-added the th table comparison to the test since the differences in other cols were not getting detected. Gain col still uses custom checker and is ignored by the test helper function.
  lowering the atol on gain comparision? There are failures only for arm
  fixed shape error when appending on gain_curve
  fixed error with GAIN_CURVE append condition. Still might be challenges if gain len is 1?
  More dev on case in new tarball
  removed msg causing error, not sure why settrop had failure on recent build
  added new gain curve append test case and fixed issue with gain curve append behavior
  ...

taktsutsumi <53955475+taktsutsumi@users.noreply.github.com> 01 Apr 2025 d6e548662348bf17eef03a749128c077471540c2

Merge branch 'master' into CAS-14315 Fix conflict in SIMinorCycleController.cc

Neal Schweighart 27 Mar 2025 780574cb276d2a2a28103985d5c8f4566c3d7ae0

Merge branch 'master' into CAS-14406

Neal Schweighart 27 Mar 2025 674296281e7b7ca3495bc0b1745cb454fe59b20e m

requires unique outvis and updated overwrite test

• casatasks/src/private/task_appendantab.py (version 674296281e7b7ca3495bc0b1745cb454fe59b20e) (diffs)
• casatasks/tests/tasks/test_task_appendantab.py (version 674296281e7b7ca3495bc0b1745cb454fe59b20e) (diffs)

Neal Schweighart 20 Mar 2025 f988055e72d0c5c24c0435a80e9174040ae1bb10 m

fixed overwrite option bug

• casatasks/src/private/task_appendantab.py (version f988055e72d0c5c24c0435a80e9174040ae1bb10) (diffs)

Neal Schweighart 14 Mar 2025 3f8627463e24865d079e8f4557ad904701a67283 m

fixed typo

• casatasks/src/private/task_appendantab.py (version 3f8627463e24865d079e8f4557ad904701a67283) (diffs)

Neal Schweighart 14 Mar 2025 e0c786526dd3105facebd22e1071d6dba908353f m

Added the check for relevant spw to the syscal subtable as well

• casatasks/src/private/task_appendantab.py (version e0c786526dd3105facebd22e1071d6dba908353f) (diffs)

Neal Schweighart 12 Mar 2025 90ba4f1e60313f9dc942f74357a4cc6702b82e75 m

removed some extra prints

• casatasks/src/private/task_appendantab.py (version 90ba4f1e60313f9dc942f74357a4cc6702b82e75) (diffs)

Neal Schweighart 11 Mar 2025 39eff17e5193376f9c0640f184e68cd1effeec8b m

Merge branch 'master' into CAS-14406

Neal Schweighart 11 Mar 2025 fba88e720d33723ac6215d39fa4a03aa996d82bd m

fix for frequency ranges

• casatasks/src/private/task_appendantab.py (version fba88e720d33723ac6215d39fa4a03aa996d82bd) (diffs)

Neal Schweighart 20 Dec 2024 2610686ae7c8b564681b6c4aee6ccd07d4334101 m

cleaned up some comments

• casatasks/src/private/task_appendantab.py (version 2610686ae7c8b564681b6c4aee6ccd07d4334101) (diffs)

Neal Schweighart 18 Dec 2024 ddb8070fe3cb433509fb4f88192f855da2605a49 m

The task should now also overwrite values without replacing the whole table or adding duplicates

• casatasks/src/private/task_appendantab.py (version ddb8070fe3cb433509fb4f88192f855da2605a49) (diffs)

Neal Schweighart 17 Dec 2024 ae028d04a9a41196fc3ab59f1c7831564c4d85c6 m

changed test to match the new behavior. Removed some prints from the task to prevent crowding the output

• casatasks/src/private/task_appendantab.py (version ae028d04a9a41196fc3ab59f1c7831564c4d85c6) (diffs)
• casatasks/tests/tasks/test_task_appendantab.py (version ae028d04a9a41196fc3ab59f1c7831564c4d85c6) (diffs)

Neal Schweighart 13 Dec 2024 61daebc1464808899b264f8888620f72a0a1c2c7 m

Some indexing and naming fixes

• casatasks/src/private/task_appendantab.py (version 61daebc1464808899b264f8888620f72a0a1c2c7) (diffs)

Neal Schweighart 13 Dec 2024 a7c5abc2ccb8ddfe7e6e285cff9d954d8a209fc2 m

fixed dict index error

• casatasks/src/private/task_appendantab.py (version a7c5abc2ccb8ddfe7e6e285cff9d954d8a209fc2) (diffs)

Neal Schweighart 11 Dec 2024 e5db9cfdf152abda74c764b908e6efa0d9f81afb m

Checks for existing antenna measurment for a given time and ignores antab data if not overwriting. Current overwrite still overwrites the whole file

• casatasks/src/private/task_appendantab.py (version e5db9cfdf152abda74c764b908e6efa0d9f81afb) (diffs)

Neal Schweighart 20 Nov 2024 6c99cfafb49a262ddd147a98ffef207484fb73d5 m

Merge branch 'master' into CAS-14406

Takahiro Tsutsumi 25 Oct 2024 8f5e579cf728e2c6784e21b8e83ae28c119de748 m

Merge branch 'master' into CAS-14315

Neal Schweighart 25 Oct 2024 265a954e9e7a333633c6cb1a58e3902e76e8d227 m

Changed the gain curve interval to use the obs table information instead of ms metadata, same results as before but cleaner looking in task.

• casatasks/src/private/task_appendantab.py (version 265a954e9e7a333633c6cb1a58e3902e76e8d227) (diffs)
• casatasks/tests/tasks/test_task_appendantab.py (version 265a954e9e7a333633c6cb1a58e3902e76e8d227) (diffs)

Neal Schweighart 24 Oct 2024 b129a3063b779a541f5f8ac8a859802c1415399a m

Changed the Type 1 and 2 to match the idi filler and use POWER(EL) and POWER(ZA) instead. Re-added the th table comparison to the test since the differences in other cols were not getting detected. Gain col still uses custom checker and is ignored by the test helper function.

• casatasks/src/private/task_appendantab.py (version b129a3063b779a541f5f8ac8a859802c1415399a) (diffs)
• casatasks/tests/tasks/test_task_appendantab.py (version b129a3063b779a541f5f8ac8a859802c1415399a) (diffs)

Takahiro Tsutsumi 22 Oct 2024 ba9c5bb33c6a387e1ca8b02cce466d7141fcf669 m

Clean up commented lines

• casatasks/src/private/imagerhelpers/summary_minor.py (version ba9c5bb33c6a387e1ca8b02cce466d7141fcf669) (diffs)
• casatools/src/code/synthesis/ImagerObjects/SDAlgorithmBase.cc (version ba9c5bb33c6a387e1ca8b02cce466d7141fcf669) (diffs)
• casatools/src/code/synthesis/ImagerObjects/SIMinorCycleController.cc (version ba9c5bb33c6a387e1ca8b02cce466d7141fcf669) (diffs)
• casatools/src/code/synthesis/ImagerObjects/SynthesisDeconvolver.cc (version ba9c5bb33c6a387e1ca8b02cce466d7141fcf669) (diffs)
• casatools/src/code/synthesis/ImagerObjects/grpcInteractiveClean.cc (version ba9c5bb33c6a387e1ca8b02cce466d7141fcf669) (diffs)

Takahiro Tsutsumi 09 Oct 2024 dec60fff2d9476a284b85a79b10adda9c37ad7ca m

Add unit tests for CAS-14315

• casatasks/tests/tasks/test_task_tclean.py (version dec60fff2d9476a284b85a79b10adda9c37ad7ca) (diffs)

Takahiro Tsutsumi 02 Oct 2024 b146f8758ad86ceed0b38db5c4e7e2812b8a2ec8 m

Remove fullsummary=F specific indixing for mpicasa run

• casatasks/src/private/imagerhelpers/summary_minor.py (version b146f8758ad86ceed0b38db5c4e7e2812b8a2ec8) (diffs)

Neal Schweighart 02 Oct 2024 162c9a58b9a1751e9d1b973ff134d22014cf2a23 m

lowering the atol on gain comparision? There are failures only for arm

• casatasks/tests/tasks/test_task_appendantab.py (version 162c9a58b9a1751e9d1b973ff134d22014cf2a23) (diffs)

Neal Schweighart 01 Oct 2024 64d9709c043643b5dedfce0ab729d7d821ce60d2 m

fixed shape error when appending on gain_curve

• casatasks/src/private/task_appendantab.py (version 64d9709c043643b5dedfce0ab729d7d821ce60d2) (diffs)

Neal Schweighart 01 Oct 2024 e3e4e1778a8c347066d301a5d6b5f9a2b0941c00 m

fixed error with GAIN_CURVE append condition. Still might be challenges if gain len is 1?

• casatasks/src/private/task_appendantab.py (version e3e4e1778a8c347066d301a5d6b5f9a2b0941c00) (diffs)
• casatasks/tests/tasks/test_task_appendantab.py (version e3e4e1778a8c347066d301a5d6b5f9a2b0941c00) (diffs)

Takahiro Tsutsumi 30 Sep 2024 0aa7c977163a4e5c49b2d9186d1ba68f526e8378 m

Fixed Stokes indexing for fullsummary=F by not use channel and Stokes combined indexing. Added Stokes ids to the C++ matrix to construct the returned dictionary.

• casatasks/src/private/imagerhelpers/summary_minor.py (version 0aa7c977163a4e5c49b2d9186d1ba68f526e8378) (diffs)
• casatools/src/code/synthesis/ImagerObjects/SDAlgorithmBase.cc (version 0aa7c977163a4e5c49b2d9186d1ba68f526e8378) (diffs)
• casatools/src/code/synthesis/ImagerObjects/SIMinorCycleController.cc (version 0aa7c977163a4e5c49b2d9186d1ba68f526e8378) (diffs)
• casatools/src/code/synthesis/ImagerObjects/SynthesisDeconvolver.cc (version 0aa7c977163a4e5c49b2d9186d1ba68f526e8378) (diffs)
• casatools/src/code/synthesis/ImagerObjects/grpcInteractiveClean.cc (version 0aa7c977163a4e5c49b2d9186d1ba68f526e8378) (diffs)

Neal Schweighart 30 Sep 2024 2c75706d4e9f9ab486e60ae92e0e41a95f436e1d m

More dev on case in new tarball

• casatasks/tests/tasks/test_task_appendantab.py (version 2c75706d4e9f9ab486e60ae92e0e41a95f436e1d) (diffs)

Neal Schweighart 30 Sep 2024 fb0c288d8a9070c5b6694b5789e9a03554ade04c m

removed msg causing error, not sure why settrop had failure on recent build

• casatasks/tests/tasks/test_task_appendantab.py (version fb0c288d8a9070c5b6694b5789e9a03554ade04c) (diffs)

Neal Schweighart 30 Sep 2024 95c0db4fd2034f72d55f28430a5903d48bb617bc m

added new gain curve append test case and fixed issue with gain curve append behavior

• casatasks/src/private/task_appendantab.py (version 95c0db4fd2034f72d55f28430a5903d48bb617bc) (diffs)
• casatasks/tests/tasks/test_task_appendantab.py (version 95c0db4fd2034f72d55f28430a5903d48bb617bc) (diffs)

Neal Schweighart 28 Sep 2024 a2c8f14dbcecd3ae414d33666b79b4a095b24180 m

fixed typo

• casatasks/src/private/task_appendantab.py (version a2c8f14dbcecd3ae414d33666b79b4a095b24180) (diffs)

Neal Schweighart 27 Sep 2024 079a35f2b336260d234b96d3d05933b8cd9de375 m

skipping append test for now. will devlop the tarball and include a GAIN-CURVE specific case as well

• casatasks/tests/tasks/test_task_appendantab.py (version 079a35f2b336260d234b96d3d05933b8cd9de375) (diffs)

Neal Schweighart 27 Sep 2024 0877fc1d48a5d3ec98a91c630d05baeae013e74e m

fixed SENSITIVITY append, same as TSYS fix

• casatasks/src/private/task_appendantab.py (version 0877fc1d48a5d3ec98a91c630d05baeae013e74e) (diffs)

Neal Schweighart 27 Sep 2024 25c10d3b120288e753617d79bb1daa907cfc4a94 m

Gain table filling was doing some potentially un-needed shape enforcment

• casatasks/src/private/task_appendantab.py (version 25c10d3b120288e753617d79bb1daa907cfc4a94) (diffs)

Neal Schweighart 27 Sep 2024 6f3aecc13f820f919f3cf418feee5f6f41fdf5f9 m

changed the way Gains are assembled in the append case

• casatasks/src/private/task_appendantab.py (version 6f3aecc13f820f919f3cf418feee5f6f41fdf5f9) (diffs)

Neal Schweighart 27 Sep 2024 dab4f5169ea9009854210ad5264456d65bf9173f m

Fixes to assembly of TSYS in append mode revealed by test

• casatasks/src/private/task_appendantab.py (version dab4f5169ea9009854210ad5264456d65bf9173f) (diffs)

Neal Schweighart 25 Sep 2024 96daad226c5b629f017812cff1a499a6348c6b37 m

for append case too many rows were added which caused a conformance error when the put calls were used

• casatasks/src/private/task_appendantab.py (version 96daad226c5b629f017812cff1a499a6348c6b37) (diffs)

Neal Schweighart 24 Sep 2024 3cd74378f54aaa08902b946e02cdde668889aa3d m

removing use of test helper table comparison since it had strange failures on macOS

• casatasks/tests/tasks/test_task_appendantab.py (version 3cd74378f54aaa08902b946e02cdde668889aa3d) (diffs)

Neal Schweighart 24 Sep 2024 0564f2902d7774cc3f4b2a855720d7ca46de21ae m

Adding new test for appending to existing ms

• casatasks/tests/tasks/test_task_appendantab.py (version 0564f2902d7774cc3f4b2a855720d7ca46de21ae) (diffs)

Neal Schweighart 24 Sep 2024 f916f329def113c3c4c6b0c80cf2e1db25e87869 m

fixed error with test helper missing param

• casatasks/tests/tasks/test_task_appendantab.py (version f916f329def113c3c4c6b0c80cf2e1db25e87869) (diffs)

Neal Schweighart 28 Aug 2024 b4a41eab8026287067ab1f2782bca05e782ba8ba m

Fixed comparisons with the GAIN col in GAIN_CURVE tables and fixed TSYS table filling

• casatasks/src/private/task_appendantab.py (version b4a41eab8026287067ab1f2782bca05e782ba8ba) (diffs)
• casatasks/tests/tasks/test_task_appendantab.py (version b4a41eab8026287067ab1f2782bca05e782ba8ba) (diffs)

Neal Schweighart 27 Aug 2024 1b4e10da8ee658f241e0322ecc9b570b634a86a4 m

Fixed error when using append behavior with an empty table. Tsys col would have no shape which would lead to errors when inserting data

• casatasks/src/private/task_appendantab.py (version 1b4e10da8ee658f241e0322ecc9b570b634a86a4) (diffs)

Neal Schweighart 26 Aug 2024 d569cc0335f66b3bf6105d5a78e629d3ecfb38f3 m

fixed failures where overwrite value was not being passed down through the functions

• casatasks/src/private/task_appendantab.py (version d569cc0335f66b3bf6105d5a78e629d3ecfb38f3) (diffs)

Neal Schweighart 23 Aug 2024 72ef929e132bb7c193ddccd364acad84127f5e32 m

fixed typo in append mode

• casatasks/src/private/task_appendantab.py (version 72ef929e132bb7c193ddccd364acad84127f5e32) (diffs)
• casatasks/tests/tasks/test_task_appendantab.py (version 72ef929e132bb7c193ddccd364acad84127f5e32) (diffs)

Neal Schweighart 22 Aug 2024 92a5980534fe7672dc37f5ff703e42256c201d7f m

adding append default behavior, still needs testing for how the data is re-arranged...

• casatasks/src/private/task_appendantab.py (version 92a5980534fe7672dc37f5ff703e42256c201d7f) (diffs)

Neal Schweighart 13 Aug 2024 409dbbaf1f478db95ad1157de49cf4c37c701855 m

added appendantab test to component_to_test_map.json

• casatestutils/casatestutils/component_to_test_map.json (version 409dbbaf1f478db95ad1157de49cf4c37c701855) (diffs)

Neal Schweighart 09 Aug 2024 28931d5ce75e5eda68b90cc75e63db645f24274d m

changed task to fill TSYS col in SYSCAL table properly

• casatasks/src/private/task_appendantab.py (version 28931d5ce75e5eda68b90cc75e63db645f24274d) (diffs)
• casatasks/tests/tasks/test_task_appendantab.py (version 28931d5ce75e5eda68b90cc75e63db645f24274d) (diffs)

Neal Schweighart 06 Aug 2024 ab5edd0160b80f6125b6e9775e2ae879122767eb m

fixed setup.py, wasn't the up-to-date version

• casatasks/setup.py (version ab5edd0160b80f6125b6e9775e2ae879122767eb) (diffs)

Neal Schweighart 06 Aug 2024 b0b80a9fedf42818e26cafd54fccc3bfd8f30508 m

Merge branch 'master' into CAS-14406

Neal Schweighart 05 Aug 2024 cd9d9fcc5fc8675fff40ce5aa29f9c39a35e37da m

fixed some spacing issues added new parameters to the xml properly added the test case back using testhelper table comparison (does this work for the subtables?)

• casatasks/src/private/task_appendantab.py (version cd9d9fcc5fc8675fff40ce5aa29f9c39a35e37da) (diffs)
• casatasks/tests/tasks/test_task_appendantab.py (version cd9d9fcc5fc8675fff40ce5aa29f9c39a35e37da) (diffs)
• casatasks/xml/appendantab.xml (version cd9d9fcc5fc8675fff40ce5aa29f9c39a35e37da) (diffs)

Neal Schweighart 05 Aug 2024 87d50553d981f085ac56438600c7c3c0a5166024 m

removing test for now to make sure setup is working properly

• casatasks/tests/tasks/test_task_appendantab.py (version 87d50553d981f085ac56438600c7c3c0a5166024) (diffs)

Neal Schweighart 05 Aug 2024 d25421687a0bae8e6c21f0bf14bd5987db662255 m

fixed setup.py file to inculde the task and added verification test

• casatasks/setup.py (version d25421687a0bae8e6c21f0bf14bd5987db662255) (diffs)
• casatasks/tests/tasks/test_task_appendantab.py (version d25421687a0bae8e6c21f0bf14bd5987db662255) (diffs)

Neal Schweighart 23 Jul 2024 cdad71128815da292f36be537ade7461069f2c4a m

fixed issue with to append bools not getting passed down

• casatasks/src/private/task_appendantab.py (version cdad71128815da292f36be537ade7461069f2c4a) (diffs)

Neal Schweighart 23 Jul 2024 55f13c108a69ba7df6234b05368bffbb7c2a14df m

fixed typo

• casatasks/src/private/task_appendantab.py (version 55f13c108a69ba7df6234b05368bffbb7c2a14df) (diffs)

Neal Schweighart 23 Jul 2024 6f81d0828b13514ea273989f23368930c41693b3 m

added param for enable/disabling append_tsys and append_g

• casatasks/src/private/task_appendantab.py (version 6f81d0828b13514ea273989f23368930c41693b3) (diffs)

Neal Schweighart 23 Jul 2024 529258699ac38593817a1466076998bb7e0306de m

Added overwrite protection and removed leftovers from testing locally

• casatasks/src/private/task_appendantab.py (version 529258699ac38593817a1466076998bb7e0306de) (diffs)

Neal Schweighart 18 Jul 2024 9bf09ba3f696073a4e5ec14be0be2cfdaf416f31 m

added new task for appending antab data

• casatasks/src/private/task_appendantab.py (version 9bf09ba3f696073a4e5ec14be0be2cfdaf416f31) (diffs)
• casatasks/xml/appendantab.xml (version 9bf09ba3f696073a4e5ec14be0be2cfdaf416f31) (diffs)

André Offringa <offringa@gmail.com> 08 Apr 2025 1cfe6199f22574a41de8a0ef9bc1919cf5e11e49

Fix an indexing bug in DataManInfo::removeDminfoColumns() (#1410)

• tables/DataMan/DataManInfo.cc (version 1cfe6199f22574a41de8a0ef9bc1919cf5e11e49)