Build: #151 was successful Changes by Bob Garwood and André Offringa <offringa@gmail.com>

Stages & jobs

  1. Tag

  2. Default Stage

  3. Create Test Plan Branch

Code commits

Casa6

GitHub Casacore

  • André Offringa <offringa@gmail.com>

    André Offringa <offringa@gmail.com> ce9287267f6f7d72d25f925c2dcbdc9c0b7b2f13

    Repair compilation for some configs after type changes (#1536)
    * Repair compilation for some configs after type changes

    * Formatting

    • casa/Exceptions/CasaErrorTools.cc (version ce9287267f6f7d72d25f925c2dcbdc9c0b7b2f13)
    • casa/HDF5/HDF5Record.cc (version ce9287267f6f7d72d25f925c2dcbdc9c0b7b2f13)
    • lattices/LatticeMath/LatticeStatistics.tcc (version ce9287267f6f7d72d25f925c2dcbdc9c0b7b2f13)
  • André Offringa <offringa@gmail.com>

    André Offringa <offringa@gmail.com> d416120230c8e48bda16008d44bada5af8e8da96

    Fix incorrect renaming of getdoubleV->getDoubleV / float (#1537)
    Codex seemed in some cases to have incorrectly renamed some of the methods, which had slipped
    through my review. This MR fixes that, which is important to maintain compatibility with
    existing code (e.g. LofarStMan).

    It also adds 'override' to several functions that intend to override. One function intends
    to override but actually didn't and would never be called. This method has been removed.

    • tables/DataMan/StManColumn.cc (version d416120230c8e48bda16008d44bada5af8e8da96)
    • tables/DataMan/StManColumn.h (version d416120230c8e48bda16008d44bada5af8e8da96)
    • tables/DataMan/test/dVirtColEng.cc (version d416120230c8e48bda16008d44bada5af8e8da96)
    • tables/DataMan/test/dVirtColEng.h (version d416120230c8e48bda16008d44bada5af8e8da96)
    • tables/DataMan/test/tExternalStMan.cc (version d416120230c8e48bda16008d44bada5af8e8da96)