Skip to navigation
Skip to content

Code commits

casa6

Ville Suoranta 04 Oct 2021 bfdbadcc34d29fa304f9216d385694ec74ebe8e4

Merge pull request #460 in CASA/casa6 from CAS-12735 to master
* commit 'ece27617e4edc3bb09791f34c4215f9d6e34e399':
  For CAS-12735, in Calibrater::genericGatherAndSolve, handle simdata_p=True case properly in Freq meta-data section so that c++ unit tests using SimpleSimVi2 will work properly (e.g., tCalibraterSolveSimData_GT); also added tests of FreqMetaData class to tVisCal_GT.cc
  Removed leftover caltables from new frequency meta tests
  For CAS-12735: Added tests for gaincal freq meta data improvements, using existing data in DR. (No change to existing tests)
  For CAS-12735: In SolvableVisCal::discernAndSetSolutionFrequencies, fixed indexing of spwfanin for non-trivial combine='spw' case. Corrected some comments in ChannelAverageTVI::getChanWidths
  For CAS-12735: More improvements in freq-meta calculation: (a) when append=T, check freq-meta consistency for spws already in the disk caltable, (b) add logging info about frqe-meta, (c) removed some couts left behind in previous commits
  For CAS-12735: In SolvableVisCal.cc fixed bad cast syntax in previous commit that broke in casa6 build
  For CAS-12735: introduce freq-meta calculation for solve globally before the solve starts, via new FreqMetaData class.
  For CAS-12735 (cal freq-meta), added machinery to serve nominal channel width info (alongside channel frequencies) via ViImplementation2::getChanWidths function (cf getFrequencies). Requisite derivations also added to VisibilityIteratorImpl2, TransformingVi2, SimpleSimVi2, and (especially) ChannelAverageTVI. The getChanWidths function does not support arbitrary frame conversions on the widths (which would be very subtle, and which are not needed for the present context), and access is only available from the ViImplementation2 interface (no VisBuffer2 accessor, as yet). In ChannelAverageTVI, some adjustments made to make the bypass for the single-channel (degenerate) case in the getFrequencies and getChanWidths functions *not* depend on a call to visibilityShape() (which, in turn, depends on VI2 synchronization. This permits access to effective frequency and width info (including when averaging) for any spectral window outside the VI2 iteration loops in applications. (c++ unit tests for ChannelAverageTVI pending)
George Moellenbrock 03 Oct 2021 ece27617e4edc3bb09791f34c4215f9d6e34e399

Merge branch 'master' into CAS-12735
George Moellenbrock 01 Oct 2021 9a641f28e7e72bf0f0d6803665a7714053a2e576 m

For CAS-12735, in Calibrater::genericGatherAndSolve, handle simdata_p=True case properly in Freq meta-data section so that c++ unit tests using SimpleSimVi2 will work properly (e.g., tCalibraterSolveSimData_GT); also added tests of FreqMetaData class to tVisCal_GT.cc
- casa5/code/synthesis/MeasurementComponents/Calibrater.cc (version 9a641f28e7e72bf0f0d6803665a7714053a2e576) (diffs)
- casa5/code/synthesis/MeasurementComponents/test/tVisCal_GT.cc (version 9a641f28e7e72bf0f0d6803665a7714053a2e576) (diffs)
Neal Schweighart 21 Sep 2021 6830d7c3fd649ad8166d153421f882dd08ed4787 m

Removed leftover caltables from new frequency meta tests
- casa5/gcwrap/python/scripts/tests/test_req_task_gaincal.py (version 6830d7c3fd649ad8166d153421f882dd08ed4787) (diffs)
- casatasks/tests/tasks/test_req_task_gaincal.py (version 6830d7c3fd649ad8166d153421f882dd08ed4787) (diffs)
George Moellenbrock 21 Sep 2021 cd4c1083e3e9b0682a6f6980a95b977d31efe7f3 m

For CAS-12735: Added tests for gaincal freq meta data improvements, using existing data in DR. (No change to existing tests)
- casa5/gcwrap/python/scripts/tests/test_req_task_gaincal.py (version cd4c1083e3e9b0682a6f6980a95b977d31efe7f3) (diffs)
- casatasks/tests/tasks/test_req_task_gaincal.py (version cd4c1083e3e9b0682a6f6980a95b977d31efe7f3) (diffs)
George Moellenbrock 20 Sep 2021 1b054b0f9a682757c9ab20c2b9e346de3e96917e m

For CAS-12735: In SolvableVisCal::discernAndSetSolutionFrequencies, fixed indexing of spwfanin for non-trivial combine='spw' case. Corrected some comments in ChannelAverageTVI::getChanWidths
- casa5/code/mstransform/TVI/ChannelAverageTVI.cc (version 1b054b0f9a682757c9ab20c2b9e346de3e96917e) (diffs)
- casa5/code/synthesis/MeasurementComponents/SolvableVisCal.cc (version 1b054b0f9a682757c9ab20c2b9e346de3e96917e) (diffs)
George Moellenbrock 19 Sep 2021 53f4695848af1f15a68e7c4d4634d8560a05b98d m

Merge branch 'master' into CAS-12735
George Moellenbrock 19 Sep 2021 6ec85d44ea12b40fcbad9ad0b979222ddd335bdd m

For CAS-12735: More improvements in freq-meta calculation: (a) when append=T, check freq-meta consistency for spws already in the disk caltable, (b) add logging info about frqe-meta, (c) removed some couts left behind in previous commits
George Moellenbrock 17 Sep 2021 b6b960055b639c7ae4ec9863a04e2310d7e7ab28 m

For CAS-12735: In SolvableVisCal.cc fixed bad cast syntax in previous commit that broke in casa6 build
- casa5/code/synthesis/MeasurementComponents/SolvableVisCal.cc (version b6b960055b639c7ae4ec9863a04e2310d7e7ab28) (diffs)
George Moellenbrock 17 Sep 2021 4d0e7b9bfd67d6844ed2742b950112132708ed3b m

For CAS-12735: introduce freq-meta calculation for solve globally before the solve starts, via new FreqMetaData class.
George Moellenbrock 22 Jun 2021 0d885ec30ff125a3e093b182eb1d15d0f857715d m

For CAS-12735 (cal freq-meta), added machinery to serve nominal channel width info (alongside channel frequencies) via ViImplementation2::getChanWidths function (cf getFrequencies). Requisite derivations also added to VisibilityIteratorImpl2, TransformingVi2, SimpleSimVi2, and (especially) ChannelAverageTVI. The getChanWidths function does not support arbitrary frame conversions on the widths (which would be very subtle, and which are not needed for the present context), and access is only available from the ViImplementation2 interface (no VisBuffer2 accessor, as yet). In ChannelAverageTVI, some adjustments made to make the bypass for the single-channel (degenerate) case in the getFrequencies and getChanWidths functions *not* depend on a call to visibilityShape() (which, in turn, depends on VI2 synchronization. This permits access to effective frequency and width info (including when averaging) for any spectral window outside the VI2 iteration loops in applications. (c++ unit tests for ChannelAverageTVI pending)