Build: #292 was successful Changes by George Moellenbrock and Ville Suoranta
Code commits
Casa6
-
Ville Suoranta bfdbadcc34d29fa304f9216d385694ec74ebe8e4
Merge pull request #460 in CASA/casa6 from CAS-12735 to master
* commit 'ece27617e4edc3bb09791f34c4215f9d6e34e399':
For CAS-12735, in Calibrater::genericGatherAndSolve, handle simdata_p=True case properly in Freq meta-data section so that c++ unit tests using SimpleSimVi2 will work properly (e.g., tCalibraterSolveSimData_GT); also added tests of FreqMetaData class to tVisCal_GT.cc
Removed leftover caltables from new frequency meta tests
For CAS-12735: Added tests for gaincal freq meta data improvements, using existing data in DR. (No change to existing tests)
For CAS-12735: In SolvableVisCal::discernAndSetSolutionFrequencies, fixed indexing of spwfanin for non-trivial combine='spw' case. Corrected some comments in ChannelAverageTVI::getChanWidths
For CAS-12735: More improvements in freq-meta calculation: (a) when append=T, check freq-meta consistency for spws already in the disk caltable, (b) add logging info about frqe-meta, (c) removed some couts left behind in previous commits
For CAS-12735: In SolvableVisCal.cc fixed bad cast syntax in previous commit that broke in casa6 build
For CAS-12735: introduce freq-meta calculation for solve globally before the solve starts, via new FreqMetaData class.
For CAS-12735 (cal freq-meta), added machinery to serve nominal channel width info (alongside channel frequencies) via ViImplementation2::getChanWidths function (cf getFrequencies). Requisite derivations also added to VisibilityIteratorImpl2, TransformingVi2, SimpleSimVi2, and (especially) ChannelAverageTVI. The getChanWidths function does not support arbitrary frame conversions on the widths (which would be very subtle, and which are not needed for the present context), and access is only available from the ViImplementation2 interface (no VisBuffer2 accessor, as yet). In ChannelAverageTVI, some adjustments made to make the bypass for the single-channel (degenerate) case in the getFrequencies and getChanWidths functions *not* depend on a call to visibilityShape() (which, in turn, depends on VI2 synchronization. This permits access to effective frequency and width info (including when averaging) for any spectral window outside the VI2 iteration loops in applications. (c++ unit tests for ChannelAverageTVI pending) -
George Moellenbrock ece27617e4edc3bb09791f34c4215f9d6e34e399
Merge branch 'master' into CAS-12735
-
George Moellenbrock 9a641f28e7e72bf0f0d6803665a7714053a2e576 m
For CAS-12735, in Calibrater::genericGatherAndSolve, handle simdata_p=True case properly in Freq meta-data section so that c++ unit tests using SimpleSimVi2 will work properly (e.g., tCalibraterSolveSimData_GT); also added tests of FreqMetaData class to tVisCal_GT.cc
-
Neal Schweighart 6830d7c3fd649ad8166d153421f882dd08ed4787 m
Removed leftover caltables from new frequency meta tests
-
George Moellenbrock cd4c1083e3e9b0682a6f6980a95b977d31efe7f3 m
For CAS-12735: Added tests for gaincal freq meta data improvements, using existing data in DR. (No change to existing tests)
-
George Moellenbrock 1b054b0f9a682757c9ab20c2b9e346de3e96917e m
For CAS-12735: In SolvableVisCal::discernAndSetSolutionFrequencies, fixed indexing of spwfanin for non-trivial combine='spw' case. Corrected some comments in ChannelAverageTVI::getChanWidths
-
George Moellenbrock 53f4695848af1f15a68e7c4d4634d8560a05b98d m
Merge branch 'master' into CAS-12735
-
George Moellenbrock 6ec85d44ea12b40fcbad9ad0b979222ddd335bdd m
For CAS-12735: More improvements in freq-meta calculation: (a) when append=T, check freq-meta consistency for spws already in the disk caltable, (b) add logging info about frqe-meta, (c) removed some couts left behind in previous commits
- casa5/code/mstransform/TVI/ChannelAverageTVI.cc (version 6ec85d44ea12b40fcbad9ad0b979222ddd335bdd) (diffs)
- casa5/code/synthesis/MeasurementComponents/SolvableVisCal.cc (version 6ec85d44ea12b40fcbad9ad0b979222ddd335bdd) (diffs)
- casa5/code/synthesis/MeasurementComponents/SolvableVisCal.h (version 6ec85d44ea12b40fcbad9ad0b979222ddd335bdd) (diffs)
-
George Moellenbrock b6b960055b639c7ae4ec9863a04e2310d7e7ab28 m
For CAS-12735: In SolvableVisCal.cc fixed bad cast syntax in previous commit that broke in casa6 build
-
George Moellenbrock 4d0e7b9bfd67d6844ed2742b950112132708ed3b m
For CAS-12735: introduce freq-meta calculation for solve globally before the solve starts, via new FreqMetaData class.
- casa5/code/synthesis/MeasurementComponents/Calibrater.cc (version 4d0e7b9bfd67d6844ed2742b950112132708ed3b) (diffs)
- casa5/code/synthesis/MeasurementComponents/SolvableVisCal.cc (version 4d0e7b9bfd67d6844ed2742b950112132708ed3b) (diffs)
- casa5/code/synthesis/MeasurementComponents/SolvableVisCal.h (version 4d0e7b9bfd67d6844ed2742b950112132708ed3b) (diffs)
-
George Moellenbrock 0d885ec30ff125a3e093b182eb1d15d0f857715d m
For CAS-12735 (cal freq-meta), added machinery to serve nominal channel width info (alongside channel frequencies) via ViImplementation2::getChanWidths function (cf getFrequencies). Requisite derivations also added to VisibilityIteratorImpl2, TransformingVi2, SimpleSimVi2, and (especially) ChannelAverageTVI. The getChanWidths function does not support arbitrary frame conversions on the widths (which would be very subtle, and which are not needed for the present context), and access is only available from the ViImplementation2 interface (no VisBuffer2 accessor, as yet). In ChannelAverageTVI, some adjustments made to make the bypass for the single-channel (degenerate) case in the getFrequencies and getChanWidths functions *not* depend on a call to visibilityShape() (which, in turn, depends on VI2 synchronization. This permits access to effective frequency and width info (including when averaging) for any spectral window outside the VI2 iteration loops in applications. (c++ unit tests for ChannelAverageTVI pending)
- casa5/code/mstransform/TVI/ChannelAverageTVI.cc (version 0d885ec30ff125a3e093b182eb1d15d0f857715d) (diffs)
- casa5/code/mstransform/TVI/ChannelAverageTVI.h (version 0d885ec30ff125a3e093b182eb1d15d0f857715d) (diffs)
- casa5/code/msvis/MSVis/SimpleSimVi2.cc (version 0d885ec30ff125a3e093b182eb1d15d0f857715d) (diffs)
- casa5/code/msvis/MSVis/SimpleSimVi2.h (version 0d885ec30ff125a3e093b182eb1d15d0f857715d) (diffs)
- casa5/code/msvis/MSVis/TransformingVi2.cc (version 0d885ec30ff125a3e093b182eb1d15d0f857715d) (diffs)
- casa5/code/msvis/MSVis/TransformingVi2.h (version 0d885ec30ff125a3e093b182eb1d15d0f857715d) (diffs)
- casa5/code/msvis/MSVis/ViImplementation2.h (version 0d885ec30ff125a3e093b182eb1d15d0f857715d) (diffs)
- casa5/code/msvis/MSVis/VisibilityIteratorImpl2.cc (version 0d885ec30ff125a3e093b182eb1d15d0f857715d) (diffs)
- casa5/code/msvis/MSVis/VisibilityIteratorImpl2.h (version 0d885ec30ff125a3e093b182eb1d15d0f857715d) (diffs)
- casa5/code/msvis/MSVis/test/tSimpleSimVi2_GT.cc (version 0d885ec30ff125a3e093b182eb1d15d0f857715d) (diffs)