Build: #292 was successful Changes by George Moellenbrock and Ville Suoranta

Stages & jobs

  1. Tag

  2. Get next Casalith version

  3. Build casatestutils

  4. Default Stage

  5. Tag Casalith

  6. Create Test Plan Branch

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
123 minutes
Labels
None
Revisions
Casa6
bfdbadcc34d29fa304f9216d385694ec74ebe8e4 bfdbadcc34d29fa304f9216d385694ec74ebe8e4
OPEN-CASA-PKG
1c5513f1ef04f397433e7ea0efa166b7404a53b8 1c5513f1ef04f397433e7ea0efa166b7404a53b8
Successful since
#280 ()

Code commits

Casa6
Author Commit Message Commit date
Ville Suoranta Ville Suoranta bfdbadcc34d29fa304f9216d385694ec74ebe8e4 bfdbadcc34d29fa304f9216d385694ec74ebe8e4 Merge pull request #460 in CASA/casa6 from CAS-12735 to master
* commit 'ece27617e4edc3bb09791f34c4215f9d6e34e399':
  For CAS-12735, in Calibrater::genericGatherAndSolve, handle simdata_p=True case properly in Freq meta-data section so that c++ unit tests using SimpleSimVi2 will work properly (e.g., tCalibraterSolveSimData_GT); also added tests of FreqMetaData class to tVisCal_GT.cc
  Removed leftover caltables from new frequency meta tests
  For CAS-12735:  Added tests for gaincal freq meta data improvements, using existing data in DR. (No change to existing tests)
  For CAS-12735:  In SolvableVisCal::discernAndSetSolutionFrequencies, fixed indexing of spwfanin for non-trivial combine='spw' case.  Corrected some comments in ChannelAverageTVI::getChanWidths
  For CAS-12735: More improvements in freq-meta calculation: (a) when append=T, check freq-meta consistency for spws already in the disk caltable, (b) add logging info about frqe-meta, (c) removed some couts left behind in previous commits
  For CAS-12735: In SolvableVisCal.cc fixed bad cast syntax in previous commit that broke in casa6 build
  For CAS-12735: introduce freq-meta calculation for solve globally before the solve starts, via new FreqMetaData class.
  For CAS-12735 (cal freq-meta), added machinery to serve nominal channel width info (alongside channel frequencies) via ViImplementation2::getChanWidths function (cf getFrequencies).  Requisite derivations also added to VisibilityIteratorImpl2, TransformingVi2, SimpleSimVi2, and (especially) ChannelAverageTVI.  The getChanWidths function does not support arbitrary frame conversions on the widths (which would be very subtle, and which are not needed for the present context), and access is only available from the ViImplementation2 interface (no VisBuffer2 accessor, as yet).  In ChannelAverageTVI, some adjustments made to make the bypass for the single-channel (degenerate) case in the getFrequencies and getChanWidths functions *not* depend on a call to visibilityShape() (which, in turn, depends on VI2 synchronization.  This permits access to effective frequency and width info (including when averaging) for any spectral window outside the VI2 iteration loops in applications.  (c++ unit tests for ChannelAverageTVI pending)
George Moellenbrock George Moellenbrock ece27617e4edc3bb09791f34c4215f9d6e34e399 ece27617e4edc3bb09791f34c4215f9d6e34e399 Merge branch 'master' into CAS-12735
George Moellenbrock George Moellenbrock 9a641f28e7e72bf0f0d6803665a7714053a2e576 m 9a641f28e7e72bf0f0d6803665a7714053a2e576 For CAS-12735, in Calibrater::genericGatherAndSolve, handle simdata_p=True case properly in Freq meta-data section so that c++ unit tests using SimpleSimVi2 will work properly (e.g., tCalibraterSolveSimData_GT); also added tests of FreqMetaData class to tVisCal_GT.cc
Neal Schweighart Neal Schweighart 6830d7c3fd649ad8166d153421f882dd08ed4787 m 6830d7c3fd649ad8166d153421f882dd08ed4787 Removed leftover caltables from new frequency meta tests
George Moellenbrock George Moellenbrock cd4c1083e3e9b0682a6f6980a95b977d31efe7f3 m cd4c1083e3e9b0682a6f6980a95b977d31efe7f3 For CAS-12735:  Added tests for gaincal freq meta data improvements, using existing data in DR. (No change to existing tests)

Jira issues

IssueDescriptionStatus
Unknown Issue TypeCAS-12735Could not obtain issue details from Jira