Build: #85 failed Changes by George Moellenbrock
Code commits
casa6
-
George Moellenbrock e91e35843d4f9dc0f7b51c238a90414011ec848b
Pull request #1032: CAS-14348
Merge in CASA/casa6 from CAS-14348 to master
* commit 'ca6131575d1f2743a010aa75f582a58f9eab1fcf':
Re-asserting that fringefit doesn't allow orphan timesteps
For CAS-14348:
Fixing the orphan timestep fringefit bug again
Turn off debugging output now I've tested the package built with it
Fixing fringefit on a single channel (again) and adding a test for it -
George Moellenbrock ca6131575d1f2743a010aa75f582a58f9eab1fcf m
Merge remote-tracking branch 'origin/CAS-14726' into CAS-14348 conflicts in FringeJones.cc, DelayRateFFT.cc fixed manually.
-
Des Small 93f24986e972db3e9803b9f76d350598311da10a m
Re-asserting that fringefit doesn't allow orphan timesteps
In a future release we should allow single time fringefit if not solving for delay, just as we allow single channel fringefit
when not solving for rate, but now is not the time. -
George Moellenbrock 921dfad4a8a14b6d9d98ac21e12f88989cc17db3 m
Merge branch 'master' into CAS-14348
-
George Moellenbrock 1b982bd657af81609f15651cdf0038301cd6a6f6 m
For CAS-14348:
1. In DelayRateFFT.cc's DelayRateFFTConcat class:
(a) Reordered working array (Vpad_) axes to put time and freq before corr and ant (Fortran order) so they are contiguous for 2d FFT;
(b) Introduced direct use of fftw (instead of LatticeFFT) thereby drastically improving performance of the FFT stage; by (mainly) avoiding unnecessary copies;
(c) Improved array slicing to streamline (unavoidable) data copies into the working array;
(d) Introduced Double precision weight sum accumulation (copied to Single precision at the end), and streamlined weight accumulation code to make it clearer;
(e) In snr calulation use amplitude found in searchPeak instead of relocating it via calculation from delay/rate solutions;
(f) Various other code clean-up and minor re-org.
2. In FringeJones.cc: Logging improvements for readability, and introduced fringefit stage solving time measurements and logging.
3. In Calibrater.cc: Occasionally (every ~10%) report solution count progress, and don't log useless solution quality stats for FringeJones (they are not yet filled correctly)- casatools/src/code/synthesis/MeasurementComponents/Calibrater.cc (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/DelayRateFFT.cc (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.cc (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.h (version 1b982bd657af81609f15651cdf0038301cd6a6f6) (diffs)
-
Des Small 749ab91d5875e60ee94fc139bb2b0e9acea50e04 m
Merge branch 'master' into CAS-14726
-
Des Small 040d518f901c10138314a2d4d1d9ce5c0417776e m
Fixing the orphan timestep fringefit bug again
-
Des Small fd0b2ba74d70b397ded8f269cbf5141549d6cbcd m
Turn off debugging output now I've tested the package built with it
-
Des Small 39f8d314f0617de8ad30a3b1f060993fcba169b2 m
Fixing fringefit on a single channel (again) and adding a test for it
- casatasks/tests/tasks/test_task_fringefit.py (version 39f8d314f0617de8ad30a3b1f060993fcba169b2) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/DelayRateFFT.cc (version 39f8d314f0617de8ad30a3b1f060993fcba169b2) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/DelayRateFFT.h (version 39f8d314f0617de8ad30a3b1f060993fcba169b2) (diffs)
- casatools/src/code/synthesis/MeasurementComponents/FringeJones.cc (version 39f8d314f0617de8ad30a3b1f060993fcba169b2) (diffs)