Build: #134 failed Changes by Srikrishna Sekhar
Code commits
casa6
-
Srikrishna Sekhar c8fbcb903aa6ea698105b4c563602221f862885b
Pull request #1103: CAS-12220
Merge in CASA/casa6 from CAS-12220 to master
* commit '038b0b720883dd412559c66c01a6b68cedb13177': (21 commits)
CAS-12220 : Fixed failing test(s)
CAS-12220 : Fix XML string escape
CAS-12220 : Add tests for psfmode=flat
CAS-12220 : Add AWP2 support for flatPSF
CAS-12220 : new psfmode argument in tclean.xml + cleanup
CAS-12220 : Fixes for AWP flatPSF path
CAS-12220 : Flat PSF for mosaic gridder
CAS-12220 : Revert fixes made on this branch
CAS-12220 : Cleanup some debug output
CAS-12220 : put back tclean skipped tests
CAS-12220 : Add flatPSF to AWProject gridders
cleaned some comments. restricted psf replacement only for mos, for testing purposes, added import imview to stk test
allow bypass for standard gridder for psf to work for A gridders only. re-enabled unit test for bwtaper
CAS-12220 : more edits to comments and prints
cube and mfs are working with standard psfs. but need to check tests and loadMosaicSensitivity
undid solution 1 of normalization corrections
CAS-12220 : Implemented separation of makePSF and makePB for multi-term. Tested for "mosaic" for the makeMosaicSensitivity. Still not working for AWP, but there is a workaround in the task code for this.
CAS-12220 : The double PSF generation is required only for mtmfs with awp/mos
CAS-12220 : Implemented psf-generation by standard gridder always, as a way to get spectral PSFs to be devoid of PB freq-dep.
One line commit to generate psf with only one PB
... -
Srikrishna Sekhar 038b0b720883dd412559c66c01a6b68cedb13177
Merge remote-tracking branch 'origin/master' into CAS-12220
-
Srikrishna Sekhar d462317a92a63fc8fd5ff5d84b54f65ac87e276e m
CAS-12220 : Fixed failing test(s)
The test failure was caused by an upstream change in the behaviour of
awp2. The PB value changed beyond tolerance in the test for this ticket.
The PB value itself need not be checked to assert the correctness of the
changes in this ticket, so I removed that compare so we don't fall into
this trap again.
All tests now pass locally. -
Takahiro Tsutsumi 536c47d1f8460ab9ce92a67ccd6a02d4d7e10ba5 m
Merge branch 'master' into CAS-12220
-
Srikrishna Sekhar b3f404f52ec16939257d2c17b580a5138e75a00f m
CAS-12220 : Fix XML string escape
An incorrect apostrophe mark was causing casashell to crash on startup. -
Srikrishna Sekhar f077ab0a485273baae4e9749aced911c0cf7edfb m
Merge remote-tracking branch 'origin/master' into CAS-12220
-
Srikrishna Sekhar 628e5a4a90422ce1df3d70fad4621abfa9024fa8 m
CAS-12220 : Add tests for psfmode=flat
Added a test class for the new PSF mode parameter since it is a
substantial change. The tests should cover most failure modes. -
Srikrishna Sekhar 9bf98eb4d70ac32fa3b6cf88916bd39605a78260 m
CAS-12220 : Add AWP2 support for flatPSF
AWP2 was previously gated-off because the flat PS CF kernel was being
over-written in-place by the A-term kernel, causing the flatPSF mode to
generate bit-identical PSF to the regular PSF mode.
This separates out the flat-PSF kernel from mosaic into it's own method,
and that has been hooked into AWP2.
There are still no unit tests to test this new mode, but local tests
seem to confirm that it's working (or at least not crashing...)- casatasks/xml/tclean.xml (version 9bf98eb4d70ac32fa3b6cf88916bd39605a78260) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version 9bf98eb4d70ac32fa3b6cf88916bd39605a78260) (diffs)
- casatools/src/code/synthesis/TransformMachines2/AWPLPG.cc (version 9bf98eb4d70ac32fa3b6cf88916bd39605a78260) (diffs)
- casatools/src/code/synthesis/TransformMachines2/MosaicFT.cc (version 9bf98eb4d70ac32fa3b6cf88916bd39605a78260) (diffs)
- casatools/src/code/synthesis/TransformMachines2/MosaicFT.h (version 9bf98eb4d70ac32fa3b6cf88916bd39605a78260) (diffs)
-
Srikrishna Sekhar 7d74987cc52b428f320d653a061a16ccf83cff8a m
CAS-12220 : new psfmode argument in tclean.xml + cleanup
Add a new "psfmode" argument within tclean that triggers the gridders to
use the flatPSF path, and complete the pipes all the way down into
SynthesisImager.
The old tclean.py hack has been removed in favour of the C++
code-changes.- casatasks/src/private/imagerhelpers/input_parameters.py (version 7d74987cc52b428f320d653a061a16ccf83cff8a) (diffs)
- casatasks/src/private/task_tclean.py (version 7d74987cc52b428f320d653a061a16ccf83cff8a) (diffs)
- casatasks/xml/tclean.xml (version 7d74987cc52b428f320d653a061a16ccf83cff8a) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version 7d74987cc52b428f320d653a061a16ccf83cff8a) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SynthesisUtilMethods.cc (version 7d74987cc52b428f320d653a061a16ccf83cff8a) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SynthesisUtilMethods.h (version 7d74987cc52b428f320d653a061a16ccf83cff8a) (diffs)
-
Srikrishna Sekhar ea2293389feea42ae39e57a6b953cbd13edc5510 m
CAS-12220 : Fixes for AWP flatPSF path
AWP was crashing with the previous flatPSF implementation,
this cleans up some old code and fixes the flatPSF path.
AWP2 is still unsupported with these fixes, that will be looked at later
on. It raises an error if flatpsf is used in conjuction with AWP2.- casatools/src/code/synthesis/TransformMachines2/AWProjectFT.cc (version ea2293389feea42ae39e57a6b953cbd13edc5510) (diffs)
- casatools/src/code/synthesis/TransformMachines2/AWProjectFT.h (version ea2293389feea42ae39e57a6b953cbd13edc5510) (diffs)
- casatools/src/code/synthesis/TransformMachines2/CFBuffer.cc (version ea2293389feea42ae39e57a6b953cbd13edc5510) (diffs)
-
Srikrishna Sekhar 11c165cab4f9a51b8db7da60993399856b92d198 m
CAS-12220 : Flat PSF for mosaic gridder
Add flat PSF gridding path for mosaic gridder. This keeps the visibility
and weight paths untouched. -
Srikrishna Sekhar 8ae9b3cd4092a11cccb77aa46c2553583a9c22d1 m
CAS-12220 : Revert fixes made on this branch
The gate was unnecessary because we don't have to use the flatPSF gate
for weight gridding. -
Srikrishna Sekhar 0e6a7da8abac86fa7a364e0cb367c0644eed17d2 m
CAS-12220 : Cleanup some debug output
- casatools/src/code/synthesis/ImagerObjects/SIImageStore.cc (version 0e6a7da8abac86fa7a364e0cb367c0644eed17d2) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStoreMultiTerm.cc (version 0e6a7da8abac86fa7a364e0cb367c0644eed17d2) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStoreMultiTerm.h (version 0e6a7da8abac86fa7a364e0cb367c0644eed17d2) (diffs)
- casatools/src/code/synthesis/TransformMachines2/MultiTermFTNew.cc (version 0e6a7da8abac86fa7a364e0cb367c0644eed17d2) (diffs)
-
Srikrishna Sekhar 94d676283f93402e8cb4891751bf6ff20ccfdf23 m
CAS-12220 : put back tclean skipped tests
The tests were erroneously unskipped in a previous commit -
Srikrishna Sekhar a477eb3cb6bebb2881bd92504a6805eae94b2396 m
CAS-12220 : Add flatPSF to AWProject gridders
Add plumbing to AWProjectFT and AWProjectWBFT to produce a PS-only CF to
grid only the PSF.
This is an attempt to clean up the python-layer hack that was used to
demonstrate the viability of this approach.
Add a new flatPSF_p toggle that sets PS-only gridding for the PSF for
AWP gridders (AWProject + AWP2). The control for this will flow from
tclean.xml but at the moment nothing sets it.
With this change, the PB is produced only when gridding the weights.- casatools/src/code/synthesis/TransformMachines2/AWProjectFT.cc (version a477eb3cb6bebb2881bd92504a6805eae94b2396) (diffs)
- casatools/src/code/synthesis/TransformMachines2/AWProjectFT.h (version a477eb3cb6bebb2881bd92504a6805eae94b2396) (diffs)
- casatools/src/code/synthesis/TransformMachines2/AWProjectWBFT.cc (version a477eb3cb6bebb2881bd92504a6805eae94b2396) (diffs)
-
Srikrishna Sekhar 669201125a64d15e4397febd9253b45a98f3383c m
Merge remote-tracking branch 'origin/master' into CAS-12220
-
Urvashi R._V. <rurvashi@aoc.nrao.edu> 32711bf6b866b0e1a337a0b66d1b6aab1f7837b7 m
cleaned some comments. restricted psf replacement only for mos, for testing purposes, added import imview to stk test
- casatasks/src/private/task_tclean.py (version 32711bf6b866b0e1a337a0b66d1b6aab1f7837b7) (diffs)
- casatests/stakeholder/test_stk_alma_pipeline_imaging.py (version 32711bf6b866b0e1a337a0b66d1b6aab1f7837b7) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version 32711bf6b866b0e1a337a0b66d1b6aab1f7837b7) (diffs)
-
Kumar Golap d76dd0abe61dfc5a3a50315e81a51b5c0ec76f5f m
allow bypass for standard gridder for psf to work for A gridders only. re-enabled unit test for bwtaper
-
Urvashi R._V. <rurvashi@aoc.nrao.edu> 94854a8f4efba2ea3fcc8bc0756c7fa01da53f11 m
CAS-12220 : more edits to comments and prints
- casatasks/src/private/task_tclean.py (version 94854a8f4efba2ea3fcc8bc0756c7fa01da53f11) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version 94854a8f4efba2ea3fcc8bc0756c7fa01da53f11) (diffs)
- casatools/src/code/synthesis/TransformMachines2/MultiTermFTNew.cc (version 94854a8f4efba2ea3fcc8bc0756c7fa01da53f11) (diffs)
-
Urvashi R._V. <rurvashi@aoc.nrao.edu> 02842ea5ae1fe89c6da4e0b659c60c49b683c097 m
cube and mfs are working with standard psfs. but need to check tests and loadMosaicSensitivity
- casatasks/src/private/task_tclean.py (version 02842ea5ae1fe89c6da4e0b659c60c49b683c097) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStore.cc (version 02842ea5ae1fe89c6da4e0b659c60c49b683c097) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStoreMultiTerm.cc (version 02842ea5ae1fe89c6da4e0b659c60c49b683c097) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStoreMultiTerm.h (version 02842ea5ae1fe89c6da4e0b659c60c49b683c097) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version 02842ea5ae1fe89c6da4e0b659c60c49b683c097) (diffs)
- casatools/src/code/synthesis/TransformMachines2/MultiTermFTNew.cc (version 02842ea5ae1fe89c6da4e0b659c60c49b683c097) (diffs)
-
Urvashi R._V. <rurvashi@aoc.nrao.edu> b504a14814df4e739c57f0f476d453d9036d13f2 m
undid solution 1 of normalization corrections
- casatools/src/code/synthesis/ImagerObjects/SIImageStore.cc (version b504a14814df4e739c57f0f476d453d9036d13f2) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStore.h (version b504a14814df4e739c57f0f476d453d9036d13f2) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStoreMultiTerm.cc (version b504a14814df4e739c57f0f476d453d9036d13f2) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStoreMultiTerm.h (version b504a14814df4e739c57f0f476d453d9036d13f2) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version b504a14814df4e739c57f0f476d453d9036d13f2) (diffs)
- casatools/src/code/synthesis/TransformMachines2/AWProjectFT.cc (version b504a14814df4e739c57f0f476d453d9036d13f2) (diffs)
- casatools/src/code/synthesis/TransformMachines2/MultiTermFTNew.cc (version b504a14814df4e739c57f0f476d453d9036d13f2) (diffs)
- casatools/src/code/synthesis/TransformMachines2/MultiTermFTNew.h (version b504a14814df4e739c57f0f476d453d9036d13f2) (diffs)
-
Urvashi R._V. <rurvashi@aoc.nrao.edu> f8ec653f1b6295a0a243eb6366b81d890e5c71a9 m
syncd with trunk
-
Urvashi R._V <rurvashi@aoc.nrao.edu> a8fe5d94019f50290c140841bcca6634aabafd71 m
CAS-12220 : Implemented separation of makePSF and makePB for multi-term. Tested for "mosaic" for the makeMosaicSensitivity. Still not working for AWP, but there is a workaround in the task code for this.
- casatasks/src/private/task_tclean.py (version a8fe5d94019f50290c140841bcca6634aabafd71) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version a8fe5d94019f50290c140841bcca6634aabafd71) (diffs)
- casatools/src/code/synthesis/TransformMachines2/AWProjectFT.cc (version a8fe5d94019f50290c140841bcca6634aabafd71) (diffs)
- casatools/src/code/synthesis/TransformMachines2/AWProjectWBFT.cc (version a8fe5d94019f50290c140841bcca6634aabafd71) (diffs)
- casatools/src/code/synthesis/TransformMachines2/MultiTermFTNew.cc (version a8fe5d94019f50290c140841bcca6634aabafd71) (diffs)
- casatools/src/code/synthesis/TransformMachines2/MultiTermFTNew.h (version a8fe5d94019f50290c140841bcca6634aabafd71) (diffs)
-
Urvashi R._V <rurvashi@aoc.nrao.edu> 04fe36bc3964d4947c6e71789056fdc841c24bc6 m
CAS-12220 : The double PSF generation is required only for mtmfs with awp/mos
-
Urvashi R._V <rurvashi@aoc.nrao.edu> 39b1c187d2db67f7ec4656434d27353063e7ee53 m
CAS-12220 : Implemented psf-generation by standard gridder always, as a way to get spectral PSFs to be devoid of PB freq-dep.
- casatasks/src/private/task_tclean.py (version 39b1c187d2db67f7ec4656434d27353063e7ee53) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStore.cc (version 39b1c187d2db67f7ec4656434d27353063e7ee53) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStoreMultiTerm.cc (version 39b1c187d2db67f7ec4656434d27353063e7ee53) (diffs)
- casatools/src/code/synthesis/TransformMachines2/AWProjectFT.cc (version 39b1c187d2db67f7ec4656434d27353063e7ee53) (diffs)
-
Preshanth Jagannathan 88c0856db60b1b13596e8dc2e23fc3557b5cfd34 m
One line commit to generate psf with only one PB
-
Urvashi R._V <rurvashi@aoc.nrao.edu> 5e60772e942613e97c9b845761e3361bf9962020 m
Merge branch 'master' into CAS-12220
-
Urvashi R._V <rurvashi@aoc.nrao.edu> 605aa896cde7f68f63d13eddeedb966d3014800f m
CAS-12220 : Divide the PB out of the PSF, for mosaic/awproject
- casatools/src/code/synthesis/ImagerObjects/SIImageStore.cc (version 605aa896cde7f68f63d13eddeedb966d3014800f) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStore.h (version 605aa896cde7f68f63d13eddeedb966d3014800f) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStoreMultiTerm.cc (version 605aa896cde7f68f63d13eddeedb966d3014800f) (diffs)
- casatools/src/code/synthesis/ImagerObjects/SIImageStoreMultiTerm.h (version 605aa896cde7f68f63d13eddeedb966d3014800f) (diffs)