Ville Suoranta 24 Jan 2019 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c

Revert "Merge pull request #836 in CASA/casa from CAS-11988 to master"
This reverts commit dfe43d8d0b1a5db075714c90b9ebebb19b9a2053, reversing
changes made to 81ca466bc3aba9e379151b421f3427f60842656d.

• code/mstransform/TVI/ChannelAverageTVI.cc (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/mstransform/TVI/ChannelAverageTVI.h (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/mstransform/TVI/ConvolutionTVI.cc (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/mstransform/TVI/FreqAxisTVI.cc (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/mstransform/TVI/FreqAxisTVI.h (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/mstransform/TVI/HanningSmoothTVI.cc (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/mstransform/TVI/PhaseShiftingTVI.cc (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/mstransform/TVI/RegriddingTVI.cc (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/mstransform/TVI/UVContSubTVI.cc (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/mstransform/TVI/test/tChannelAverageTVI.cc (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/mstransform/TVI/test/tChannelAverageTVI.h (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/msvis/CMakeLists.txt (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/msvis/MSVis/SimpleSimVi2.cc (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/msvis/MSVis/test/TestUtilsTVI.cc (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/msvis/MSVis/test/VisibilityIterator_Gtest.h (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/msvis/MSVis/test/VisibilityIterator_Test.cc (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/msvis/MSVis/test/VisibilityIterator_Test.h (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)
• code/msvis/MSVis/test/tViiLayerFactory_GT.cc (version 33ba9ddaa0dbf9c97866cf56bf8365a5c22c533c) (diffs)

Ville Suoranta 24 Jan 2019 fdbee15608deee950b0f8db711c0fdefda9309da

Merge pull request #837 in CASA/casa from bugfix/CAS-12203 to master
* commit '26cf1c25d80f07c940c8dba9f61991c276ab5afe': (69 commits)
  Updated regressions for merge of CAS-12203 with casa-master
  Updated regressions for merge of CAS-12203 with casa-master
  Revert "Modified the ic2233 regressios to updated values for the merge"
  Modified the ic2233 regressios to updated values for the merge
  Changed default for conjbeams to false in all places I could find (5 edits in three files; tclean.xml, synthesisimager{.xml,_cmpt.cc})
  Minor additions for the psterm parameter
  Added more information for the psterm parameter
  Simplified code in SynthesisImagerVi2::reloadCFCache().
  Re-start reloadCFCache() from Py and fixed the C++ code to work for FTMs that use CFCache mechanism.
  Some more minor changes to the doc.
  Modified test-values for regressions to pass + doc improvements in .xml.
  Typo corrections in the inline help text.
  Output of std::string.find() needs to be received in unsigned long (unsigned int works incorrectly, without a warning!).
  Output of std::string.find() needs to received in unsigned long (unsinged int works incorrectly, without warning!).
  getenv: Generalized construction of env. variable + changed precedence to env. variable first (then .casarc).
  getenv: Generalized construction of env. variable from .casarc variable + changed precedence to env. variables first (then .casarc).
  Resolved blank-line conflict.
  Added control via CFC_VERBOSE #define to control verbosity during CFC construction.
  Added WFUDGE getenv param.
  A temp. commit to make SDMaskHandler.cc compile.  The original code had SHARE_PTR which complier does not find. So replaced with std:shared_ptr.
  ...

Ville Suoranta 24 Jan 2019 1e6beb5c41599ffcfe4dbbb51e6c03611c6a17a7

Merge pull request #838 in CASA/casa from CAS-12209 to master
* commit '158b4a7cfc568953b0ab6c336988531c3a34c44e':
  CAS-12209 squash compiler warnings

Ville Suoranta 23 Jan 2019 dfe43d8d0b1a5db075714c90b9ebebb19b9a2053

Merge pull request #836 in CASA/casa from CAS-11988 to master
* commit '61b09c36d8c61a85310aa342d327b8f2eb8ab55b': (30 commits)
  Fix SPW output subtable if the number of channnels not divisible by chanbin
  Add unit test for SPWs fully averaged
  Use STL to copy container
  Add test for SPWs without averaging
  Allow setting the chanbin of second TVI in the fixture
  Adjust existing assocSpwId for the originally copied SPWs
  Add STL namespace: vector -> std::vector
  Add STL namespace: map -> std::map
  Fix remaining access to mutable var.
  Check SPW subtable when two ChannelAverageTVIs are concatenated and there is a MS selection
  Fix unit test with number of channels not divisible by chanbin
  Fix indentation
  Fix the unit tests after changing getChannels() from FreqAxisTVI
  Add test to check SPW subtable when number of channels is not divisible by chanbin
  Add unit test for the SPW subtable propagation
  Improve google test context message in case of failure
  Indent properly source file
  Add more variability in the generated synthetic MS
  Fix compiler warning
  Override nSpectralWindows()
  ...

preshanth jagannadhan <pjaganna@nemo.aoc.nrao.edu> 23 Jan 2019 26cf1c25d80f07c940c8dba9f61991c276ab5afe m

Updated regressions for merge of CAS-12203 with casa-master

• gcwrap/python/scripts/regressions/ic2233_regression.py (version 26cf1c25d80f07c940c8dba9f61991c276ab5afe) (diffs)

preshanth jagannadhan <pjaganna@nemo.aoc.nrao.edu> 23 Jan 2019 c4bdf47d0445f779b2ccd7b2999e35e0f4776078 m

Updated regressions for merge of CAS-12203 with casa-master

• gcwrap/python/scripts/regressions/ic2233_regression.py (version c4bdf47d0445f779b2ccd7b2999e35e0f4776078) (diffs)

preshanth jagannadhan <pjaganna@nemo.aoc.nrao.edu> 23 Jan 2019 7b7bb4f567592da77c96cddac8d29459ede0c52f m

Revert "Modified the ic2233 regressios to updated values for the merge"
This reverts commit 54133eb73f1988b3b6da593f14520346e8a32fb9.

• casacore (version 7b7bb4f567592da77c96cddac8d29459ede0c52f) (diffs)
• gcwrap/python/scripts/regressions/ic2233_regression.py (version 7b7bb4f567592da77c96cddac8d29459ede0c52f) (diffs)

preshanth jagannadhan <pjaganna@nemo.aoc.nrao.edu> 23 Jan 2019 54133eb73f1988b3b6da593f14520346e8a32fb9 m

Modified the ic2233 regressios to updated values for the merge

• casacore (version 54133eb73f1988b3b6da593f14520346e8a32fb9) (diffs)
• gcwrap/python/scripts/regressions/ic2233_regression.py (version 54133eb73f1988b3b6da593f14520346e8a32fb9) (diffs)

preshanth jagannadhan <pjaganna@nemo.aoc.nrao.edu> 22 Jan 2019 1d8c5fd492838606bf4bb06f13271941bba1b0fa m

Merge branch 'master' into bugfix/CAS-12203

David Mehringer <dmehring@earendil.local> 22 Jan 2019 158b4a7cfc568953b0ab6c336988531c3a34c44e m

CAS-12209 squash compiler warnings

• code/air_casawvr/casawvr/msgaintable.hpp (version 158b4a7cfc568953b0ab6c336988531c3a34c44e) (diffs)
• code/air_casawvr/src/apps/almaabs.hpp (version 158b4a7cfc568953b0ab6c336988531c3a34c44e) (diffs)
• code/air_casawvr/src/apps/dtdlcoeffs.hpp (version 158b4a7cfc568953b0ab6c336988531c3a34c44e) (diffs)
• code/air_casawvr/src/model_make.hpp (version 158b4a7cfc568953b0ab6c336988531c3a34c44e) (diffs)
• code/air_casawvr/src/model_water.hpp (version 158b4a7cfc568953b0ab6c336988531c3a34c44e) (diffs)

C. Enrique Garcia Dabo 21 Jan 2019 61b09c36d8c61a85310aa342d327b8f2eb8ab55b m

Merge branch 'feature/CAS-9679' into CAS-11988
 Conflicts solved:
        code/msvis/MSVis/test/tViiLayerFactory_GT.cc

C. Enrique Garcia Dabo 21 Jan 2019 c9f7d8646cdb3a42b7a0ef62edf5c0da4cd053f2 m

Merge branch 'master' into CAS-11988

preshanth jagannadhan <pjaganna@nemo.aoc.nrao.edu> 16 Jan 2019 8927af05d2c0052b93bc241068167653815e6b46 m

Merge branch 'bugfix/CAS-11940' into ARD-14

preshanth jagannadhan <pjaganna@nemo.aoc.nrao.edu> 16 Jan 2019 769f4cdde2b55bdb637dc7da4bd6ea8b9345a694 m

Merge changes for ARD-master to CASA-master

C. Enrique Garcia Dabo 28 Dec 2018 ea768b4d83391934680b27e51c72efd27c6022b9 m

Merge branch 'master' into CAS-11988

C. Enrique Garcia Dabo 28 Dec 2018 540718783e86c7257ad282ca9a85036db49527f9 m

Fix SPW output subtable if the number of channnels not divisible by chanbin
The frequencies and channel widths were incorrectly computed if
the number of channnels not divisible by chanbin.
This has been fixed and the unit test for not divisible case
has been expanded to do further checking on the frequencies and widths.
Fixes partially CAS-11988

• code/mstransform/TVI/ChannelAverageTVI.cc (version 540718783e86c7257ad282ca9a85036db49527f9) (diffs)
• code/mstransform/TVI/test/tChannelAverageTVI.cc (version 540718783e86c7257ad282ca9a85036db49527f9) (diffs)

C. Enrique Garcia Dabo 28 Dec 2018 07fc13231d189c895fbdf196b55006a75eee2b88 m

Add unit test for SPWs fully averaged
Fixes partially CAS-11988

• code/mstransform/TVI/test/tChannelAverageTVI.cc (version 07fc13231d189c895fbdf196b55006a75eee2b88) (diffs)

C. Enrique Garcia Dabo 28 Dec 2018 92c9ec96993eca5eb79b126c02a1289b1f733e7a m

Use STL to copy container
Fixes partially CAS-11988

• code/mstransform/TVI/test/tChannelAverageTVI.cc (version 92c9ec96993eca5eb79b126c02a1289b1f733e7a) (diffs)

C. Enrique Garcia Dabo 28 Dec 2018 ca21f516edfbd8766a2d98eb75f2e7c809ac0d29 m

Add test for SPWs without averaging
This adds a unit test to check for cases in which the chanbin
parameter specifies no averaging in some SPWs. The SPW subtable
is also properly tested.
Fixes partially CAS-11988

• code/mstransform/TVI/test/tChannelAverageTVI.cc (version ca21f516edfbd8766a2d98eb75f2e7c809ac0d29) (diffs)

C. Enrique Garcia Dabo 28 Dec 2018 2d625298a3937175ad7873df3481aa6bd5bce95c m

Allow setting the chanbin of second TVI in the fixture
The ChannelAverageTVISpwChannTest fixture now allows to set
the chanbin vector used in the second TVI rather than using
a hard-coded value. The default value is still hard-coded.
Fixes partially CAS-11988

• code/mstransform/TVI/test/tChannelAverageTVI.cc (version 2d625298a3937175ad7873df3481aa6bd5bce95c) (diffs)
• code/mstransform/TVI/test/tChannelAverageTVI.h (version 2d625298a3937175ad7873df3481aa6bd5bce95c) (diffs)

C. Enrique Garcia Dabo 28 Dec 2018 7b19876e0f8e311dd94ca0bd7a0ee2b3b042d136 m

Adjust existing assocSpwId for the originally copied SPWs
The original SPWs which have been copied verbatim could
hold SPWIds that have changed since they are now in different rows.
Fixes partially CAS-11988

• code/mstransform/TVI/ChannelAverageTVI.cc (version 7b19876e0f8e311dd94ca0bd7a0ee2b3b042d136) (diffs)

C. Enrique Garcia Dabo 17 Dec 2018 b6c597e4d211d20866fcaf601b7ad2d9d8804192 m

Add STL namespace: vector -> std::vector
Further changes needed due to CAS-12124
Fixes partially CAS-11988

• code/mstransform/TVI/FreqAxisTVI.h (version b6c597e4d211d20866fcaf601b7ad2d9d8804192) (diffs)

C. Enrique Garcia Dabo 17 Dec 2018 4f53c95b28dcf2d5f8e5c4fec8301b91c6220185 m

Add STL namespace: map -> std::map
Further changes needed due to CAS-12124
Fixes partially CAS-11988

• code/mstransform/TVI/FreqAxisTVI.h (version 4f53c95b28dcf2d5f8e5c4fec8301b91c6220185) (diffs)

C. Enrique Garcia Dabo 17 Dec 2018 932eb028a87e391a1f5b0bc1d895eaec55f4991c m

Merge branch 'master' into CAS-11988
 Conflicts due to CAS-12124 have been solved:
        code/mstransform/TVI/ChannelAverageTVI.h
        code/mstransform/TVI/FreqAxisTVI.h

C. Enrique Garcia Dabo 12 Dec 2018 1030411fccc658030fc991847762d3dcefdaf4ce m

Merge branch 'master' into CAS-11988

C. Enrique Garcia Dabo 11 Dec 2018 01684e9d02d0c9e52e453c1b31e4a2116c930129 m

Fix remaining access to mutable var.
Fixes partially CAS-11988

• code/mstransform/TVI/ChannelAverageTVI.cc (version 01684e9d02d0c9e52e453c1b31e4a2116c930129) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 cacedbe6ba576f0aa4b6ef65f9e8cfd589482a6f m

Check SPW subtable when two ChannelAverageTVIs are concatenated and there is a MS selection
Fixes partially CAS-11988

• code/mstransform/TVI/test/tChannelAverageTVI.cc (version cacedbe6ba576f0aa4b6ef65f9e8cfd589482a6f) (diffs)
• code/mstransform/TVI/test/tChannelAverageTVI.h (version cacedbe6ba576f0aa4b6ef65f9e8cfd589482a6f) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 2d4a38a6eeebe2a91dedfe0317a881cee373fc92 m

Fix unit test with number of channels not divisible by chanbin
Fixes partially CAS-11988

• code/mstransform/TVI/test/tChannelAverageTVI.cc (version 2d4a38a6eeebe2a91dedfe0317a881cee373fc92) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 c33a09f357162907d08d9053bf6d57904cef994d m

Fix indentation

• code/mstransform/TVI/ChannelAverageTVI.cc (version c33a09f357162907d08d9053bf6d57904cef994d) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 f94c5d35725b905be7e49d7da084aa3ea5f21d08 m

Fix the unit tests after changing getChannels() from FreqAxisTVI
The propagation of the SPW subtable has the side effect of
changing the output channel map, for which getChannels() had to be changed.
Additionally nSpectralWindows() in ChannelAverageTVI returns more SPWs
than before (basically the double, since the old ones are kept).

Those changes have to be reflected in the unit test expectations.

Fixes CAS-11988

• code/mstransform/TVI/test/tChannelAverageTVI.cc (version f94c5d35725b905be7e49d7da084aa3ea5f21d08) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 63f25972f40a5473d54ff37c4426fd203f6a55cc m

Add test to check SPW subtable when number of channels is not divisible by chanbin
Fixes partially CAS-11988

• code/mstransform/TVI/test/tChannelAverageTVI.cc (version 63f25972f40a5473d54ff37c4426fd203f6a55cc) (diffs)
• code/mstransform/TVI/test/tChannelAverageTVI.h (version 63f25972f40a5473d54ff37c4426fd203f6a55cc) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 33000d5b0452a1387b879565ab7b925a99ba3a22 m

Add unit test for the SPW subtable propagation
Fixes CAS-11988

• code/mstransform/TVI/test/tChannelAverageTVI.cc (version 33000d5b0452a1387b879565ab7b925a99ba3a22) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 5ec829cfeaccdd54fb3aa883bcaf5d166fb457df m

Improve google test context message in case of failure
Fixes partially CAS-11988

• code/mstransform/TVI/test/tChannelAverageTVI.cc (version 5ec829cfeaccdd54fb3aa883bcaf5d166fb457df) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 6e388517d4e9e565c5d004952a40a1f020ccdd43 m

Indent properly source file

• code/mstransform/TVI/ChannelAverageTVI.cc (version 6e388517d4e9e565c5d004952a40a1f020ccdd43) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 49a566538d22ffe517ebb5537e04bf32d2eea432 m

Add more variability in the generated synthetic MS
Fixes partially CAS-11988

• code/mstransform/TVI/test/tChannelAverageTVI.cc (version 49a566538d22ffe517ebb5537e04bf32d2eea432) (diffs)
• code/mstransform/TVI/test/tChannelAverageTVI.h (version 49a566538d22ffe517ebb5537e04bf32d2eea432) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 3078d0c5b069c54d049c1c46fb961b1e81ee0018 m

Fix compiler warning
Fixes partially CAS-11988

• code/mstransform/TVI/FreqAxisTVI.h (version 3078d0c5b069c54d049c1c46fb961b1e81ee0018) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 bcccde5fcaba3828ea08332aef8b3031e93d6711 m

Override nSpectralWindows()
The new SPW subtable contains now both the old and new SPWs.
Fixes partially CAS-11988

• code/mstransform/TVI/ChannelAverageTVI.h (version bcccde5fcaba3828ea08332aef8b3031e93d6711) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 5178157c31d4d90ea6b54080cdf1e3df78f9ff46 m

Leftover from the transition spwOutChanNumMap_p.at -> spwOutChanIdxMap_p
Fixes CAS-11988

• code/mstransform/TVI/ChannelAverageTVI.cc (version 5178157c31d4d90ea6b54080cdf1e3df78f9ff46) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 bf8a66b42060e2706e8ab3720802f811ca88717f m

Remove mutable keyword
It is not recommended to use the mutable keyword unless there
are good justifications for it. In this case it was even dangerous,
since std::map would silently create a new entry if the lookup of the key
fails. This change has actually revealed that this was the case
in the unit tests.

Fixes partially CAS-11988

• code/mstransform/TVI/ChannelAverageTVI.cc (version bf8a66b42060e2706e8ab3720802f811ca88717f) (diffs)
• code/mstransform/TVI/ChannelAverageTVI.h (version bf8a66b42060e2706e8ab3720802f811ca88717f) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 2ced308aad73c25296a898a592851ba90bd6dc17 m

Add option to keep the temporary directory setting an environmental variable
Setting CASA_TEST_KEEP_TEMP_DIR will keep the tests temporary
directories rather than deleting them in the destructor, which
is useful for unit test debugging.

Fixes partially CAS-11988

• code/msvis/MSVis/test/TestUtilsTVI.cc (version 2ced308aad73c25296a898a592851ba90bd6dc17) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 2bb340c9ad49019c2cef14ba472779e425745b61 m

Fix file indentation
Fixes partially CAS-11988

• code/mstransform/TVI/FreqAxisTVI.h (version 2bb340c9ad49019c2cef14ba472779e425745b61) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 ea02b36c440fdc428e9e90a1efa471cda612946f m

Deprecate spwOutChanNumMap_p and use more explicit spwInpChanIdxMap_p
The spwOutChanNumMap_p map contained the number of channels per
output SPW. The new spwInpChanIdxMap_p is more explicit, in the sense
that it also contains the list of channel indices. The number of channels
can still be accessed using the .size() method of the indices vector.

Fixes partially CAS-11988

• code/mstransform/TVI/ChannelAverageTVI.cc (version ea02b36c440fdc428e9e90a1efa471cda612946f) (diffs)
• code/mstransform/TVI/ConvolutionTVI.cc (version ea02b36c440fdc428e9e90a1efa471cda612946f) (diffs)
• code/mstransform/TVI/FreqAxisTVI.cc (version ea02b36c440fdc428e9e90a1efa471cda612946f) (diffs)
• code/mstransform/TVI/FreqAxisTVI.h (version ea02b36c440fdc428e9e90a1efa471cda612946f) (diffs)
• code/mstransform/TVI/HanningSmoothTVI.cc (version ea02b36c440fdc428e9e90a1efa471cda612946f) (diffs)
• code/mstransform/TVI/PhaseShiftingTVI.cc (version ea02b36c440fdc428e9e90a1efa471cda612946f) (diffs)
• code/mstransform/TVI/RegriddingTVI.cc (version ea02b36c440fdc428e9e90a1efa471cda612946f) (diffs)
• code/mstransform/TVI/UVContSubTVI.cc (version ea02b36c440fdc428e9e90a1efa471cda612946f) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 efa682f48e7f66916475d8980336e43b8a3c9f08 m

Add support for the propagation of the SPW subtable
The resetSubtables() function is responsible for
creating a new SPW tables based on the previous one and store it
as a class member. The new subtable can be retrieved by
upper TVI layers using the spectralWindowSubtablecols() method.

Fixes partially CAS-11988

• code/mstransform/TVI/ChannelAverageTVI.cc (version efa682f48e7f66916475d8980336e43b8a3c9f08) (diffs)
• code/mstransform/TVI/ChannelAverageTVI.h (version efa682f48e7f66916475d8980336e43b8a3c9f08) (diffs)

C. Enrique Garcia Dabo 11 Dec 2018 ff9d52de6b2592022e4611431e56dad7a41f47ac m

Fill more information in the SPW subtable.
Now also the frequencies, channel widths, resolutions and
effective bandwidths are filled. This is useful to test how
the TVIs propagate the subtables. In particular it has been
useful for the unit tests of ChannelAverageTVI

Fixes partillay CAS-11988

• code/msvis/MSVis/SimpleSimVi2.cc (version ff9d52de6b2592022e4611431e56dad7a41f47ac) (diffs)

Sanjay Bhatnagar <bhatnagar.sanjay@gmail.com> 01 Dec 2018 bc3328fd63222c19f1dd280dc7eb032fa519500d m

Changed default for conjbeams to false in all places I could find (5 edits in three files; tclean.xml, synthesisimager{.xml,_cmpt.cc})

• gcwrap/tasks/tclean.xml (version bc3328fd63222c19f1dd280dc7eb032fa519500d) (diffs)
• gcwrap/tools/synthesis/synthesisimager.xml (version bc3328fd63222c19f1dd280dc7eb032fa519500d) (diffs)
• gcwrap/tools/synthesis/synthesisimager_cmpt.cc (version bc3328fd63222c19f1dd280dc7eb032fa519500d) (diffs)

C. Enrique Garcia Dabo 29 Nov 2018 87360343c9066b1f18e28c1470f0f6008f5f486b m

Merge branch 'master' into CAS-11988

C. Enrique Garcia Dabo 29 Nov 2018 9291ece2e2bf943adaf59b613d8c698c425acaa2 m

Remove unnecessary mutable members
Fixes partially CAS-11988

• code/mstransform/TVI/ChannelAverageTVI.cc (version 9291ece2e2bf943adaf59b613d8c698c425acaa2) (diffs)
• code/mstransform/TVI/FreqAxisTVI.cc (version 9291ece2e2bf943adaf59b613d8c698c425acaa2) (diffs)
• code/mstransform/TVI/FreqAxisTVI.h (version 9291ece2e2bf943adaf59b613d8c698c425acaa2) (diffs)

Sanjay Bhatnagar <bhatnagar.sanjay@gmail.com> 17 Nov 2018 27a84bd8e093b7a07cf4cbd1dd782bc131ee6678 m

Minor additions for the psterm parameter

• gcwrap/tasks/tclean.xml (version 27a84bd8e093b7a07cf4cbd1dd782bc131ee6678) (diffs)

Sanjay Bhatnagar <bhatnagar.sanjay@gmail.com> 17 Nov 2018 5eccf7380dd4229817369dfcd0a7a306ce3551ee m

Added more information for the psterm parameter

• gcwrap/tasks/tclean.xml (version 5eccf7380dd4229817369dfcd0a7a306ce3551ee) (diffs)

C. Enrique Garcia Dabo 06 Nov 2018 04f24e2f7dca487f23657a5f07501b2f66523ec5 m

Base SubtableChangerTest on MsFactoryTVITester to reuse code
Fixes partially CAS-11988

• code/msvis/MSVis/test/tViiLayerFactory_GT.cc (version 04f24e2f7dca487f23657a5f07501b2f66523ec5) (diffs)

C. Enrique Garcia Dabo 06 Nov 2018 9f34c9a976cf86d40f265ef26915594c7a3ae6dd m

Merge branch 'feature/CAS-9679' into CAS-11988

C. Enrique Garcia Dabo 06 Nov 2018 8d21a5256bf6ad75ac53b93c8e46acdcc4051303 m

Merge branch 'CAS-11992' into CAS-11988

Sanjay Bhatnagar <bhatnagar.sanjay@gmail.com> 01 Nov 2018 cd90d7903f0ea69cf62f41a3b478d5f5ca8f2d96 m

Merge branch 'bugfix/CAS-11940' of https://open-bitbucket.nrao.edu/scm/casa/casa into bugfix/CAS-11940

Sanjay Bhatnagar 01 Nov 2018 c419dbe0b0ea79e992e1973a14ec307e37132909 m

Simplified code in SynthesisImagerVi2::reloadCFCache().

• code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version c419dbe0b0ea79e992e1973a14ec307e37132909) (diffs)

Sanjay Bhatnagar 31 Oct 2018 dbf50addcca883e7a42738c88bd565e19603ed4e m

Merge branch 'CppAWVR' into bugfix/CAS-11940 Bringing fix from CppAWVR for the reloadCFCache() problem.

Sanjay Bhatnagar 31 Oct 2018 755cab7498a7eef84366e5ce2156e1c172798dc5 m

Re-start reloadCFCache() from Py and fixed the C++ code to work for FTMs that use CFCache mechanism.

• code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version 755cab7498a7eef84366e5ce2156e1c172798dc5) (diffs)
• code/synthesis/TransformMachines2/AWProjectFT.cc (version 755cab7498a7eef84366e5ce2156e1c172798dc5) (diffs)
• code/synthesis/TransformMachines2/AWProjectFT.h (version 755cab7498a7eef84366e5ce2156e1c172798dc5) (diffs)
• code/synthesis/TransformMachines2/CFCache.cc (version 755cab7498a7eef84366e5ce2156e1c172798dc5) (diffs)
• code/synthesis/TransformMachines2/FTMachine.h (version 755cab7498a7eef84366e5ce2156e1c172798dc5) (diffs)
• code/synthesis/TransformMachines2/MultiTermFTNew.cc (version 755cab7498a7eef84366e5ce2156e1c172798dc5) (diffs)
• code/synthesis/TransformMachines2/MultiTermFTNew.h (version 755cab7498a7eef84366e5ce2156e1c172798dc5) (diffs)
• gcwrap/python/scripts/imagerhelpers/imager_parallel_continuum.py (version 755cab7498a7eef84366e5ce2156e1c172798dc5) (diffs)

C. Enrique Garcia Dabo 30 Oct 2018 63b96c66f4575abc87f6af3beaafd70bf4938c6c m

Remove obsolete VisibilityIterator_Test
All the tests performed as part of VisibilityIterator_Test are duplicated in
VisibilityIterator_Gtest.

Fixes partially CAS-11988

• code/msvis/CMakeLists.txt (version 63b96c66f4575abc87f6af3beaafd70bf4938c6c) (diffs)
• code/msvis/MSVis/test/VisibilityIterator_Gtest.h (version 63b96c66f4575abc87f6af3beaafd70bf4938c6c) (diffs)
• code/msvis/MSVis/test/VisibilityIterator_Test.cc (version 63b96c66f4575abc87f6af3beaafd70bf4938c6c) (diffs)
• code/msvis/MSVis/test/VisibilityIterator_Test.h (version 63b96c66f4575abc87f6af3beaafd70bf4938c6c) (diffs)

Sanjay Bhatnagar <bhatnagar.sanjay@gmail.com> 29 Oct 2018 9e3c0e25cebc345e3a2511d9548b2b6cc87075e8 m

Merge remote-tracking branch 'origin' into bugfix/CAS-11940
Conflicts:
        casacore

Sanjay Bhatnagar 29 Oct 2018 3b7952cd4e98b52a51cd91d940443f4e5a4c26df m

Some more minor changes to the doc.

• casacore (version 3b7952cd4e98b52a51cd91d940443f4e5a4c26df) (diffs)
• gcwrap/tasks/tclean.xml (version 3b7952cd4e98b52a51cd91d940443f4e5a4c26df) (diffs)

Sanjay Bhatnagar <bhatnagar.sanjay@gmail.com> 29 Oct 2018 ee90f3a98e5be7d7952e9efdc489623af0c5489d m

Modified test-values for regressions to pass + doc improvements in .xml.

• casacore (version ee90f3a98e5be7d7952e9efdc489623af0c5489d) (diffs)
• gcwrap/python/scripts/tests/test_refimager.py (version ee90f3a98e5be7d7952e9efdc489623af0c5489d) (diffs)
• gcwrap/tasks/tclean.xml (version ee90f3a98e5be7d7952e9efdc489623af0c5489d) (diffs)

Sanjay Bhatnagar 23 Oct 2018 f84a98e6dd27e7c392382a228d5b3d71ceac94fa m

Merge branch 'master' of https://open-bitbucket.nrao.edu/scm/casa/casa into ARD-master-sb

Sanjay Bhatnagar 16 Oct 2018 f8264ef16d37b7ea040d0727f2aea7ff00151f77 m

Typo corrections in the inline help text.

• gcwrap/tasks/tclean.xml (version f8264ef16d37b7ea040d0727f2aea7ff00151f77) (diffs)

Sanjay Bhatnagar 13 Oct 2018 0801a4e43969cf3f24e86ab9397ce8f6d0431b7c m

Output of std::string.find() needs to be received in unsigned long (unsigned int works incorrectly, without a warning!).

• code/synthesis/TransformMachines/Utils.cc (version 0801a4e43969cf3f24e86ab9397ce8f6d0431b7c) (diffs)
• code/synthesis/TransformMachines2/Utils.cc (version 0801a4e43969cf3f24e86ab9397ce8f6d0431b7c) (diffs)

Sanjay Bhatnagar 12 Oct 2018 2aa7417164159718fcddd2f80b0b4033bee9d8c8 m

Output of std::string.find() needs to received in unsigned long (unsinged int works incorrectly, without warning!).

• code/synthesis/TransformMachines/Utils.cc (version 2aa7417164159718fcddd2f80b0b4033bee9d8c8) (diffs)
• code/synthesis/TransformMachines2/Utils.cc (version 2aa7417164159718fcddd2f80b0b4033bee9d8c8) (diffs)

Sanjay Bhatnagar 12 Oct 2018 f4654033e9f66a24437ff5b6e4c409c8d9243658 m

getenv: Generalized construction of env. variable + changed precedence to env. variable first (then .casarc).

• code/synthesis/TransformMachines/Utils.cc (version f4654033e9f66a24437ff5b6e4c409c8d9243658) (diffs)
• code/synthesis/TransformMachines2/Utils.cc (version f4654033e9f66a24437ff5b6e4c409c8d9243658) (diffs)

Sanjay Bhatnagar 12 Oct 2018 843e635733c52a9e5fe09e7c8d6e772c2eaadc34 m

getenv: Generalized construction of env. variable from .casarc variable + changed precedence to env. variables first (then .casarc).

• code/synthesis/TransformMachines/Utils.cc (version 843e635733c52a9e5fe09e7c8d6e772c2eaadc34) (diffs)
• code/synthesis/TransformMachines2/Utils.cc (version 843e635733c52a9e5fe09e7c8d6e772c2eaadc34) (diffs)

Sanjay Bhatnagar 11 Oct 2018 815995456934a9b393b2d938ebf24b4175830f50 m

Merge branch 'master' of https://open-bitbucket.nrao.edu/scm/casa/casa into ARD-master-sb

Sanjay Bhatnagar 10 Oct 2018 440f83e2e6da30e2dea491e01476f5d7f32d330e m

Merge branch 'CppAWVR' of https://open-bitbucket.nrao.edu/scm/casa/casa into ARD-master-sb

Sanjay Bhatnagar 10 Oct 2018 cd34af47dda92eabeccc5165a8f0a8cf2e89e05f m

Resolved blank-line conflict.

• casacore (version cd34af47dda92eabeccc5165a8f0a8cf2e89e05f) (diffs)
• code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version cd34af47dda92eabeccc5165a8f0a8cf2e89e05f) (diffs)

Sanjay Bhatnagar 10 Oct 2018 6dd3103df2e93cfee28cccb78739e4dcdcc71495 m

Merge branch 'master' of https://open-bitbucket.nrao.edu/scm/casa/casa into ARD-master-sb

Sanjay Bhatnagar 09 Oct 2018 9288646b25d87219e54b7dac1f99142472455d54 m

Merge branch 'master' of https://open-bitbucket.nrao.edu/scm/casa/casa into CppAWVR

Sanjay Bhatnagar 05 Oct 2018 79fae9f0b04bf1652b428b937825e30675f2d0a0 m

Merge branch 'master' of https://open-bitbucket.nrao.edu/scm/casa/casa into CppAWVR

Sanjay Bhatnagar 04 Oct 2018 800351822e73480385fde65e9212215121173873 m

Added control via CFC_VERBOSE #define to control verbosity during CFC construction.

• code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version 800351822e73480385fde65e9212215121173873) (diffs)
• code/synthesis/TransformMachines2/CFCache.cc (version 800351822e73480385fde65e9212215121173873) (diffs)

Sanjay Bhatnagar 04 Oct 2018 4ce5f584d0ff374cb6cea45048cb5cb3e8eb9d1f m

Added WFUDGE getenv param.

• casacore (version 4ce5f584d0ff374cb6cea45048cb5cb3e8eb9d1f) (diffs)

Sanjay Bhatnagar 04 Oct 2018 c4d43976406e046fd6bee015da518b0867583a1a m

A temp. commit to make SDMaskHandler.cc compile.  The original code had SHARE_PTR which complier does not find. So replaced with std:shared_ptr.

• code/synthesis/ImagerObjects/SDMaskHandler.cc (version c4d43976406e046fd6bee015da518b0867583a1a) (diffs)

Sanjay Bhatnagar 04 Oct 2018 9ae278701d0b050cfcec5adc0441f10160b0c434 m

Added a #define in SIVi2 to control CFC verbosity.  CFC.cc sensitive to verbosity setting.

• code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version 9ae278701d0b050cfcec5adc0441f10160b0c434) (diffs)
• code/synthesis/TransformMachines2/CFCache.cc (version 9ae278701d0b050cfcec5adc0441f10160b0c434) (diffs)

Sanjay Bhatnagar 03 Oct 2018 af66124b4fc46accbc01556eb1901bd2aa184488 m

Merge branch 'master' into ARD-master-sb

Sanjay Bhatnagar 03 Oct 2018 6418198f596f7f9ef83428048024ba48d2f097ad m

Merge branch 'master' of https://open-bitbucket.nrao.edu/scm/casa/casa

Sanjay Bhatnagar 03 Oct 2018 f9446ad563046e31c74c85eb179ee5072d865602 m

Merge branch 'bugfix/CAS-9968' of https://open-bitbucket.nrao.edu/scm/casa/casa into ARD-master-sb

Sanjay Bhatnagar 03 Oct 2018 df9c36fcc184b4ab6dd4b0621c76cc9399663634 m

Merge branch 'bugfix/CAS-11367' of https://open-bitbucket.nrao.edu/scm/casa/casa into ARD-master-sb

Sanjay Bhatnagar 03 Oct 2018 2087a50c42efbb0af9767f1fbd48f0752647ee0a m

Merge branch 'master' of https://open-bitbucket.nrao.edu/scm/casa/casa into ARD-master-sb

Sanjay Bhatnagar 03 Oct 2018 c8c9e244bb0eb62ad8f4203499d1e1410dbc343c m

Merge branch 'ARD-master-sb' of https://open-bitbucket.nrao.edu/scm/casa/casa into ARD-master-sb

Sanjay Bhatnagar 03 Oct 2018 8a003b6af1c3c26236414ff9802cdb3e9a4ff0c5 m

Merge branch 'CppAWVR' into ARD-master-sb

Sanjay Bhatnagar 03 Oct 2018 cde962c92239c9dc673c21b1f38b561961d2237d m

Added WFUDGE parameter.

• code/synthesis/TransformMachines2/AWConvFunc.cc (version cde962c92239c9dc673c21b1f38b561961d2237d) (diffs)

Sanjay Bhatnagar 11 Sep 2018 3f52a93de6a84aa9938c6a2c8a4e0dc9b356f3e3 m

Merge branch 'CppAWVR' into ARD-master-sb

Sanjay Bhatnagar 11 Sep 2018 24d0ec81f2390e8db3fbfdc1d6ce03e54cbd304d m

SynthUtils::getenv() now sensitive to ENV variables. Changed other files to use Utils.h from TM2.

• code/synthesis/ImagerObjects/SIImageStore.cc (version 24d0ec81f2390e8db3fbfdc1d6ce03e54cbd304d) (diffs)
• code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version 24d0ec81f2390e8db3fbfdc1d6ce03e54cbd304d) (diffs)
• code/synthesis/ImagerObjects/SynthesisUtilMethods.cc (version 24d0ec81f2390e8db3fbfdc1d6ce03e54cbd304d) (diffs)
• code/synthesis/TransformMachines/Utils.cc (version 24d0ec81f2390e8db3fbfdc1d6ce03e54cbd304d) (diffs)
• code/synthesis/TransformMachines2/Utils.cc (version 24d0ec81f2390e8db3fbfdc1d6ce03e54cbd304d) (diffs)

Sanjay Bhatnagar 10 Sep 2018 b4c1b572daa074c20c732bdec08b9f64e7089bba m

Merge branch 'CppAWVR' into ARD-master-sb

Sanjay Bhatnagar 06 Sep 2018 e95decf58628be9181b6ed7a38874dc43e7a5241 m

Merge remote-tracking branch 'origin' into ARD-master-sb
Conflicts:
        code/synthesis/ImagerObjects/SIImageStore.cc
        code/synthesis/TransformMachines2/HetArrayConvFunc.cc
        code/synthesis/TransformMachines2/MultiTermFTNew.h
        gcwrap/python/scripts/imagerhelpers/input_parameters.py
        gcwrap/python/scripts/task_tclean.py

Sanjay Bhatnagar 06 Sep 2018 6bf9d7f03c1a2f300b0af4900550b29624591ccf m

Merge branch 'CppAWVR' of https://open-bitbucket.nrao.edu/scm/casa/casa into ARD-master-sb

Sanjay Bhatnagar 22 Aug 2018 134b9d829eed8e8f13b9d3f2ebc97a79deae9330 m

Set LAZYFILL=1 by default and fixed the counting of CFs for ProgressMeter (in AWCF.cc).

• code/synthesis/ImagerObjects/SynthesisImager.cc (version 134b9d829eed8e8f13b9d3f2ebc97a79deae9330) (diffs)
• code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version 134b9d829eed8e8f13b9d3f2ebc97a79deae9330) (diffs)
• code/synthesis/TransformMachines2/AWConvFunc.cc (version 134b9d829eed8e8f13b9d3f2ebc97a79deae9330) (diffs)

Sanjay Bhatnagar 22 Aug 2018 9b17cc07b4beb74eae4a25647baaa572efbcfc52 m

Set LAZYFILE=T by detault

• code/synthesis/ImagerObjects/SynthesisImager.cc (version 9b17cc07b4beb74eae4a25647baaa572efbcfc52) (diffs)

Sanjay Bhatnagar 22 Aug 2018 214bade07001f609d76d0fab464c57823894130b m

SI: Set LAZYFILL=T by default SN: Changes to make MT-MFS work with nterms=1 AWCF: Count the number of CFs correctly for ProgressMeter.

• code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version 214bade07001f609d76d0fab464c57823894130b) (diffs)
• code/synthesis/ImagerObjects/SynthesisNormalizer.cc (version 214bade07001f609d76d0fab464c57823894130b) (diffs)
• code/synthesis/TransformMachines2/AWConvFunc.cc (version 214bade07001f609d76d0fab464c57823894130b) (diffs)

Takahiro Tsutsumi 17 Aug 2018 3e196e617d4a6f77c3cf8f4ef306180634cc5bab m

Skip test_multifield_both_cube_diffshape, test_multifield_cube_mfs, and test_multifield_cube_mtmfs for parallel run

• gcwrap/python/scripts/tests/test_refimager.py (version 3e196e617d4a6f77c3cf8f4ef306180634cc5bab) (diffs)

Takahiro Tsutsumi 16 Aug 2018 064d1a5a7cf1bf9b4a643b579be1a0af656f29a5 m

Added the outlier parameter checks to disablow cube+mfs mixed mode

• gcwrap/python/scripts/imagerhelpers/input_parameters.py (version 064d1a5a7cf1bf9b4a643b579be1a0af656f29a5) (diffs)
• gcwrap/python/scripts/task_tclean.py (version 064d1a5a7cf1bf9b4a643b579be1a0af656f29a5) (diffs)

R. V. Urvashi <rurvashi@aoc.nrao.edu> 16 Aug 2018 777ab4f12754d7b4fd1eab60cca0c694f01136a7 m

CAS-11367 : Added verification test for mtmfs/nterms1 fix

• gcwrap/python/scripts/tests/test_refimager.py (version 777ab4f12754d7b4fd1eab60cca0c694f01136a7) (diffs)

R. V. Urvashi <rurvashi@aoc.nrao.edu> 16 Aug 2018 d1e432161b43388d7d845d82116d042d1248e7b4 m

CAS-11367 : Fixed a bug in parallel model prediction for deconvolver='mtmfs' and nterms=1

• code/synthesis/ImagerObjects/SynthesisNormalizer.cc (version d1e432161b43388d7d845d82116d042d1248e7b4) (diffs)

Sanjay Bhatnagar 16 Aug 2018 f97076824c000a1e883fd1a4329f47b6fdd8d179 m

Made detection of unsupported telescope an exception in AWPFT.cc Made log messages from POST to NORMAL1 when creating or loading the CFC.

• code/synthesis/TransformMachines2/AWProjectFT.cc (version f97076824c000a1e883fd1a4329f47b6fdd8d179) (diffs)
• code/synthesis/TransformMachines2/CFCache.cc (version f97076824c000a1e883fd1a4329f47b6fdd8d179) (diffs)

Takahiro Tsutsumi 07 Aug 2018 9ccfc3bc81877cab598493ea2bc3f3d9ad1dbeba m

Merge branch 'master' into bugfix/CAS-11367
Conflicts:
        code/synthesis/ImagerObjects/SDAlgorithmBase.cc
        gcwrap/python/scripts/imagerhelpers/imager_parallel_cube.py
        gcwrap/python/scripts/tests/test_refimager.py

Sanjay Bhatnagar 03 Aug 2018 797442520c2ce3dbb19d800ee98768124214e33f m

Set the pbshape to 2x2 pixes for isDryRun=True in fillConvFunction(). This reduces the run time for "blank" CF computations from hours to minutes.
This also required setting the ref. pixel in makeFTCoord() method to
be size of the CF buffer.  This should not be required, but it is.
The code in this method should be refactored and cleaned up soon.

• code/synthesis/TransformMachines2/AWConvFunc.cc (version 797442520c2ce3dbb19d800ee98768124214e33f) (diffs)

Sanjay Bhatnagar 03 Aug 2018 9cda3cedfaee6db05a495c69cfbce7c64e37a54e m

Commented out printing of "+" and "o" to indicate azimuthal a/symmetry of CFs.

• code/synthesis/TransformMachines2/AWVisResampler.cc (version 9cda3cedfaee6db05a495c69cfbce7c64e37a54e) (diffs)

Ville Suoranta 24 Jan 2019 d6f83c7ac0e45f64383a7ac3c41e09aab547dac9

Remove wget from OSX template
wget was added for packaged documentation. Documentation will not
bet packaged from 5.5 onwards.

• packaging/template/osx/CASA.app/Contents/Resources/wget (version d6f83c7ac0e45f64383a7ac3c41e09aab547dac9) (diffs)