Casa6

• 

  Federico Montesino Pouzols 28 Apr 2025 dbb0ae2c77f555d5d5d32a7d740b7226c3c6ceca

  Pull request #934: CAS-14509: Clone of CAS-13616 for CASA 6.6.6 (Pipeline2025): Add multi-field specification of phasecenter for task_phaseshift
  Merge in CASA/casa6 from CAS-14509 to release/6.6.6
  
  * commit 'd4905b1fa3af75095de70e621614f31847658308': (32 commits)
    update and extend tests for output center values in same frame as metadata, CAS-13616
    don't convert to J2000, write phasecenter vals using same frame as in the PHASE_DIR metadata, CAS-13616
    fix bug re empty phasecenter frame, add tests, CAS-13616
    clarify default phasecenter frame J2000, CAS-13616
    use typing.Tuple for Python 3.8, CAS-13616
    prefer f-strings to concats, CAS-13616
    more formatting and indentation fixes from code review, try to get rid of tabs, CAS-13616
    re-format with black, CAS-13616
    suggestions from code review, more type hints prevent small leak, CAS-13616
    fixes from code review, prevent small leak, CAS-13616
    improve wording, from code review, CAS-13616
    parse dicts, reorganize tvi config, shift depending on field, CAS-13616
    test cases with dict and field selection, share common output checks with other classes, CAS-13616
    check field subtable in all multified tests, check vis in unchanged fields, CAS-13616
    extend and reorganize output checks in phaseshift_test cases, CAS-13616
    check in/out FIELD subt, extend multified tests with better MS, CAS-13616
    fix _update_field_subt when single phasecenter and field selection used together, CAS-13616
    reduce tool try contexts and indentation levels, CAS-13616
    remove assumptions that break with reindexing off, CAS-13616
    remove duplicate phasecenter check, defer to TVI, CAS-13616
    ...
• 

  Federico Montesino Pouzols 26 Apr 2025 d4905b1fa3af75095de70e621614f31847658308

  Merge remote-tracking branch 'origin/release/6.6.6' into CAS-14509
• 

  Federico Montesino Pouzols 27 Jan 2025 093dcfc0567cac65c5c92d4300b8be3e5b5d6283 m

  update and extend tests for output center values in same frame as metadata, CAS-13616

  • casatasks/tests/tasks/test_task_phaseshift.py (version 093dcfc0567cac65c5c92d4300b8be3e5b5d6283) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 af884c78ee1fd77570a93af047f9ddf63b427c50 m

  don't convert to J2000, write phasecenter vals using same frame as in the PHASE_DIR metadata, CAS-13616

  • casatasks/src/private/task_phaseshift.py (version af884c78ee1fd77570a93af047f9ddf63b427c50) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 f17965b5fc419643a048b6ba151cc22533b2dabe m

  fix bug re empty phasecenter frame, add tests, CAS-13616

  • casatasks/src/private/task_phaseshift.py (version f17965b5fc419643a048b6ba151cc22533b2dabe) (diffs)
  • casatasks/tests/tasks/test_task_phaseshift.py (version f17965b5fc419643a048b6ba151cc22533b2dabe) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 ac9564555409ffffe2195a4ae03f3ce3f7aeeef0 m

  clarify default phasecenter frame J2000, CAS-13616

  • casatasks/xml/phaseshift.xml (version ac9564555409ffffe2195a4ae03f3ce3f7aeeef0) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 fa5d40b6dc282899174e72527d58dfaee2816bc9 m

  use typing.Tuple for Python 3.8, CAS-13616

  • casatasks/src/private/task_phaseshift.py (version fa5d40b6dc282899174e72527d58dfaee2816bc9) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 e1667f665845e32c957e38c75c5ad725d502e7b0 m

  prefer f-strings to concats, CAS-13616

  • casatasks/src/private/task_phaseshift.py (version e1667f665845e32c957e38c75c5ad725d502e7b0) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 c2de87ce355d22d07efbeeb7498168083a33d0fb m

  more formatting and indentation fixes from code review, try to get rid of tabs, CAS-13616

  • casatools/src/code/mstransform/TVI/PhaseShiftingTVI.cc (version c2de87ce355d22d07efbeeb7498168083a33d0fb) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 2674e9478852f7c1c56eed5490086f78805bec29 m

  re-format with black, CAS-13616

  • casatasks/src/private/task_phaseshift.py (version 2674e9478852f7c1c56eed5490086f78805bec29) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 364d7fd59a30f2cc7ddb2e2492995959172c22ff m

  suggestions from code review, more type hints prevent small leak, CAS-13616

  • casatasks/src/private/task_phaseshift.py (version 364d7fd59a30f2cc7ddb2e2492995959172c22ff) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 7b83400c0c94e4e960d6d79f5556785658c8ddb7 m

  fixes from code review, prevent small leak, CAS-13616

  • casatools/src/code/mstransform/TVI/PhaseShiftingTVI.cc (version 7b83400c0c94e4e960d6d79f5556785658c8ddb7) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 8addc4ce549c3be9b1642195b27ae2d966b23ae3 m

  improve wording, from code review, CAS-13616

  • casatasks/xml/phaseshift.xml (version 8addc4ce549c3be9b1642195b27ae2d966b23ae3) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 81e859fe895638f7d8f0e7f93512866da56d42ab m

  parse dicts, reorganize tvi config, shift depending on field, CAS-13616

  • casatools/src/code/mstransform/TVI/PhaseShiftingTVI.cc (version 81e859fe895638f7d8f0e7f93512866da56d42ab) (diffs)
  • casatools/src/code/mstransform/TVI/PhaseShiftingTVI.h (version 81e859fe895638f7d8f0e7f93512866da56d42ab) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 a5814c1c41dde9fbac926e465d48d0df63615fa4 m

  test cases with dict and field selection, share common output checks with other classes, CAS-13616

  • casatasks/tests/tasks/test_task_phaseshift.py (version a5814c1c41dde9fbac926e465d48d0df63615fa4) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 9a76bf588b4e02c273fc47ebf603350e42bc0319 m

  check field subtable in all multified tests, check vis in unchanged fields, CAS-13616

  • casatasks/tests/tasks/test_task_phaseshift.py (version 9a76bf588b4e02c273fc47ebf603350e42bc0319) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 4158cd948591628c6def34620d6e160bb3c627f2 m

  extend and reorganize output checks in phaseshift_test cases, CAS-13616

  • casatasks/tests/tasks/test_task_phaseshift.py (version 4158cd948591628c6def34620d6e160bb3c627f2) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 24cd495876aaa3db98590a5287ce0f30c56e89ae m

  check in/out FIELD subt, extend multified tests with better MS, CAS-13616

  • casatasks/tests/tasks/test_task_phaseshift.py (version 24cd495876aaa3db98590a5287ce0f30c56e89ae) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 a2f93e101063116fbe8164862c0e71fddd0edd82 m

  fix _update_field_subt when single phasecenter and field selection used together, CAS-13616

  • casatasks/src/private/task_phaseshift.py (version a2f93e101063116fbe8164862c0e71fddd0edd82) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 f39f1408cb8561826a1a8819fe076f959d771eba m

  reduce tool try contexts and indentation levels, CAS-13616

  • casatasks/src/private/task_phaseshift.py (version f39f1408cb8561826a1a8819fe076f959d771eba) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 ce46ad17c51b682b083b47df3ea7b71eacd77972 m

  remove assumptions that break with reindexing off, CAS-13616

  • casatasks/tests/tasks/test_task_phaseshift.py (version ce46ad17c51b682b083b47df3ea7b71eacd77972) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 bd81e17346287c7892bda53b00e359e017a7cfea m

  remove duplicate phasecenter check, defer to TVI, CAS-13616

  • casatasks/src/private/task_phaseshift.py (version bd81e17346287c7892bda53b00e359e017a7cfea) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 1c78e18730e32fabf62c8d5012d846c49e1dd77f m

  better error handling, split functions from task, CAS-13616

  • casatasks/src/private/task_phaseshift.py (version 1c78e18730e32fabf62c8d5012d846c49e1dd77f) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 4033fcd0f06be53b6afa6b923096f4235bed61da m

  dict phasecenter tests, error conditions, check field subt, task subfunctions, CAS-13616

  • casatasks/tests/tasks/test_task_phaseshift.py (version 4033fcd0f06be53b6afa6b923096f4235bed61da) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 45734dbf309486e8e4cd9bf2e69edfadfdce10d2 m

  compilation warnings - unneeded copies in iters, CAS-13616

  • casatools/src/code/mstransform/TVI/UVContSubResult.cc (version 45734dbf309486e8e4cd9bf2e69edfadfdce10d2) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 b4c010b2a88a9e7e93e08f7ec198700b3763dce3 m

  basic test case for multi-field phasecenter, CAS-13616

  • casatasks/tests/tasks/test_task_phaseshift.py (version b4c010b2a88a9e7e93e08f7ec198700b3763dce3) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 2e7632aa0c095cffe666f37c71c49b7f45834f16 m

  make test_datacol really test the happy path / with MODEL col, CAS-13616

  • casatasks/tests/tasks/test_task_phaseshift.py (version 2e7632aa0c095cffe666f37c71c49b7f45834f16) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 29847f89fb51daa577e3b8e86fecd3f6fcfeed6d m

  disable reindexing, pass tvi config dict as is, CAS-13616

  • casatasks/src/private/task_phaseshift.py (version 29847f89fb51daa577e3b8e86fecd3f6fcfeed6d) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 679f2a6e739b5c383aa3dfc4227fe74adaa6fbed m

  fix new-ish compilation warnings, CAS-13616

  • casatools/src/code/mstransform/TVI/UVContSubTVI.cc (version 679f2a6e739b5c383aa3dfc4227fe74adaa6fbed) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 2ae26f24d6902692e9596e5c92a54142ae686b98 m

  fix new-ish compilation warnings, CAS-13616

  • casatools/src/code/mstransform/MSTransform/MSTransformManager.cc (version 2ae26f24d6902692e9596e5c92a54142ae686b98) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 e63e9b865aa78a49bda0af4b3e93d4cd58c19a34 m

  removed unneeded class member, CAS-13616

  • casatools/src/code/mstransform/TVI/PhaseShiftingTVI.cc (version e63e9b865aa78a49bda0af4b3e93d4cd58c19a34) (diffs)
  • casatools/src/code/mstransform/TVI/PhaseShiftingTVI.h (version e63e9b865aa78a49bda0af4b3e93d4cd58c19a34) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 57c48b31a877526d0ae867044618b737dc3c4220 m

  param/phasecenter: try to fix indentation and paragraph spaces, CAS-13616

  • casatasks/xml/phaseshift.xml (version 57c48b31a877526d0ae867044618b737dc3c4220) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 0e431910c95c80155174eeb87855046b4678128c m

  remove CASA5/6 compatibilty leftovers, CAS-13616

  • casatasks/src/private/task_phaseshift.py (version 0e431910c95c80155174eeb87855046b4678128c) (diffs)
• 

  Federico Montesino Pouzols 27 Jan 2025 4c02b3d95d391e5bade0113e4784d9f6a5ca839e m

  param/phasecenter: description of new dict type, CAS-13616

  • casatasks/xml/phaseshift.xml (version 4c02b3d95d391e5bade0113e4784d9f6a5ca839e) (diffs)