Ville Suoranta 30 Oct 2020 853e1e5526138739b5e34361dc7fc50aadc1b614

Merge pull request #240 in CASA/casa6 from CAS-13214 to release/6.1.2
* commit 'fb07c5da2e32e387abcd01d67ab7f90500d2d3d3':
  For CAS-13214, activate tests in test_req_task_polcal.py that exercise VLASS polcal fixes.
  Changed the unittests_list email contact to George
  Fixed def suite function arguments and added the test to CMakeLists and unittests_list
  Fixed some of the test cases looking at wrong Dtrue table
  updated the polcal test to look at the new data in the repo
  edited some of the checks for the circular cases
  Added new polcal test. Will likely recieve more updates
  For 6.1.2 branch, revert size_t to uInt in call to ArrayLogical::partialNFalse calls for consistency with state of casacore.
  To fix the ALMA-specific problem noted in CAS-13179 (and CSV-3499):  For poltype='Xfparang+QU', avoid fully-flagged data segments (typically scans) flagging all supplied data segments; added good data segment counting and associated log message; added traps for insufficient data segments for linear (<3) and circular basis (<2) Xfparang+QU solves; updated tSolveDataBuffer_GT.cc unit test for SDBList::extendCrossHandBaselineFlags() to exercise the excessive flagging context.  Python-level unit tests pending.
  For CAS-13179, adjusted tDJones_GT to exercise newer guessPar signature, which caused this bug
  For CAS-13179, added missing DJones::guessPar (with corrDepFlags parameter) signature, which was neglected in CAS-695.

George Moellenbrock 28 Oct 2020 fb07c5da2e32e387abcd01d67ab7f90500d2d3d3

For CAS-13214, activate tests in test_req_task_polcal.py that exercise VLASS polcal fixes.

• casa5/gcwrap/python/scripts/tests/test_req_task_polcal.py (version fb07c5da2e32e387abcd01d67ab7f90500d2d3d3) (diffs)

Neal Schweighart 28 Oct 2020 0587bb619b31ae07415e815448e25743b02ec10a

Changed the unittests_list email contact to George

• casa5/gcwrap/python/scripts/tests/unittests_list.txt (version 0587bb619b31ae07415e815448e25743b02ec10a) (diffs)

Neal Schweighart 28 Oct 2020 dbe3a437ada2cd6ee91dd4156223f74a34f18748

Fixed def suite function arguments and added the test to CMakeLists and unittests_list

• casa5/gcwrap/python/scripts/tests/CMakeLists.txt (version dbe3a437ada2cd6ee91dd4156223f74a34f18748) (diffs)
• casa5/gcwrap/python/scripts/tests/test_req_task_polcal.py (version dbe3a437ada2cd6ee91dd4156223f74a34f18748) (diffs)
• casa5/gcwrap/python/scripts/tests/unittests_list.txt (version dbe3a437ada2cd6ee91dd4156223f74a34f18748) (diffs)
• casatasks/tests/tasks/test_req_task_polcal.py (version dbe3a437ada2cd6ee91dd4156223f74a34f18748) (diffs)

Neal Schweighart 27 Oct 2020 5a19faae048ac80843b2c0a465417e81ce761fcc

Fixed some of the test cases looking at wrong Dtrue table

• casa5/gcwrap/python/scripts/tests/test_req_task_polcal.py (version 5a19faae048ac80843b2c0a465417e81ce761fcc) (diffs)
• casatasks/tests/tasks/test_req_task_polcal.py (version 5a19faae048ac80843b2c0a465417e81ce761fcc) (diffs)

Neal Schweighart 27 Oct 2020 de4741cc3742b7b0d3cc89e4c054b083fe622e85

Added new polcal test. Will likely recieve more updates

• casa5/gcwrap/python/scripts/tests/test_req_task_polcal.py (version de4741cc3742b7b0d3cc89e4c054b083fe622e85) (diffs)
• casatasks/tests/tasks/test_req_task_polcal.py (version de4741cc3742b7b0d3cc89e4c054b083fe622e85) (diffs)

Neal Schweighart 27 Oct 2020 5bd10f92b14fa148d78b29a1eef672531ec033e3

updated the polcal test to look at the new data in the repo

• casa5/gcwrap/python/scripts/tests/test_req_task_polcal.py (version 5bd10f92b14fa148d78b29a1eef672531ec033e3) (diffs)
• casatasks/tests/tasks/test_req_task_polcal.py (version 5bd10f92b14fa148d78b29a1eef672531ec033e3) (diffs)

Neal Schweighart 27 Oct 2020 f2baf92d93e2debbdab64f11fb178500b796d7dc

edited some of the checks for the circular cases

• casa5/gcwrap/python/scripts/tests/test_req_task_polcal.py (version f2baf92d93e2debbdab64f11fb178500b796d7dc) (diffs)
• casatasks/tests/tasks/test_req_task_polcal.py (version f2baf92d93e2debbdab64f11fb178500b796d7dc) (diffs)

George Moellenbrock 12 Oct 2020 386e27e09e90bc8000d1382d09a43bc459b82947

For 6.1.2 branch, revert size_t to uInt in call to ArrayLogical::partialNFalse calls for consistency with state of casacore.

• casa5/code/synthesis/MeasurementComponents/SolveDataBuffer.cc (version 386e27e09e90bc8000d1382d09a43bc459b82947) (diffs)

George Moellenbrock 08 Oct 2020 e96b0db6bd3320e1e50bb8978a481301faf6b51c

To fix the ALMA-specific problem noted in CAS-13179 (and CSV-3499):  For poltype='Xfparang+QU', avoid fully-flagged data segments (typically scans) flagging all supplied data segments; added good data segment counting and associated log message; added traps for insufficient data segments for linear (<3) and circular basis (<2) Xfparang+QU solves; updated tSolveDataBuffer_GT.cc unit test for SDBList::extendCrossHandBaselineFlags() to exercise the excessive flagging context.  Python-level unit tests pending.

• casa5/code/synthesis/MeasurementComponents/SolveDataBuffer.cc (version e96b0db6bd3320e1e50bb8978a481301faf6b51c) (diffs)
• casa5/code/synthesis/MeasurementComponents/SolveDataBuffer.h (version e96b0db6bd3320e1e50bb8978a481301faf6b51c) (diffs)
• casa5/code/synthesis/MeasurementComponents/XJones.cc (version e96b0db6bd3320e1e50bb8978a481301faf6b51c) (diffs)
• casa5/code/synthesis/MeasurementComponents/test/tSolveDataBuffer_GT.cc (version e96b0db6bd3320e1e50bb8978a481301faf6b51c) (diffs)

George Moellenbrock 08 Oct 2020 52c1861c3e2d0bd9c2a6e819e2d8f2e871d6f8f3

For CAS-13179, adjusted tDJones_GT to exercise newer guessPar signature, which caused this bug

• casa5/code/synthesis/MeasurementComponents/test/tDJones_GT.cc (version 52c1861c3e2d0bd9c2a6e819e2d8f2e871d6f8f3) (diffs)

George Moellenbrock 08 Oct 2020 d3fd982a3eb330fad0ed531bae7faa2cceb1e479

For CAS-13179, added missing DJones::guessPar (with corrDepFlags parameter) signature, which was neglected in CAS-695.

• casa5/code/synthesis/MeasurementComponents/DJones.cc (version d3fd982a3eb330fad0ed531bae7faa2cceb1e479) (diffs)
• casa5/code/synthesis/MeasurementComponents/DJones.h (version d3fd982a3eb330fad0ed531bae7faa2cceb1e479) (diffs)

Akeem Wells 28 Oct 2020 922301200113d4b241825e9a6cfa25a078d26911

Merge pull request #138 in CASA/casa-pkg from CAS-13188 to master
* commit '1ff281e1d5dc711db8166abd0986eb87c49592d5':
  Remove test 3415_CALTABCONVERT. Task CALTABCONVERT was deprecated

Akeem Wells <awells@humite.local> 28 Oct 2020 1ff281e1d5dc711db8166abd0986eb87c49592d5

Remove test 3415_CALTABCONVERT. Task CALTABCONVERT was deprecated

• testing/pybot-accepted/3415_CALTABCONVERT.html (version 1ff281e1d5dc711db8166abd0986eb87c49592d5) (diffs)

Akeem Wells 27 Oct 2020 5131b12a34d56b4a0353401a25f267346080038d

Merge pull request #137 in CASA/casa-pkg from CAS-13231 to master
* commit '842b8a660c31b080bcad5aaca7c976292e05faa6':
  Now that accum has been deprecated we need to remove it from the regression list of casa5

Akeem Wells <awells@humite.local> 27 Oct 2020 842b8a660c31b080bcad5aaca7c976292e05faa6

Now that accum has been deprecated we need to remove it from the regression list of casa5

• testing/pybot-accepted/8315_ACCUM_TEST.html (version 842b8a660c31b080bcad5aaca7c976292e05faa6) (diffs)

Ville Suoranta 07 Oct 2020 2d655461493b4dcfcf86b7bc11f6868eb68094d3

Update pr scripts to Casa6

• pullrequestparser/src/main/groovy/edu/nrao/pullrequestparser/Pullrequestparser2.groovy (version 2d655461493b4dcfcf86b7bc11f6868eb68094d3) (diffs)
• pullrequestparser/src/main/groovy/edu/nrao/pullrequestparser/getpullrequests.sh (version 2d655461493b4dcfcf86b7bc11f6868eb68094d3) (diffs)