Code commits
Casa6
-
Ville Suoranta 7fb4328ff74b9183431d52a8f0d8153c9fb49d2e
Merge pull request #116 in CASA/casa6 from CAS-12617 to master
* commit 'ec8ba59192386e8e309c53a70e3911f2a2cc05e8': (57 commits)
docs about default value
CAS-12617 : Added one more sub-test to cover a missing combination of modes
made the env.variable edits happen only for serial and not parallel
CAS-12617 : Set parallel=self.parallel in the test_hetarray tclean calls so that it actually goes in parallel....
Turned on hetarray test suite
CAS-12617 : Set/reset env variables. Remove a debug/print statement. Copied test_tclean from casa5 to casa6 trees.
CAS-12617 : Added two new tests for heterogenous pointing corrections. Currently disabled (in the suite definition) because the data isn't in the repo yet.
CAS-12617 : Another edit to allow the blank default to work for usepointing=True, but with no heterogenous offsets (i.e. same as casa 5.6)
Fixing VB2CFBMap.h to default sigmaDev to be a zero float vector of size 2
Parameter enforcing of the pointingoffsetsigdev internally within VB2CFBMap
For CAS-12617, changed the default of the new parameter to be an empty array []
CAS-12617 : bug fix for pointing offset read indexing
For CAS-12617, editing both copies of input_parameters.py
For CAS-12617, copied python code from casa5 to casa6 areas.
Interface and log changes for CAS-12617 to get all test_tclean tests to pass
chg: To reduce the checking for the maxCFShape change
chg: CFBuffer.cc to cache the maxCFShape value to reduce repeated reading of the buffer. Destructor timer reporting in VB2CFBMap.h
chg: To pass a reference instead of assigning the pointing offset vector in baselineType.cc. This allows for the parallel run to work. chg: In VB2CFBMap explicitly checking array sizes to avoid parallel run failure of recompute
chg: Checks for the second sigmaDev parameters only for antenna change in each VB. The units have been fixed in the checking and reporting of the increment. dev: A function to write a V<V<d>> from a v<v<d>> in BaselineType
chg: tAWPFTM to initialize AWPWBFTNew properly
... -
Sandra Castro 2e87e56b1bc64e1c905ab75b4ee94228a2b6b08c
Merge pull request #115 in CASA/casa6 from CAS-12913 to master
* commit '2308d678dec0b4484719843af9d2841f3a592dcf':
fix to workaround bug in componentlist images
updatest so bamboo tests will pass
fix test bug
rename test scripts
updates to componentlistimage req tests
updated files for componentlistimage tests
rename test script -
R. V. Urvashi <rurvashi@aoc.nrao.edu> ec8ba59192386e8e309c53a70e3911f2a2cc05e8 m
docs about default value
-
David Mehringer 2308d678dec0b4484719843af9d2841f3a592dcf m
fix to workaround bug in componentlist images
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> d4ea6ef81a3523709fe57e585de624d8efc623d3 m
Merge branch 'master' into CAS-12617 Resolve conflict in test_tclean.py : another ticket added another test suite and so does this branch.... modified the names in the list. Fixed xml problem
-
David Mehringer 5c91924ca077a7899502d57437362f8adaeb3d9e m
updatest so bamboo tests will pass
-
David Mehringer d926ab5fb5be897060d9f1a9122061073f8b1082 m
fix test bug
-
David Mehringer d3017fb30ff4fb696ee36388160ac6ffe788bd62 m
rename test scripts
- casa5/gcwrap/python/scripts/tests/CMakeLists.txt (version d3017fb30ff4fb696ee36388160ac6ffe788bd62) (diffs)
- casa5/gcwrap/python/scripts/tests/test_req_tool_componentlistimage.py (version d3017fb30ff4fb696ee36388160ac6ffe788bd62) (diffs)
- casatools/tests/tools/image/test_req_tool_componentlistimage.py (version d3017fb30ff4fb696ee36388160ac6ffe788bd62) (diffs)
-
David Mehringer 0dc5c4823b04b733f243ac8fa1784be391ac173c m
Merge branch 'master' into CAS-12913
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> 656b810f9e5683390e1e479cf9aaabcf9dd6bbb5 m
CAS-12617 : Added one more sub-test to cover a missing combination of modes
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> 92ba9ec149d6401573855f220cfafa5a0445bc0b m
Merge branch 'master' into CAS-12617
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> 63c0549672deb9bcb4554be2cce49129f6f22588 m
Merge branch 'master' into CAS-12617
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> 45c6f469e52e395f6a33b0233d795323363b526b m
made the env.variable edits happen only for serial and not parallel
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> 22137c7494026339d068143aa7c4768d62114b42 m
CAS-12617 : Set parallel=self.parallel in the test_hetarray tclean calls so that it actually goes in parallel....
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> 0fb37b6387d96ce6af6c09dd2bf6132a9f3cfc23 m
Merge branch 'master' into CAS-12617
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> a8076223f773b38aa2216c2fc7fb2b0cad42f6b3 m
Turned on hetarray test suite
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> d63d196a4828be69b904b516ce537eb3054ae119 m
CAS-12617 : Set/reset env variables. Remove a debug/print statement. Copied test_tclean from casa5 to casa6 trees.
- casa5/code/synthesis/TransformMachines2/PointingOffsets.h (version d63d196a4828be69b904b516ce537eb3054ae119) (diffs)
- casa5/gcwrap/python/scripts/tests/test_tclean.py (version d63d196a4828be69b904b516ce537eb3054ae119) (diffs)
- casatasks/tests/tasks/test_tclean.py (version d63d196a4828be69b904b516ce537eb3054ae119) (diffs)
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> 91269ea6d7555884e2c248da765bb17e0c2efaf4 m
CAS-12617 : Added two new tests for heterogenous pointing corrections. Currently disabled (in the suite definition) because the data isn't in the repo yet.
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> 9c8343d774b806b89cdb223110dd1608c4ab48db m
CAS-12617 : Another edit to allow the blank default to work for usepointing=True, but with no heterogenous offsets (i.e. same as casa 5.6)
-
Preshanth Jagannathan 36364896abef05b8287478a7a2cfc3cd3cbcaece m
Fixing VB2CFBMap.h to default sigmaDev to be a zero float vector of size 2
-
Preshanth Jagannathan edc3f798c124d7ee2177b212a74a004aefce2645 m
Parameter enforcing of the pointingoffsetsigdev internally within VB2CFBMap
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> 4568bb143cf914954fbe2c7bd7cb9667fb0fa835 m
For CAS-12617, changed the default of the new parameter to be an empty array []
-
David Mehringer f66669de1f9bbb65ef8dbb9d1a95cda7a05efc2e m
updates to componentlistimage req tests
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> ff757030b72e653d4c241332708d1d2b4b44b3c4 m
Merge branch 'master' into CAS-12617
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> eb8e2e8d145abaa97262452666f7a74015f852ab m
Merge branch 'master' into CAS-12617
-
David Mehringer 2d3f84e4195af2dca2ec0bf3d5e143f302b0a2b9 m
updated files for componentlistimage tests
-
David Mehringer 4662ca987b6479d55f26f5bfa648ecfc0119488e m
rename test script
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> 33260febfa9101364685cb8992c15f77ba66a7aa m
CAS-12617 : bug fix for pointing offset read indexing
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> 98672cf9df08f32a0b9eadfd506c894e670f3edb m
For CAS-12617, editing both copies of input_parameters.py
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> 85f5b13ba07ac64b25252c108ccdc01559d19d70 m
For CAS-12617, copied python code from casa5 to casa6 areas.
-
R. V. Urvashi <rurvashi@aoc.nrao.edu> 5249766d1e81bfe9acb39405a62cd5c9d1c1fdc7 m
Interface and log changes for CAS-12617 to get all test_tclean tests to pass
- casa5/code/synthesis/ImagerObjects/SynthesisUtilMethods.cc (version 5249766d1e81bfe9acb39405a62cd5c9d1c1fdc7) (diffs)
- casa5/code/synthesis/TransformMachines2/VB2CFBMap.cc (version 5249766d1e81bfe9acb39405a62cd5c9d1c1fdc7) (diffs)
- casa5/gcwrap/python/scripts/task_tclean.py (version 5249766d1e81bfe9acb39405a62cd5c9d1c1fdc7) (diffs)
- casa5/gcwrap/tasks/tclean.xml (version 5249766d1e81bfe9acb39405a62cd5c9d1c1fdc7) (diffs)
-
Preshanth Jagannathan 9c262cee35dcb35212c1f8100820a89274cb3606 m
Merge branch 'master' into CAS-12617
-
Preshanth Jagannathan 4ba79afed3b2a327e58c8a050ae9cb7a06b99f87 m
Merge branch 'master' into CAS-12617
-
Preshanth Jagannathan 57ab2bc54ac5211f61e225a29f851f45f5bc5e40 m
Merge branch 'master' into CAS-12617
-
Preshanth Jagannathan 44ce8743c56d4e9b6ea4cb36b6bc8caec88d5cd3 m
Merge remote-tracking branch 'casa5-upstream/CAS-12617' into CAS-12617
-
Preshanth Jagannathan 65425a39afa1e19951ef22413390e8757d61bf55 m
chg: To reduce the checking for the maxCFShape change
- code/synthesis/TransformMachines2/PhaseGrad.cc (version 65425a39afa1e19951ef22413390e8757d61bf55) (diffs)
- code/synthesis/TransformMachines2/PhaseGrad.h (version 65425a39afa1e19951ef22413390e8757d61bf55) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version 65425a39afa1e19951ef22413390e8757d61bf55) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.h (version 65425a39afa1e19951ef22413390e8757d61bf55) (diffs)
-
Preshanth Jagannathan 2374a6f884b1a3d0dc4285dc7bb1759343c3ebda m
chg: CFBuffer.cc to cache the maxCFShape value to reduce repeated reading of the buffer. Destructor timer reporting in VB2CFBMap.h
-
Preshanth Jagannathan b0735af8848847d1652b752eb396a09cb7b96f64 m
chg: To pass a reference instead of assigning the pointing offset vector in baselineType.cc. This allows for the parallel run to work. chg: In VB2CFBMap explicitly checking array sizes to avoid parallel run failure of recompute
-
Preshanth Jagannathan 00a3f24fc59d423c6aa50107c8d8be0b8a8126e9 m
chg: Checks for the second sigmaDev parameters only for antenna change in each VB. The units have been fixed in the checking and reporting of the increment. dev: A function to write a V<V<d>> from a v<v<d>> in BaselineType
- code/synthesis/TransformMachines2/BaselineType.cc (version 00a3f24fc59d423c6aa50107c8d8be0b8a8126e9) (diffs)
- code/synthesis/TransformMachines2/BaselineType.h (version 00a3f24fc59d423c6aa50107c8d8be0b8a8126e9) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version 00a3f24fc59d423c6aa50107c8d8be0b8a8126e9) (diffs)
-
Preshanth Jagannathan 2e1156bcd67711372776eeba30dac3f6f49e051e m
chg: tAWPFTM to initialize AWPWBFTNew properly
-
Preshanth Jagannathan 87a4f2b1085b7bcf88e096cad0d88190693fe0d8 m
chg: floatArray checking which was failing to doubleArray
-
Preshanth Jagannathan fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f m
The changes to the files are to ensure that pointingOffsetSigDev parameter is an array of float. This required that in tclean.xml that it be an intArray or a doubleArray for the parameter checking.
- code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- code/synthesis/ImagerObjects/SynthesisImagerVi2.h (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- code/synthesis/ImagerObjects/SynthesisUtilMethods.cc (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- code/synthesis/ImagerObjects/SynthesisUtilMethods.h (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- code/synthesis/TransformMachines2/AWProjectFT.cc (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- code/synthesis/TransformMachines2/AWProjectFT.h (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- code/synthesis/TransformMachines2/AWProjectWBFT.cc (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- code/synthesis/TransformMachines2/AWProjectWBFT.h (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- code/synthesis/TransformMachines2/AWProjectWBFTNew.h (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- code/synthesis/TransformMachines2/BaselineType.cc (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.h (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- gcwrap/python/scripts/imagerhelpers/input_parameters.py (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- gcwrap/python/scripts/task_tclean.py (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- gcwrap/tasks/tclean.xml (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- gcwrap/tools/synthesis/synthesisimager.xml (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
- gcwrap/tools/synthesis/synthesisimager_cmpt.cc (version fcf9236bfc7a9e0f0d5df2a5e194c75f1b9ec70f) (diffs)
-
Preshanth Jagannathan c0b1b39666653412598d9bc29d032648709ec7fd m
Fix to ensure that tAWPFTM passes with the current usepointing=True setup. This invovled explicitly setting the oversampling after the PointingOffset object was instantiated. The removal of the AWConvFunc setPointingOffsets call which is not longer required.
-
Preshanth Jagannathan 5f11f48da69a85cba60b009b8d50ac601602fbde m
Fixing the PhaseGrad computation for a doPointing=False.
-
Preshanth Jagannathan 2a1df96a0978ac46cda3bbbefbd4a5833b5f1b2f m
Merge branch 'ARD-23-fix' into CAS-12617
-
Preshanth Jagannathan 901a9db25c7f51346dd78790e6bc18cba1581831 m
chg: Code cleanup and removal of excessive print messages and compiler warnings
- code/synthesis/TransformMachines2/BaselineType.cc (version 901a9db25c7f51346dd78790e6bc18cba1581831) (diffs)
- code/synthesis/TransformMachines2/PhaseGrad.cc (version 901a9db25c7f51346dd78790e6bc18cba1581831) (diffs)
- code/synthesis/TransformMachines2/PhaseGrad.h (version 901a9db25c7f51346dd78790e6bc18cba1581831) (diffs)
- code/synthesis/TransformMachines2/PointingOffsets.cc (version 901a9db25c7f51346dd78790e6bc18cba1581831) (diffs)
-
Sanjay Bhatnagar def6275d4866a0fafd9a92420b0e5cda7f83a9f1 m
Chg: Change in the ostr in BaselineType.cc
-
Preshanth Jagannathan a4f1b6a16119fa16c261f8ad0bc8140e99814725 m
Fix to ensure that the compute is triggered only once. It required that the flags be reset after compute.
- code/synthesis/TransformMachines2/BaselineType.cc (version a4f1b6a16119fa16c261f8ad0bc8140e99814725) (diffs)
- code/synthesis/TransformMachines2/PhaseGrad.cc (version a4f1b6a16119fa16c261f8ad0bc8140e99814725) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version a4f1b6a16119fa16c261f8ad0bc8140e99814725) (diffs)
-
Preshanth Jagannathan 6dc7a5fc4f1ccaaf813af4069622ef6fe881b26a m
Commented out a difference calculation in gridding by mistake. Have reverted the commenting out of diffAntPointing_l initialization.
-
Preshanth Jagannathan 20a206a51ea168fa39fee011a5c1600e1d052663 m
Single flag commit to reduce the recompute of phasegradients.
-
Preshanth Jagannathan bc2967271806817b0c7ef5e59985d53052f679b6 m
BaselineType now utilizes the mean of the antennas in every bin of the grid to calculate the phasegradient.
-
Sanjay Bhatnagar 7c0d069c10315047b1ce92f1e86b0cad033bfe68 m
Chg: Reduced the number of (commented) debug cerr statments.
-
Sanjay Bhatnagar e97697fa4e911ef63d00183121b1c4c402b413fb m
Chg: Modified the print script for antenna list in an antenna group and posted it on Logger.
-
Sanjay Bhatnagar 9e0d3a9a4d347caea7b3db21cd991f8c5ee6658b m
Fix: Now passing CASA V<V<D>> instead STL v<v<d>>. And setting it as a reference as against assign.
- code/synthesis/TransformMachines2/BaselineType.cc (version 9e0d3a9a4d347caea7b3db21cd991f8c5ee6658b) (diffs)
- code/synthesis/TransformMachines2/BaselineType.h (version 9e0d3a9a4d347caea7b3db21cd991f8c5ee6658b) (diffs)
- code/synthesis/TransformMachines2/PhaseGrad.cc (version 9e0d3a9a4d347caea7b3db21cd991f8c5ee6658b) (diffs)
- code/synthesis/TransformMachines2/PointingOffsets.h (version 9e0d3a9a4d347caea7b3db21cd991f8c5ee6658b) (diffs)
-
Preshanth Jagannathan 303d2d991e6a0d3e1366153337ffbea674acbf5c m
BaselineType has antenna gridding changes in findAntennaGroups. A new method was introduced to set the PointingOffsets per grid cell. PhaseGrad has been altered to grab the phase gradient from the updated per antenna grid pointing value. It is all coordinated from VB2CFBMap which ensure that the compute is minimal. At this juncture there are no overflows of indices and loops and is a build to fall back to should we need to revisit the algorithm at a later date.
- code/synthesis/TransformMachines2/BaselineType.cc (version 303d2d991e6a0d3e1366153337ffbea674acbf5c) (diffs)
- code/synthesis/TransformMachines2/BaselineType.h (version 303d2d991e6a0d3e1366153337ffbea674acbf5c) (diffs)
- code/synthesis/TransformMachines2/PhaseGrad.cc (version 303d2d991e6a0d3e1366153337ffbea674acbf5c) (diffs)
- code/synthesis/TransformMachines2/PhaseGrad.h (version 303d2d991e6a0d3e1366153337ffbea674acbf5c) (diffs)
- code/synthesis/TransformMachines2/PointingOffsets.cc (version 303d2d991e6a0d3e1366153337ffbea674acbf5c) (diffs)
- code/synthesis/TransformMachines2/PointingOffsets.h (version 303d2d991e6a0d3e1366153337ffbea674acbf5c) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version 303d2d991e6a0d3e1366153337ffbea674acbf5c) (diffs)
-
Preshanth Jagannathan 1946875870da06530438d0471ad4955111bd283a m
Code clean-up of working code and the removal of redundant older code from VB2CFMAP and BaselineType objects.
- casacore (version 1946875870da06530438d0471ad4955111bd283a) (diffs)
- code/synthesis/TransformMachines2/BaselineType.cc (version 1946875870da06530438d0471ad4955111bd283a) (diffs)
- code/synthesis/TransformMachines2/BaselineType.h (version 1946875870da06530438d0471ad4955111bd283a) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version 1946875870da06530438d0471ad4955111bd283a) (diffs)
-
Sanjay Bhatnagar 35ed1d438f9bcffb22fc488f9cfff618cf24991e m
Fix: Intermediate check-in for fix for overflow in computations of antenna groups.
-
Preshanth Jagannathan af32346139bd0715504be02f17dc44a884b9f2fb m
The commit contains changes to AWVR to replace the getcfphase method. BaselineType has a more robust mean based compute of groups. VB2CFBMap contains the updated methods and blNeedsNewPOPG flag which determines if a new phase gradient is computed per row.
- code/synthesis/TransformMachines2/AWVisResampler.cc (version af32346139bd0715504be02f17dc44a884b9f2fb) (diffs)
- code/synthesis/TransformMachines2/BaselineType.cc (version af32346139bd0715504be02f17dc44a884b9f2fb) (diffs)
- code/synthesis/TransformMachines2/BaselineType.h (version af32346139bd0715504be02f17dc44a884b9f2fb) (diffs)
- code/synthesis/TransformMachines2/PointingOffsets.cc (version af32346139bd0715504be02f17dc44a884b9f2fb) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version af32346139bd0715504be02f17dc44a884b9f2fb) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.h (version af32346139bd0715504be02f17dc44a884b9f2fb) (diffs)
-
Preshanth Jagannathan 209284ddd5922b288d5365ca087af7bc1076fbfd m
Merge branch 'ARD-master' into ARD-23-fix
-
Preshanth Jagannathan 56a4e9be23b13aa0890978f020a8be2957d8d0e3 m
This is a large commit change where the internal working of BaselineType and VB2CFBMap has been altered. In addition PhaseGrad.cc required modifcations to support modifications based on what is altering the phase gradient compute. This is also an intermediate commit you are better of with the one after this.
- code/synthesis/TransformMachines2/BaselineType.cc (version 56a4e9be23b13aa0890978f020a8be2957d8d0e3) (diffs)
- code/synthesis/TransformMachines2/BaselineType.h (version 56a4e9be23b13aa0890978f020a8be2957d8d0e3) (diffs)
- code/synthesis/TransformMachines2/PhaseGrad.cc (version 56a4e9be23b13aa0890978f020a8be2957d8d0e3) (diffs)
- code/synthesis/TransformMachines2/PointingOffsets.h (version 56a4e9be23b13aa0890978f020a8be2957d8d0e3) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version 56a4e9be23b13aa0890978f020a8be2957d8d0e3) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.h (version 56a4e9be23b13aa0890978f020a8be2957d8d0e3) (diffs)
-
Preshanth Jagannathan 30c200679ce255cff4a94040706bd47236dcf230 m
Just fixed A2R in compare between existing PO and passed CF
-
Preshanth Jagannathan 0a58f49083b265eee46552ee03ffab6530c11b93 m
Two new flags have been added to both VB2CFBMap and PhaseGrad 1) needsNewFieldPG_p - compute PG for field change in VB2CFBMap 2) needsNewPOPG_p - compute PG for median PO changes in VB2CFBMap
PG::needsNewPhaseGrad still checks for change in maxCFShape.- code/synthesis/TransformMachines2/PhaseGrad.cc (version 0a58f49083b265eee46552ee03ffab6530c11b93) (diffs)
- code/synthesis/TransformMachines2/PhaseGrad.h (version 0a58f49083b265eee46552ee03ffab6530c11b93) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version 0a58f49083b265eee46552ee03ffab6530c11b93) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.h (version 0a58f49083b265eee46552ee03ffab6530c11b93) (diffs)
-
Preshanth Jagannathan 82699a296f44a87640b413a45954a7339bee785d m
Refactored such that both doP=F and doP=T use the same vectorPhaseGrad object. Some other changes also have reduced the memory footprint.
-
Preshanth Jagannathan edc369ec2ee4ea625c586cd9e6cd49decfb64708 m
Added the needsNewPhaseGrad_p parameter in VB2CFBMap and also cachedFieldId_p. These are in an effort to move the needs new phase gradient check into VB2CFBMap At this time it is still not complete and is still using the checks in phaseGrad
-
Preshanth Jagannathan b25b94cc023a655940fea84dbb2dff8cd4be23ad m
Moved the find baselineType_p->findAntennaGroups out of the row loop of the visbuffer. This should reduce the overhead of checking on existing cached values in BaselineType. Also moved the antenna statistic function into makeVBRow2CFBMap which is the control function for all operations done per VB
-
Preshanth Jagannathan 93377fb0b802746b8a1688c04675794e216454b9 m
Initial commit with the setBLPhaseGrad moved from BaselineType into VB2CFBMap
- code/synthesis/TransformMachines2/BaselineType.cc (version 93377fb0b802746b8a1688c04675794e216454b9) (diffs)
- code/synthesis/TransformMachines2/BaselineType.h (version 93377fb0b802746b8a1688c04675794e216454b9) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version 93377fb0b802746b8a1688c04675794e216454b9) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.h (version 93377fb0b802746b8a1688c04675794e216454b9) (diffs)
-
Preshanth Jagannathan d9f78ffb4bdaf38a2a662c817e63d98fb5a6b269 m
Merge branch 'ARD-23-fix' of https://open-bitbucket.nrao.edu/scm/casa/casa into ARD-23-fix. The conflicts have some extensive fixes. So please use either the commit before or after this merge.
-
Preshanth Jagannathan 3eb9f4f92f981f8a176da0be819b6abd137b570c m
Some code cleanup to remove compilation error messages.
-
Preshanth Jagannathan 7e7ee33585b9116a725c606dc3b3fffe1daf3da6 m
The changes for hetpointing fix should be in place.
- code/synthesis/TransformMachines2/BaselineType.cc (version 7e7ee33585b9116a725c606dc3b3fffe1daf3da6) (diffs)
- code/synthesis/TransformMachines2/BaselineType.h (version 7e7ee33585b9116a725c606dc3b3fffe1daf3da6) (diffs)
- code/synthesis/TransformMachines2/PointingOffsets.h (version 7e7ee33585b9116a725c606dc3b3fffe1daf3da6) (diffs)
-
Preshanth Jagannathan 419b155f932e2e9430307f5d97fd65a3f1c4f2f4 m
Fixing the default value of pointingoffsetsigdev in tclean. Changing the order of initialization of variable to prevent compilation warnings
-
Preshanth Jagannathan c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4 m
The edits are to ensure that the pointingsigdev flows from the user to VB2CFBMap. This is done directly using the VB2CFBMap->setPOSigmaDev call within the AWProject constructor. The only portion that might need some clarification are for the synthesis imager tool level access. One additional point of note while the parameter is a double coming in from the user we convert to float and back to double(redundant).
- code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
- code/synthesis/ImagerObjects/SynthesisImagerVi2.h (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
- code/synthesis/ImagerObjects/SynthesisUtilMethods.cc (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
- code/synthesis/ImagerObjects/SynthesisUtilMethods.h (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
- code/synthesis/TransformMachines2/AWProjectFT.cc (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
- code/synthesis/TransformMachines2/AWProjectFT.h (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
- code/synthesis/TransformMachines2/AWProjectWBFT.cc (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
- code/synthesis/TransformMachines2/AWProjectWBFT.h (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
- code/synthesis/TransformMachines2/AWProjectWBFTNew.h (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
- code/synthesis/TransformMachines2/BaselineType.cc (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.h (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
- gcwrap/python/scripts/task_tclean.py (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
- gcwrap/tasks/tclean.xml (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
- gcwrap/tools/synthesis/synthesisimager.xml (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
- gcwrap/tools/synthesis/synthesisimager_cmpt.cc (version c33fc8b5d4db8800000eaf0e3bbb9c3f9a7c6cc4) (diffs)
-
Preshanth Jagannathan 2cef6be5843742a7c2761a5d91261ad889fd25a8 m
Merge branch 'ARD-23-fix' of https://open-bitbucket.nrao.edu/scm/casa/casa into ARD-23-fix
-
Preshanth Jagannathan c6de5f9399ae7981d05ad0859a64e555122bf74c m
The edits in BaselineType are for caching of the antennaGroups which is and expensive operation to perform per VB. Some of the control logic for the BaselineType operations have been moved from VB2CFBMap into the class BaselineType.
- code/synthesis/TransformMachines2/BaselineType.cc (version c6de5f9399ae7981d05ad0859a64e555122bf74c) (diffs)
- code/synthesis/TransformMachines2/BaselineType.h (version c6de5f9399ae7981d05ad0859a64e555122bf74c) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version c6de5f9399ae7981d05ad0859a64e555122bf74c) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.h (version c6de5f9399ae7981d05ad0859a64e555122bf74c) (diffs)
-
Preshanth Jagannathan 7edf0bb5bfbdc0714a54f8984ba7cf800e9639a2 m
The BaselineType object was missing the call to compute the phase gradient for a mosaic pointing. That has been included.
-
Preshanth Jagannathan f8211b78fc6c1cda3b526e2171e6cff17a9dd17d m
Merge branch 'ARD-25-fix' into ARD-23-fix
-
Sanjay Bhatnagar f2c3e8fe10ef473454dafb9c7d283f8560e98968 m
VB2CFBMap: Dtor prints accumulated time for baselineType_p calls + total VBs processed. BaselineType: doPointing=F now makes findAntennaGroups() a NoOp. Removed LogIO construction per VB.
- code/synthesis/TransformMachines2/BaselineType.cc (version f2c3e8fe10ef473454dafb9c7d283f8560e98968) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version f2c3e8fe10ef473454dafb9c7d283f8560e98968) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.h (version f2c3e8fe10ef473454dafb9c7d283f8560e98968) (diffs)
-
Preshanth Jagannathan 6b97e3acfc62d3524ceee36d110c2e84c01cf488 m
The changes are such that AWProject now passes doPointing to VB2CFBMap. VB2CFBMap has been refactored to include the BaselineType Class. The sigmaDev control parameter has been set as an environment variable for the identification of antenna groups. BaselineType class produces a map of indices of the vector of phase grad pointers that is utilized to tell the gridder which phasegrad to use for a given baseline.
Note: This commit for some reason has made the code run slower. This is
a commit as it contains the first working implementation of the heterogenous
pointing group.- code/synthesis/TransformMachines2/AWProjectFT.cc (version 6b97e3acfc62d3524ceee36d110c2e84c01cf488) (diffs)
- code/synthesis/TransformMachines2/BaselineType.cc (version 6b97e3acfc62d3524ceee36d110c2e84c01cf488) (diffs)
- code/synthesis/TransformMachines2/BaselineType.h (version 6b97e3acfc62d3524ceee36d110c2e84c01cf488) (diffs)
- code/synthesis/TransformMachines2/PhaseGrad.h (version 6b97e3acfc62d3524ceee36d110c2e84c01cf488) (diffs)
- code/synthesis/TransformMachines2/Utils.cc (version 6b97e3acfc62d3524ceee36d110c2e84c01cf488) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version 6b97e3acfc62d3524ceee36d110c2e84c01cf488) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.h (version 6b97e3acfc62d3524ceee36d110c2e84c01cf488) (diffs)
-
Sanjay Bhatnagar cb5a0cc094fce25b64c39139071d2129c31446e7 m
Replaced PhaseGrad with BaselineType. PhaseGrad is now owned, and given access to, via the BaselineType class.
-
Sanjay Bhatnagar e610ac25008e0521e5eac76f93ff32459c4458bd m
Added PO::setOversampling() in ::findConvFunction(). See the in-code comments for more details.
-
Preshanth Jagannathan 03b5694523e4ee751152abdf9099a8d10029a5ce m
Creation of class BaseLineType. It is done to ensure that the phaseGrad is created once for each BaselineType and cached when first encountering a new visbuffer. BaselineType object contains methods findAntennaGroups, and makeVBRow2BLGMap for now.
- code/synthesis/CMakeLists.txt (version 03b5694523e4ee751152abdf9099a8d10029a5ce) (diffs)
- code/synthesis/TransformMachines2/BaselineType.cc (version 03b5694523e4ee751152abdf9099a8d10029a5ce) (diffs)
- code/synthesis/TransformMachines2/BaselineType.h (version 03b5694523e4ee751152abdf9099a8d10029a5ce) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version 03b5694523e4ee751152abdf9099a8d10029a5ce) (diffs)
-
Preshanth Jagannathan 9a40f85aadc8f9d947bd9ee615d541c4cc4cebd5 m
This commit is to enable antenna group finding given a sigma threshold for binning antenna pointing deviations from the median. The is done in the following fashion steps.
1. PointingOffsets.cc has an additional method PO::fetchAntOffsetToPix
which will return the antenna offset from the vb direction.
2. This allows us to determine per vb the individual antenna offsets
which is done by VB2CFBMap::findAntennaGroups
3. Once the groups are identified it returns the information to the
control method VB2CFMap::makeVBRow2BLGMap which returns a list of baseline
groups per row of the vb given an antenna. The groups are computed using
the formula NBLG = NG + (NG C 2).
This commit does not include the plugin to activate this code. That will
follow shortly- code/synthesis/TransformMachines2/PointingOffsets.cc (version 9a40f85aadc8f9d947bd9ee615d541c4cc4cebd5) (diffs)
- code/synthesis/TransformMachines2/PointingOffsets.h (version 9a40f85aadc8f9d947bd9ee615d541c4cc4cebd5) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version 9a40f85aadc8f9d947bd9ee615d541c4cc4cebd5) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.h (version 9a40f85aadc8f9d947bd9ee615d541c4cc4cebd5) (diffs)
-
Sanjay Bhatnagar 1c3d0c4e4145c49e98359d25ede8f2d838e9d408 m
Commit to instantiate PointingOffset object in AWP as a CountedPtr. The PO object is passed to VB2CFBMap, which in-turn passes, where necessary, to the PhaseGrad object. PO and VB2CFBMap objects are owned by AWP. VB2CFBMap owns the PhaseGrad object internally.
PO has been removed from SyImagerVi2 and ConvolutionFunction line of
classes. PO::findPointingOffsets() and ::getPointingOffsets() have
been re-named to ::fetchPointingOffsets() and
::pullPointingOffsets(). The former triggers getting the offsets from
the POINTING or FIELD sub-tables, while the latter returns the offsets
from the PO object (cached from the last fetch).- code/synthesis/ImagerObjects/SynthesisImagerVi2.cc (version 1c3d0c4e4145c49e98359d25ede8f2d838e9d408) (diffs)
- code/synthesis/TransformMachines2/AWConvFunc.cc (version 1c3d0c4e4145c49e98359d25ede8f2d838e9d408) (diffs)
- code/synthesis/TransformMachines2/AWConvFunc.h (version 1c3d0c4e4145c49e98359d25ede8f2d838e9d408) (diffs)
- code/synthesis/TransformMachines2/AWProjectFT.cc (version 1c3d0c4e4145c49e98359d25ede8f2d838e9d408) (diffs)
- code/synthesis/TransformMachines2/AWProjectFT.h (version 1c3d0c4e4145c49e98359d25ede8f2d838e9d408) (diffs)
- code/synthesis/TransformMachines2/AWProjectWBFT.cc (version 1c3d0c4e4145c49e98359d25ede8f2d838e9d408) (diffs)
- code/synthesis/TransformMachines2/ConvolutionFunction.h (version 1c3d0c4e4145c49e98359d25ede8f2d838e9d408) (diffs)
- code/synthesis/TransformMachines2/IlluminationConvFunc.h (version 1c3d0c4e4145c49e98359d25ede8f2d838e9d408) (diffs)
- code/synthesis/TransformMachines2/PhaseGrad.cc (version 1c3d0c4e4145c49e98359d25ede8f2d838e9d408) (diffs)
- code/synthesis/TransformMachines2/PhaseGrad.h (version 1c3d0c4e4145c49e98359d25ede8f2d838e9d408) (diffs)
- code/synthesis/TransformMachines2/PointingOffsets.cc (version 1c3d0c4e4145c49e98359d25ede8f2d838e9d408) (diffs)
- code/synthesis/TransformMachines2/PointingOffsets.h (version 1c3d0c4e4145c49e98359d25ede8f2d838e9d408) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.cc (version 1c3d0c4e4145c49e98359d25ede8f2d838e9d408) (diffs)
- code/synthesis/TransformMachines2/VB2CFBMap.h (version 1c3d0c4e4145c49e98359d25ede8f2d838e9d408) (diffs)
OPEN-CASA-PKG
-
Akeem Wells 68ce76b3831ba4393fdec435a4480af602f64609
Merge pull request #129 in CASA/casa-pkg from hotfix/CAS-12905 to master
* commit '4d0de02230f884ac522299be9ba81140c0f74187':
Remove 5155 VISSTAT from pybot-accepted. It has been merged with test_req_task_visstat ( number: 2555 ) -
Akeem Wells <awells@humite.local> 4d0de02230f884ac522299be9ba81140c0f74187
Remove 5155 VISSTAT from pybot-accepted. It has been merged with test_req_task_visstat ( number: 2555 )