Pull request #850: CAS-14218
Merge in CASA/casa6 from CAS-14218 to master
* commit '76a73df42bbb7c827c85845db494af4ee088e64f':
remove reference to almatasks in casatestutils. Update component_to_test_map.json for wvrgcal ( update almatasks to casatasks ) CAS-14218: introduced new parameter "rseed" (random seed) in the user interface of task wvrgcal and the tool method wvr.gcal(). Default value 0 (zero) means that internally the original seed value of 43 is used. CAS-14218: made changes to remove "almatasks" and Python 2 compatibility CAS-14218: mostly re-coded the method loadCSV. The "almatasks" version had used boost heavily and my first refactoring was not good. Now using sstream. CAS-14218: increased the CPARAM phase angle comparison tolerance in unit test case test11 by factor 2 in order to accommodate differences between Linux and MacOS. CAS-14218: Fixed bug in method ALMAAbsProcessor(). The list of pointers to ALMAResBase objects wasn't properly iterated. (Only had an impact when nsol>1). Updated wvrgcal task unit test to partially use new reference caltables created in CAS-14294. CAS-14218: fixed bug in the handling of the "reversespw" parameter of the wvrgcal task script (introduced during the refactoring) CAS-14218: fixed an old bug in the time interpolation of the dtdl coefficients. The interpolation formula was multiplying the previous and the next (in time) coefficent with swapped factors.
Make air_casawvr dependency on synthesis PRIVATE CAS-14218: task return dictionary now also contains a list "Frac_unflagged" which contains the fraction of unflagged WVR datapoints per antenna. Updated unit test to exercise this new feature.
Fix air_casawvr linking CAS-14218: First completely running version with proper logging and return dict. CAS-14218: fixed a segfault and improved error handling. The task unit test completes now but still fails. The return dictionary is not yet filled correctly. CAS-14218: eliminated a memory allocation error (which occured in the context of replacing boost::const_multi_array_ref by what is available in C++11 and casacore) CAS-14218: removed/modified all references to "almatasks" to take into account that wvrgcal is now a normal task in casatasks. Created the task unit test test_task_wvrgcal.py from the old casa5 version. It does not pass, yet. wvr.gcal() still needs to be debugged. CAS-14218: first CASA6 version of the wvrgcal task - built but not yet tested CAS-14218: disabled the use (and compilation) of the pda_lmdif__() function code which is F77 and was also disabled in the original wvrgcal bnmin1 code. It was just accidentally enabled during refactoring. CAS-14218: first version with the new "wvr" tool. This version builds but has not been tested otherwise. CAS-14218: code copied over from branch prelim_wvrgcal2. This is the first version of the refactored code for the air_casawvr and bnmin1 libraries which builds without errors. No testing done, yet.